Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
Files | Infos | Warnings | Errors |
41 | 0 | 0 | 731 |
Files
net/sourceforge/simplegamenet/chess/ChessBishop.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| Missing a Javadoc comment. |
5
|
| Parameter participantOwnerIndex should be final. |
5
|
| Parameter x should be final. |
5
|
| Parameter y should be final. |
5
|
| Method 'isMoveAllowed' is not designed for extension - needs to be abstract, final or empty. |
9
|
| Missing a Javadoc comment. |
9
|
| Parameter pieceGrid should be final. |
9
|
| Parameter destinationX should be final. |
10
|
| Parameter destinationY should be final. |
10
|
| Avoid inline conditionals. |
19
|
| Avoid inline conditionals. |
20
|
| Method 'getPieceType' is not designed for extension - needs to be abstract, final or empty. |
28
|
| Missing a Javadoc comment. |
28
|
| Method 'getPieceValue' is not designed for extension - needs to be abstract, final or empty. |
32
|
| Missing a Javadoc comment. |
32
|
| '3' is a magic number. |
33
|
net/sourceforge/simplegamenet/chess/ChessFactory.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
14
|
| Line is longer than 80 characters. |
15
|
| Method 'createGamePlayerClient' is not designed for extension - needs to be abstract, final or empty. |
18
|
| Missing a Javadoc comment. |
18
|
| Parameter clientEngine should be final. |
18
|
| Method 'createGameServer' is not designed for extension - needs to be abstract, final or empty. |
22
|
| Missing a Javadoc comment. |
22
|
| Parameter serverEngine should be final. |
22
|
| Method 'createDefaultGameSettings' is not designed for extension - needs to be abstract, final or empty. |
26
|
| Missing a Javadoc comment. |
26
|
net/sourceforge/simplegamenet/chess/ChessGridSize.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| interfaces should describe a type and hence have methods. |
3
|
| Missing a Javadoc comment. |
5
|
| Redundant 'public' modifier. |
5
|
| Missing a Javadoc comment. |
6
|
| Redundant 'public' modifier. |
6
|
net/sourceforge/simplegamenet/chess/ChessKing.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
7
|
| Parameter participantOwnerIndex should be final. |
7
|
| Parameter x should be final. |
7
|
| Parameter y should be final. |
7
|
| Method 'isMoveAllowed' is not designed for extension - needs to be abstract, final or empty. |
11
|
| Missing a Javadoc comment. |
11
|
| Parameter pieceGrid should be final. |
11
|
| Parameter destinationX should be final. |
12
|
| Parameter destinationY should be final. |
12
|
| Line is longer than 80 characters. |
17
|
| Line is longer than 80 characters. |
18
|
| Line is longer than 80 characters. |
25
|
| Conditional logic can be removed. |
25
|
| '7' is a magic number. |
25
|
| '7' is a magic number. |
26
|
| '7' is a magic number. |
27
|
| Line is longer than 80 characters. |
33
|
| Conditional logic can be removed. |
33
|
| Line is longer than 80 characters. |
40
|
| Method 'doMove' is not designed for extension - needs to be abstract, final or empty. |
40
|
| Missing a Javadoc comment. |
40
|
| Parameter pieceGrid should be final. |
40
|
| Parameter destinationX should be final. |
40
|
| Parameter destinationY should be final. |
40
|
| Line is longer than 80 characters. |
43
|
| Line is longer than 80 characters. |
45
|
| '7' is a magic number. |
45
|
| Method 'getPieceType' is not designed for extension - needs to be abstract, final or empty. |
52
|
| Missing a Javadoc comment. |
52
|
| Method 'getPieceValue' is not designed for extension - needs to be abstract, final or empty. |
56
|
| Missing a Javadoc comment. |
56
|
| '100' is a magic number. |
57
|
net/sourceforge/simplegamenet/chess/ChessKnight.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| Missing a Javadoc comment. |
5
|
| Parameter participantOwnerIndex should be final. |
5
|
| Parameter x should be final. |
5
|
| Parameter y should be final. |
5
|
| Method 'isMoveAllowed' is not designed for extension - needs to be abstract, final or empty. |
9
|
| Missing a Javadoc comment. |
9
|
| Parameter pieceGrid should be final. |
9
|
| Parameter destinationX should be final. |
10
|
| Parameter destinationY should be final. |
10
|
| Line is longer than 80 characters. |
15
|
| Conditional logic can be removed. |
15
|
| '3' is a magic number. |
15
|
| Line is longer than 80 characters. |
16
|
| Method 'getPieceType' is not designed for extension - needs to be abstract, final or empty. |
23
|
| Missing a Javadoc comment. |
23
|
| Method 'getPieceValue' is not designed for extension - needs to be abstract, final or empty. |
27
|
| Missing a Javadoc comment. |
27
|
| '3' is a magic number. |
28
|
net/sourceforge/simplegamenet/chess/ChessMove.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
7
|
| Variable 'sourceX' must be private and have accessor methods. |
7
|
| Missing a Javadoc comment. |
8
|
| Variable 'sourceY' must be private and have accessor methods. |
8
|
| Missing a Javadoc comment. |
9
|
| Variable 'destinationX' must be private and have accessor methods. |
9
|
| Missing a Javadoc comment. |
10
|
| Variable 'destinationY' must be private and have accessor methods. |
10
|
| Missing a Javadoc comment. |
11
|
| Variable 'chosenPieceType' must be private and have accessor methods. |
11
|
| Line is longer than 80 characters. |
13
|
| Missing a Javadoc comment. |
13
|
| Parameter sourceX should be final. |
13
|
| 'sourceX' hides a field. |
13
|
| Parameter sourceY should be final. |
13
|
| 'sourceY' hides a field. |
13
|
| Parameter destinationX should be final. |
13
|
| 'destinationX' hides a field. |
13
|
| Parameter destinationY should be final. |
13
|
| 'destinationY' hides a field. |
13
|
| Parameter chosenPieceType should be final. |
14
|
| 'chosenPieceType' hides a field. |
14
|
net/sourceforge/simplegamenet/chess/ChessPacket.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
7
|
| Variable 'packetCode' must be private and have accessor methods. |
7
|
| Missing a Javadoc comment. |
8
|
| Variable 'data' must be private and have accessor methods. |
8
|
| Missing a Javadoc comment. |
10
|
| Parameter packetCode should be final. |
10
|
| 'packetCode' hides a field. |
10
|
| Parameter data should be final. |
10
|
| 'data' hides a field. |
10
|
net/sourceforge/simplegamenet/chess/ChessPacketCodes.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| interfaces should describe a type and hence have methods. |
3
|
| Missing a Javadoc comment. |
5
|
| Redundant 'public' modifier. |
5
|
| Missing a Javadoc comment. |
7
|
| Redundant 'public' modifier. |
7
|
| Missing a Javadoc comment. |
8
|
| Redundant 'public' modifier. |
8
|
| Missing a Javadoc comment. |
9
|
| Redundant 'public' modifier. |
9
|
| Missing a Javadoc comment. |
11
|
| Redundant 'public' modifier. |
11
|
| Missing a Javadoc comment. |
12
|
| Redundant 'public' modifier. |
12
|
| Missing a Javadoc comment. |
14
|
| Redundant 'public' modifier. |
14
|
| Missing a Javadoc comment. |
15
|
| Redundant 'public' modifier. |
15
|
| Missing a Javadoc comment. |
16
|
| Redundant 'public' modifier. |
16
|
| Missing a Javadoc comment. |
18
|
| Redundant 'public' modifier. |
18
|
| Missing a Javadoc comment. |
19
|
| Redundant 'public' modifier. |
19
|
| Missing a Javadoc comment. |
21
|
| Redundant 'public' modifier. |
21
|
| Missing a Javadoc comment. |
22
|
| Redundant 'public' modifier. |
22
|
| Missing a Javadoc comment. |
24
|
| Redundant 'public' modifier. |
24
|
net/sourceforge/simplegamenet/chess/ChessPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
5
|
| Line is longer than 80 characters. |
7
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
19
|
| Line is longer than 80 characters. |
20
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
21
|
| Missing a Javadoc comment. |
22
|
| Missing a Javadoc comment. |
23
|
| Missing a Javadoc comment. |
24
|
| Missing a Javadoc comment. |
25
|
| Missing a Javadoc comment. |
26
|
| Missing a Javadoc comment. |
28
|
| Parameter chessPlayerClient should be final. |
28
|
| 'chessPlayerClient' hides a field. |
28
|
| Parameter chatClientPanel should be final. |
29
|
| '10' is a magic number. |
37
|
| '10' is a magic number. |
39
|
| '10' is a magic number. |
42
|
| '10' is a magic number. |
44
|
| '10' is a magic number. |
46
|
| '10' is a magic number. |
48
|
| '10' is a magic number. |
50
|
| Line is longer than 80 characters. |
54
|
| Line is longer than 80 characters. |
59
|
| '11' is a magic number. |
59
|
| '10' is a magic number. |
59
|
| '4' is a magic number. |
62
|
| '4' is a magic number. |
64
|
| '4' is a magic number. |
65
|
| '4' is a magic number. |
66
|
| '4' is a magic number. |
66
|
| '6' is a magic number. |
68
|
| '3' is a magic number. |
68
|
| '4' is a magic number. |
68
|
| '6' is a magic number. |
68
|
| '8' is a magic number. |
70
|
| '3' is a magic number. |
70
|
| '4' is a magic number. |
70
|
| '8' is a magic number. |
70
|
| '10' is a magic number. |
71
|
| '3' is a magic number. |
71
|
| '4' is a magic number. |
71
|
| '10' is a magic number. |
71
|
| Method 'setPieceOwnerSight' is not designed for extension - needs to be abstract, final or empty. |
74
|
| Missing a Javadoc comment. |
74
|
| Parameter pieceOwnerSight should be final. |
74
|
| Method 'handleTurn' is not designed for extension - needs to be abstract, final or empty. |
78
|
| Missing a Javadoc comment. |
78
|
| Missing a Javadoc comment. |
83
|
| Method 'getRemiseOfferAnswer' is not designed for extension - needs to be abstract, final or empty. |
87
|
| Missing a Javadoc comment. |
87
|
| Method 'setRemiseOfferAnswer' is not designed for extension - needs to be abstract, final or empty. |
94
|
| Missing a Javadoc comment. |
94
|
| Parameter remiseOfferAccepted should be final. |
94
|
| Method 'setEnabled' is not designed for extension - needs to be abstract, final or empty. |
106
|
| Missing a Javadoc comment. |
106
|
| Parameter enabled should be final. |
106
|
| Line is longer than 80 characters. |
113
|
| Method 'makeMove' is not designed for extension - needs to be abstract, final or empty. |
113
|
| Missing a Javadoc comment. |
113
|
| Parameter sourceX should be final. |
113
|
| Parameter sourceY should be final. |
113
|
| Parameter destinationX should be final. |
113
|
| Parameter destinationY should be final. |
113
|
| Line is longer than 80 characters. |
117
|
| Line is longer than 80 characters. |
138
|
| Line is longer than 80 characters. |
141
|
| Method 'actionPerformed' is not designed for extension - needs to be abstract, final or empty. |
146
|
| Missing a Javadoc comment. |
146
|
| Parameter actionEvent should be final. |
146
|
| Method 'setPlayFieldState' is not designed for extension - needs to be abstract, final or empty. |
172
|
| Missing a Javadoc comment. |
172
|
| Parameter playFieldState should be final. |
172
|
| switch without "default" clause. |
173
|
| Method 'setOtherParticipantAtTurn' is not designed for extension - needs to be abstract, final or empty. |
195
|
| Missing a Javadoc comment. |
195
|
| Parameter nickname should be final. |
195
|
| Method 'setWinnerThisPlayer' is not designed for extension - needs to be abstract, final or empty. |
199
|
| Missing a Javadoc comment. |
199
|
| Method 'setWinner' is not designed for extension - needs to be abstract, final or empty. |
204
|
| Missing a Javadoc comment. |
204
|
| Parameter nickname should be final. |
204
|
| Method 'setNoWinner' is not designed for extension - needs to be abstract, final or empty. |
209
|
| Missing a Javadoc comment. |
209
|
| Line is longer than 80 characters. |
214
|
| Method 'setLastMove' is not designed for extension - needs to be abstract, final or empty. |
214
|
| Missing a Javadoc comment. |
214
|
| Parameter sourceX should be final. |
214
|
| Parameter sourceY should be final. |
214
|
| Parameter destinationX should be final. |
214
|
| Parameter destinationY should be final. |
214
|
| Line is longer than 80 characters. |
221
|
| Method 'playFieldUpdated' is not designed for extension - needs to be abstract, final or empty. |
221
|
| Missing a Javadoc comment. |
221
|
| Parameter pieceTypeGrid should be final. |
221
|
| Parameter pieceOwnerGrid should be final. |
221
|
net/sourceforge/simplegamenet/chess/ChessPawn.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| Missing a Javadoc comment. |
5
|
| Parameter participantOwnerIndex should be final. |
5
|
| Parameter x should be final. |
5
|
| Parameter y should be final. |
5
|
| Method 'isMoveAllowed' is not designed for extension - needs to be abstract, final or empty. |
9
|
| Missing a Javadoc comment. |
9
|
| Parameter pieceGrid should be final. |
9
|
| Parameter destinationX should be final. |
10
|
| Parameter destinationY should be final. |
10
|
| Avoid inline conditionals. |
17
|
| Avoid inline conditionals. |
21
|
| Conditional logic can be removed. |
23
|
| Avoid inline conditionals. |
24
|
| Method 'getPieceType' is not designed for extension - needs to be abstract, final or empty. |
36
|
| Missing a Javadoc comment. |
36
|
| Method 'getPieceValue' is not designed for extension - needs to be abstract, final or empty. |
40
|
| Missing a Javadoc comment. |
40
|
| Method 'isReplaceChoiceNeeded' is not designed for extension - needs to be abstract, final or empty. |
44
|
| Missing a Javadoc comment. |
44
|
| Parameter destinationX should be final. |
44
|
| Parameter destinationY should be final. |
44
|
| Avoid inline conditionals. |
45
|
net/sourceforge/simplegamenet/chess/ChessPiece.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
5
|
| Missing a Javadoc comment. |
5
|
| 'public' modifier out of order with the JLS suggestions. |
5
|
| Missing a Javadoc comment. |
7
|
| Variable 'participantOwnerIndex' must be private and have accessor methods. |
7
|
| Missing a Javadoc comment. |
8
|
| Variable 'x' must be private and have accessor methods. |
8
|
| Missing a Javadoc comment. |
9
|
| Variable 'y' must be private and have accessor methods. |
9
|
| Missing a Javadoc comment. |
11
|
| Parameter participantOwnerIndex should be final. |
11
|
| 'participantOwnerIndex' hides a field. |
11
|
| Parameter x should be final. |
11
|
| 'x' hides a field. |
11
|
| Parameter y should be final. |
11
|
| 'y' hides a field. |
11
|
| Missing a Javadoc comment. |
17
|
| Parameter pieceGrid should be final. |
17
|
| Parameter destinationX should be final. |
18
|
| Parameter destinationY should be final. |
18
|
| Line is longer than 80 characters. |
20
|
| Method 'doMove' is not designed for extension - needs to be abstract, final or empty. |
20
|
| Missing a Javadoc comment. |
20
|
| Parameter pieceGrid should be final. |
20
|
| Parameter destinationX should be final. |
20
|
| Parameter destinationY should be final. |
20
|
| Method 'getParticipantsOwnerIndex' is not designed for extension - needs to be abstract, final or empty. |
27
|
| Missing a Javadoc comment. |
27
|
| Method 'isInPlayField' is not designed for extension - needs to be abstract, final or empty. |
31
|
| Missing a Javadoc comment. |
31
|
| Method 'getX' is not designed for extension - needs to be abstract, final or empty. |
35
|
| Missing a Javadoc comment. |
35
|
| Method 'getY' is not designed for extension - needs to be abstract, final or empty. |
39
|
| Missing a Javadoc comment. |
39
|
| Method 'clone' is not designed for extension - needs to be abstract, final or empty. |
43
|
| Missing a Javadoc comment. |
43
|
| Missing a Javadoc comment. |
52
|
| Missing a Javadoc comment. |
54
|
net/sourceforge/simplegamenet/chess/ChessPieceOwner.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| interfaces should describe a type and hence have methods. |
3
|
| Missing a Javadoc comment. |
5
|
| Redundant 'public' modifier. |
5
|
| Missing a Javadoc comment. |
6
|
| Redundant 'public' modifier. |
6
|
| Missing a Javadoc comment. |
7
|
| Redundant 'public' modifier. |
7
|
net/sourceforge/simplegamenet/chess/ChessPieceType.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| interfaces should describe a type and hence have methods. |
3
|
| Missing a Javadoc comment. |
5
|
| Redundant 'public' modifier. |
5
|
| Missing a Javadoc comment. |
6
|
| Redundant 'public' modifier. |
6
|
| Missing a Javadoc comment. |
7
|
| Redundant 'public' modifier. |
7
|
| Missing a Javadoc comment. |
8
|
| Redundant 'public' modifier. |
8
|
| Missing a Javadoc comment. |
9
|
| Redundant 'public' modifier. |
9
|
| Missing a Javadoc comment. |
10
|
| Redundant 'public' modifier. |
10
|
| Missing a Javadoc comment. |
11
|
| Redundant 'public' modifier. |
11
|
net/sourceforge/simplegamenet/chess/ChessPlayField.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
5
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
53
|
| Parameter checkingPieceGrid should be final. |
53
|
| Parameter participantsOwnerIndex should be final. |
54
|
| Line is longer than 80 characters. |
58
|
| Line is longer than 80 characters. |
68
|
| Line is longer than 80 characters. |
69
|
| Missing a Javadoc comment. |
76
|
| Parameter checkingPieceGrid should be final. |
76
|
| Parameter participantsOwnerIndex should be final. |
77
|
| Line is longer than 80 characters. |
85
|
| Line is longer than 80 characters. |
88
|
| Line is longer than 80 characters. |
93
|
| Missing a Javadoc comment. |
103
|
| Missing a Javadoc comment. |
105
|
| Missing a Javadoc comment. |
106
|
| Missing a Javadoc comment. |
108
|
| Missing a Javadoc comment. |
110
|
| Missing a Javadoc comment. |
112
|
| Parameter participantsOrder should be final. |
112
|
| 'participantsOrder' hides a field. |
112
|
| switch without "default" clause. |
118
|
| switch without "default" clause. |
126
|
| Line is longer than 80 characters. |
131
|
| Line is longer than 80 characters. |
134
|
| Line is longer than 80 characters. |
137
|
| Method 'getParticipantAtTurnPlayerID' is not designed for extension - needs to be abstract, final or empty. |
151
|
| Missing a Javadoc comment. |
151
|
| Method 'isMoveAllowed' is not designed for extension - needs to be abstract, final or empty. |
155
|
| Missing a Javadoc comment. |
155
|
| Parameter sourceX should be final. |
155
|
| Parameter sourceY should be final. |
155
|
| Line is longer than 80 characters. |
156
|
| Parameter destinationX should be final. |
156
|
| Parameter destinationY should be final. |
156
|
| Parameter chosenPieceType should be final. |
156
|
| Line is longer than 80 characters. |
163
|
| Missing a Javadoc comment. |
184
|
| Parameter sourceX should be final. |
184
|
| Parameter sourceY should be final. |
184
|
| Parameter destinationX should be final. |
185
|
| Parameter destinationY should be final. |
185
|
| Line is longer than 80 characters. |
207
|
| Method 'doMove' is not designed for extension - needs to be abstract, final or empty. |
207
|
| Missing a Javadoc comment. |
207
|
| Parameter sourceX should be final. |
207
|
| Parameter sourceY should be final. |
207
|
| Parameter destinationX should be final. |
207
|
| Parameter destinationY should be final. |
207
|
| Parameter chosenPieceType should be final. |
208
|
| Line is longer than 80 characters. |
209
|
| switch without "default" clause. |
212
|
| Line is longer than 80 characters. |
215
|
| Line is longer than 80 characters. |
221
|
| Line is longer than 80 characters. |
227
|
| Line is longer than 80 characters. |
233
|
| Line is longer than 80 characters. |
242
|
| Method 'setWaitingForRemiseOfferAnswer' is not designed for extension - needs to be abstract, final or empty. |
262
|
| Missing a Javadoc comment. |
262
|
| Method 'setRemiseOfferAnswer' is not designed for extension - needs to be abstract, final or empty. |
266
|
| Missing a Javadoc comment. |
266
|
| Parameter remiseOfferAccepted should be final. |
266
|
| Method 'yieldGame' is not designed for extension - needs to be abstract, final or empty. |
275
|
| Missing a Javadoc comment. |
275
|
| Parameter playerID should be final. |
275
|
| Line is longer than 80 characters. |
284
|
| Method 'getMoveSourceAllowedGrid' is not designed for extension - needs to be abstract, final or empty. |
288
|
| Missing a Javadoc comment. |
288
|
| Line is longer than 80 characters. |
289
|
| Line is longer than 80 characters. |
292
|
| Method 'getMoveDestinationAllowedGrid' is not designed for extension - needs to be abstract, final or empty. |
301
|
| Missing a Javadoc comment. |
301
|
| Parameter sourceX should be final. |
301
|
| Parameter sourceY should be final. |
301
|
| Line is longer than 80 characters. |
302
|
| Line is longer than 80 characters. |
305
|
| Method 'isReplaceChoiceNeeded' is not designed for extension - needs to be abstract, final or empty. |
311
|
| Missing a Javadoc comment. |
311
|
| Parameter sourceX should be final. |
311
|
| Parameter sourceY should be final. |
311
|
| Parameter destinationX should be final. |
312
|
| Parameter destinationY should be final. |
312
|
| Line is longer than 80 characters. |
314
|
| Method 'getPieceOwnerSight' is not designed for extension - needs to be abstract, final or empty. |
319
|
| Missing a Javadoc comment. |
319
|
| Parameter clientPlayerID should be final. |
319
|
| Method 'getPlayFieldState' is not designed for extension - needs to be abstract, final or empty. |
328
|
| Missing a Javadoc comment. |
328
|
| Method 'getPieceTypeGrid' is not designed for extension - needs to be abstract, final or empty. |
332
|
| Missing a Javadoc comment. |
332
|
| Line is longer than 80 characters. |
339
|
| Method 'getPieceOwnerGrid' is not designed for extension - needs to be abstract, final or empty. |
346
|
| Missing a Javadoc comment. |
346
|
| Line is longer than 80 characters. |
353
|
| Method 'getState' is not designed for extension - needs to be abstract, final or empty. |
370
|
| Missing a Javadoc comment. |
370
|
| Method 'getPieceGrid' is not designed for extension - needs to be abstract, final or empty. |
374
|
| Missing a Javadoc comment. |
374
|
net/sourceforge/simplegamenet/chess/ChessPlayFieldComponent.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
3
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
5
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
22
|
| Missing a Javadoc comment. |
23
|
| Missing a Javadoc comment. |
25
|
| Missing a Javadoc comment. |
26
|
| Missing a Javadoc comment. |
28
|
| Missing a Javadoc comment. |
29
|
| Missing a Javadoc comment. |
30
|
| Missing a Javadoc comment. |
31
|
| Missing a Javadoc comment. |
33
|
| Line is longer than 80 characters. |
35
|
| Missing a Javadoc comment. |
35
|
| Parameter chessPlayerClient should be final. |
35
|
| 'chessPlayerClient' hides a field. |
35
|
| Parameter chessPanel should be final. |
35
|
| 'chessPanel' hides a field. |
35
|
| Parameter piecesImage should be final. |
36
|
| 'piecesImage' hides a field. |
36
|
| Parameter squaresImage should be final. |
36
|
| 'squaresImage' hides a field. |
36
|
| Line is longer than 80 characters. |
42
|
| Line is longer than 80 characters. |
44
|
| Method 'setPieceOwnerSight' is not designed for extension - needs to be abstract, final or empty. |
50
|
| Missing a Javadoc comment. |
50
|
| Parameter pieceOwnerSight should be final. |
50
|
| 'pieceOwnerSight' hides a field. |
50
|
| Method 'setEnabled' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Missing a Javadoc comment. |
54
|
| Parameter enabled should be final. |
54
|
| Line is longer than 80 characters. |
57
|
| Line is longer than 80 characters. |
67
|
| Method 'playFieldUpdated' is not designed for extension - needs to be abstract, final or empty. |
67
|
| Missing a Javadoc comment. |
67
|
| Parameter pieceTypeGrid should be final. |
67
|
| 'pieceTypeGrid' hides a field. |
67
|
| Parameter pieceOwnerGrid should be final. |
67
|
| 'pieceOwnerGrid' hides a field. |
67
|
| Method 'paintComponent' is not designed for extension - needs to be abstract, final or empty. |
73
|
| Missing a Javadoc comment. |
73
|
| Parameter graphics should be final. |
73
|
| switch without "default" clause. |
79
|
| Line is longer than 80 characters. |
86
|
| Line is longer than 80 characters. |
87
|
| Line is longer than 80 characters. |
96
|
| Line is longer than 80 characters. |
100
|
| '3' is a magic number. |
100
|
| Line is longer than 80 characters. |
101
|
| '4' is a magic number. |
101
|
| '4' is a magic number. |
112
|
| Missing a Javadoc comment. |
136
|
| Parameter i should be final. |
136
|
| Parameter j should be final. |
136
|
| Avoid inline conditionals. |
137
|
| '6' is a magic number. |
137
|
| switch without "default" clause. |
138
|
| '3' is a magic number. |
146
|
| '4' is a magic number. |
148
|
| '5' is a magic number. |
150
|
| '5' is a magic number. |
152
|
| Parameter mouseEvent should be final. |
159
|
| Expected @param tag for 'mouseEvent'. |
159
|
| Parameter mouseEvent should be final. |
173
|
| Expected @param tag for 'mouseEvent'. |
173
|
| Parameter mouseEvent should be final. |
179
|
| Expected @param tag for 'mouseEvent'. |
179
|
| Method 'mouseExited' is not designed for extension - needs to be abstract, final or empty. |
185
|
| Parameter mouseEvent should be final. |
185
|
| Expected @param tag for 'mouseEvent'. |
185
|
| Method 'mouseMoved' is not designed for extension - needs to be abstract, final or empty. |
195
|
| Parameter mouseEvent should be final. |
195
|
| Expected @param tag for 'mouseEvent'. |
195
|
| Method 'mousePressed' is not designed for extension - needs to be abstract, final or empty. |
225
|
| Parameter mouseEvent should be final. |
225
|
| Expected @param tag for 'mouseEvent'. |
225
|
| Line is longer than 80 characters. |
245
|
| Parameter mouseEvent should be final. |
259
|
| Expected @param tag for 'mouseEvent'. |
259
|
net/sourceforge/simplegamenet/chess/ChessPlayFieldState.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| interfaces should describe a type and hence have methods. |
3
|
| Missing a Javadoc comment. |
5
|
| Redundant 'public' modifier. |
5
|
| Missing a Javadoc comment. |
6
|
| Redundant 'public' modifier. |
6
|
| Missing a Javadoc comment. |
7
|
| Redundant 'public' modifier. |
7
|
| Missing a Javadoc comment. |
8
|
| Redundant 'public' modifier. |
8
|
| Missing a Javadoc comment. |
9
|
| Redundant 'public' modifier. |
9
|
| Missing a Javadoc comment. |
10
|
| Redundant 'public' modifier. |
10
|
net/sourceforge/simplegamenet/chess/ChessPlayerClient.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
10
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
19
|
| Parameter clientEngine should be final. |
19
|
| Method 'createGamePanel' is not designed for extension - needs to be abstract, final or empty. |
23
|
| Missing a Javadoc comment. |
23
|
| Parameter utilityPanelFactory should be final. |
23
|
| Line is longer than 80 characters. |
24
|
| Method 'playerRemoved' is not designed for extension - needs to be abstract, final or empty. |
28
|
| Missing a Javadoc comment. |
28
|
| Parameter playerSettings should be final. |
28
|
| Line is longer than 80 characters. |
30
|
| Line is longer than 80 characters. |
31
|
| Line is longer than 80 characters. |
33
|
| Line is longer than 80 characters. |
37
|
| Method 'receiveData' is not designed for extension - needs to be abstract, final or empty. |
44
|
| Missing a Javadoc comment. |
44
|
| Parameter data should be final. |
44
|
| Line is longer than 80 characters. |
58
|
| Line is longer than 80 characters. |
76
|
| switch without "default" clause. |
84
|
| Line is longer than 80 characters. |
90
|
| Line is longer than 80 characters. |
91
|
| Line is longer than 80 characters. |
94
|
| Line is longer than 80 characters. |
110
|
| Line is longer than 80 characters. |
114
|
| Line is longer than 80 characters. |
129
|
| Line is longer than 80 characters. |
131
|
| Line is longer than 80 characters. |
133
|
| Line is longer than 80 characters. |
165
|
| Method 'gameAborting' is not designed for extension - needs to be abstract, final or empty. |
174
|
| Missing a Javadoc comment. |
174
|
| Missing a Javadoc comment. |
180
|
| Parameter adjustRemiseOfferable should be final. |
180
|
| Line is longer than 80 characters. |
181
|
| Line is longer than 80 characters. |
188
|
| Line is longer than 80 characters. |
194
|
| Method 'makeMove' is not designed for extension - needs to be abstract, final or empty. |
194
|
| Missing a Javadoc comment. |
194
|
| Parameter sourceX should be final. |
194
|
| Parameter sourceY should be final. |
194
|
| Parameter destinationX should be final. |
194
|
| Parameter destinationY should be final. |
194
|
| Line is longer than 80 characters. |
195
|
| Line is longer than 80 characters. |
198
|
| Method 'makeMove' is not designed for extension - needs to be abstract, final or empty. |
198
|
| Missing a Javadoc comment. |
198
|
| Parameter sourceX should be final. |
198
|
| Parameter sourceY should be final. |
198
|
| Parameter destinationX should be final. |
198
|
| Parameter destinationY should be final. |
198
|
| Parameter chosenPieceType should be final. |
199
|
| Line is longer than 80 characters. |
201
|
| Method 'isOfferRemiseAllowed' is not designed for extension - needs to be abstract, final or empty. |
204
|
| Missing a Javadoc comment. |
204
|
| Method 'offerRemise' is not designed for extension - needs to be abstract, final or empty. |
208
|
| Missing a Javadoc comment. |
208
|
| Method 'yieldGame' is not designed for extension - needs to be abstract, final or empty. |
213
|
| Missing a Javadoc comment. |
213
|
| Method 'getMoveSourceAllowedGrid' is not designed for extension - needs to be abstract, final or empty. |
217
|
| Missing a Javadoc comment. |
217
|
| Method 'getMoveDestinationAllowedGrid' is not designed for extension - needs to be abstract, final or empty. |
225
|
| Missing a Javadoc comment. |
225
|
| Parameter sourceX should be final. |
225
|
| Parameter sourceY should be final. |
225
|
| Line is longer than 80 characters. |
229
|
| Method 'isReplaceChoiceNeeded' is not designed for extension - needs to be abstract, final or empty. |
233
|
| Missing a Javadoc comment. |
233
|
| Parameter sourceX should be final. |
233
|
| Parameter sourceY should be final. |
233
|
| Parameter destinationX should be final. |
234
|
| Parameter destinationY should be final. |
234
|
net/sourceforge/simplegamenet/chess/ChessQueen.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| Missing a Javadoc comment. |
5
|
| Parameter participantOwnerIndex should be final. |
5
|
| Parameter x should be final. |
5
|
| Parameter y should be final. |
5
|
| Method 'isMoveAllowed' is not designed for extension - needs to be abstract, final or empty. |
9
|
| Missing a Javadoc comment. |
9
|
| Parameter pieceGrid should be final. |
9
|
| Parameter destinationX should be final. |
10
|
| Parameter destinationY should be final. |
10
|
| Avoid inline conditionals. |
19
|
| Line is longer than 80 characters. |
26
|
| Avoid inline conditionals. |
26
|
| Line is longer than 80 characters. |
32
|
| Line is longer than 80 characters. |
34
|
| Avoid inline conditionals. |
34
|
| Avoid inline conditionals. |
35
|
| Method 'getPieceType' is not designed for extension - needs to be abstract, final or empty. |
46
|
| Missing a Javadoc comment. |
46
|
| Method 'getPieceValue' is not designed for extension - needs to be abstract, final or empty. |
50
|
| Missing a Javadoc comment. |
50
|
| '7' is a magic number. |
51
|
net/sourceforge/simplegamenet/chess/ChessRook.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
7
|
| Parameter participantOwnerIndex should be final. |
7
|
| Parameter x should be final. |
7
|
| Parameter y should be final. |
7
|
| Method 'isMoveAllowed' is not designed for extension - needs to be abstract, final or empty. |
11
|
| Missing a Javadoc comment. |
11
|
| Parameter pieceGrid should be final. |
11
|
| Parameter destinationX should be final. |
12
|
| Parameter destinationY should be final. |
12
|
| Avoid inline conditionals. |
23
|
| Line is longer than 80 characters. |
29
|
| Avoid inline conditionals. |
29
|
| Line is longer than 80 characters. |
39
|
| Method 'doMove' is not designed for extension - needs to be abstract, final or empty. |
39
|
| Missing a Javadoc comment. |
39
|
| Parameter pieceGrid should be final. |
39
|
| Parameter destinationX should be final. |
39
|
| Parameter destinationY should be final. |
39
|
| Method 'clone' is not designed for extension - needs to be abstract, final or empty. |
44
|
| Missing a Javadoc comment. |
44
|
| Method 'isUnmoved' is not designed for extension - needs to be abstract, final or empty. |
49
|
| Missing a Javadoc comment. |
49
|
| Method 'getPieceType' is not designed for extension - needs to be abstract, final or empty. |
53
|
| Missing a Javadoc comment. |
53
|
| Method 'getPieceValue' is not designed for extension - needs to be abstract, final or empty. |
57
|
| Missing a Javadoc comment. |
57
|
| '4' is a magic number. |
58
|
net/sourceforge/simplegamenet/chess/ChessServer.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
15
|
| Parameter serverEngine should be final. |
15
|
| Method 'playerAdded' is not designed for extension - needs to be abstract, final or empty. |
19
|
| Missing a Javadoc comment. |
19
|
| Parameter playerSettings should be final. |
19
|
| Method 'playerRemoved' is not designed for extension - needs to be abstract, final or empty. |
26
|
| Missing a Javadoc comment. |
26
|
| Parameter playerSettings should be final. |
26
|
| Line is longer than 80 characters. |
28
|
| Line is longer than 80 characters. |
30
|
| Line is longer than 80 characters. |
31
|
| Method 'gameStarted' is not designed for extension - needs to be abstract, final or empty. |
39
|
| Missing a Javadoc comment. |
39
|
| Line is longer than 80 characters. |
45
|
| Line is longer than 80 characters. |
47
|
| Line is longer than 80 characters. |
54
|
| Method 'receiveData' is not designed for extension - needs to be abstract, final or empty. |
57
|
| Missing a Javadoc comment. |
57
|
| Parameter playerID should be final. |
57
|
| Parameter data should be final. |
57
|
| Line is longer than 80 characters. |
71
|
| Line is longer than 80 characters. |
72
|
| Line is longer than 80 characters. |
75
|
| Line is longer than 80 characters. |
78
|
| switch without "default" clause. |
79
|
| Line is longer than 80 characters. |
85
|
| Line is longer than 80 characters. |
92
|
| Line is longer than 80 characters. |
96
|
| Line is longer than 80 characters. |
101
|
| Line is longer than 80 characters. |
106
|
| Line is longer than 80 characters. |
107
|
| Line is longer than 80 characters. |
109
|
| Line is longer than 80 characters. |
110
|
| Line is longer than 80 characters. |
119
|
| Line is longer than 80 characters. |
121
|
| Line is longer than 80 characters. |
126
|
| Line is longer than 80 characters. |
130
|
| Line is longer than 80 characters. |
132
|
| Line is longer than 80 characters. |
134
|
| Line is longer than 80 characters. |
140
|
| Line is longer than 80 characters. |
142
|
| Line is longer than 80 characters. |
144
|
| Method 'gameAborting' is not designed for extension - needs to be abstract, final or empty. |
153
|
| Missing a Javadoc comment. |
153
|
| Line is longer than 80 characters. |
155
|
net/sourceforge/simplegamenet/chess/package.html
Error | Line |
| Missing package documentation file. | 0 |