Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
Files | Infos | Warnings | Errors |
33 | 0 | 0 | 694 |
Files
net/sourceforge/simplegamenet/connectaline/CALFactory.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
13
|
| Line is longer than 80 characters. |
14
|
| Line is longer than 80 characters. |
15
|
| Line is longer than 80 characters. |
17
|
| Line is longer than 80 characters. |
18
|
| Line is longer than 80 characters. |
19
|
| Method 'createGameServer' is not designed for extension - needs to be abstract, final or empty. |
24
|
| Missing a Javadoc comment. |
24
|
| Parameter serverEngine should be final. |
24
|
| Method 'createGamePlayerClient' is not designed for extension - needs to be abstract, final or empty. |
28
|
| Missing a Javadoc comment. |
28
|
| Parameter clientEngine should be final. |
28
|
| Method 'createDefaultGameSettings' is not designed for extension - needs to be abstract, final or empty. |
32
|
| Missing a Javadoc comment. |
32
|
net/sourceforge/simplegamenet/connectaline/CALPacket.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
7
|
| Variable 'cALPacketCode' must be private and have accessor methods. |
7
|
| Missing a Javadoc comment. |
8
|
| Variable 'cALData' must be private and have accessor methods. |
8
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
15
|
| Parameter cALPacketCode should be final. |
15
|
| 'cALPacketCode' hides a field. |
15
|
| Missing a Javadoc comment. |
22
|
| Parameter cALPacketCode should be final. |
22
|
| 'cALPacketCode' hides a field. |
22
|
| Parameter cALData should be final. |
22
|
| 'cALData' hides a field. |
22
|
| Method 'getCalPacketCode' is not designed for extension - needs to be abstract, final or empty. |
27
|
| Missing a Javadoc comment. |
27
|
| Method 'getCalData' is not designed for extension - needs to be abstract, final or empty. |
31
|
| Missing a Javadoc comment. |
31
|
net/sourceforge/simplegamenet/connectaline/CALPacketCodes.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| interfaces should describe a type and hence have methods. |
3
|
| Missing a Javadoc comment. |
5
|
| Redundant 'static' modifier. |
5
|
| Missing a Javadoc comment. |
6
|
| Redundant 'static' modifier. |
6
|
| Missing a Javadoc comment. |
7
|
| Redundant 'static' modifier. |
7
|
| Missing a Javadoc comment. |
8
|
| Redundant 'static' modifier. |
8
|
| Missing a Javadoc comment. |
9
|
| Redundant 'static' modifier. |
9
|
| Missing a Javadoc comment. |
10
|
| Redundant 'static' modifier. |
10
|
| Missing a Javadoc comment. |
11
|
| Redundant 'static' modifier. |
11
|
| Missing a Javadoc comment. |
12
|
| Redundant 'static' modifier. |
12
|
net/sourceforge/simplegamenet/connectaline/CALPanel.java
Error | Line |
| File does not end with a newline. |
0
|
net/sourceforge/simplegamenet/connectaline/CALPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
3
|
| Line is longer than 80 characters. |
6
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
19
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
26
|
| Parameter cALPlayerClient should be final. |
26
|
| 'cALPlayerClient' hides a field. |
26
|
| Parameter gameSettings should be final. |
26
|
| Parameter chatClientPanel should be final. |
27
|
| '10' is a magic number. |
34
|
| Line is longer than 80 characters. |
35
|
| '10' is a magic number. |
37
|
| '10' is a magic number. |
39
|
| Line is longer than 80 characters. |
40
|
| '10' is a magic number. |
41
|
| Line is longer than 80 characters. |
42
|
| Line is longer than 80 characters. |
48
|
| '10' is a magic number. |
48
|
| Line is longer than 80 characters. |
50
|
| '10' is a magic number. |
50
|
| Line is longer than 80 characters. |
52
|
| '10' is a magic number. |
52
|
| Line is longer than 80 characters. |
56
|
| Line is longer than 80 characters. |
57
|
| Line is longer than 80 characters. |
58
|
| '4' is a magic number. |
58
|
| '6' is a magic number. |
60
|
| '3' is a magic number. |
62
|
| '4' is a magic number. |
62
|
| '6' is a magic number. |
63
|
| '3' is a magic number. |
64
|
| '4' is a magic number. |
65
|
| '3' is a magic number. |
65
|
| '4' is a magic number. |
65
|
| Method 'getCALPlayerPanel' is not designed for extension - needs to be abstract, final or empty. |
69
|
| Missing a Javadoc comment. |
69
|
| Method 'cALSettingsUpdated' is not designed for extension - needs to be abstract, final or empty. |
73
|
| Missing a Javadoc comment. |
73
|
| Parameter cALSettings should be final. |
73
|
| Method 'updateMoveCALPlayFieldPanel' is not designed for extension - needs to be abstract, final or empty. |
77
|
| Missing a Javadoc comment. |
77
|
| Method 'getCALPlayFieldCellWidth' is not designed for extension - needs to be abstract, final or empty. |
81
|
| Missing a Javadoc comment. |
81
|
| Method 'getCALPlayFieldCellHeight' is not designed for extension - needs to be abstract, final or empty. |
85
|
| Missing a Javadoc comment. |
85
|
| Method 'setMessageCALMessagePanel' is not designed for extension - needs to be abstract, final or empty. |
89
|
| Missing a Javadoc comment. |
89
|
| Parameter cALMessage should be final. |
89
|
| Method 'setCALPlayerPanel' is not designed for extension - needs to be abstract, final or empty. |
93
|
| Missing a Javadoc comment. |
93
|
| Method 'nextCALPlayerPanel' is not designed for extension - needs to be abstract, final or empty. |
97
|
| Missing a Javadoc comment. |
97
|
| Method 'removePlayerLabelsPlayerPanel' is not designed for extension - needs to be abstract, final or empty. |
101
|
| Missing a Javadoc comment. |
101
|
| Method 'handleTurn' is not designed for extension - needs to be abstract, final or empty. |
105
|
| Missing a Javadoc comment. |
105
|
| Method 'setEnabled' is not designed for extension - needs to be abstract, final or empty. |
110
|
| Missing a Javadoc comment. |
110
|
| Parameter enabled should be final. |
110
|
| Method 'setOtherParticipantAtTurn' is not designed for extension - needs to be abstract, final or empty. |
115
|
| Missing a Javadoc comment. |
115
|
| Parameter nickname should be final. |
115
|
| Method 'setCALSettings' is not designed for extension - needs to be abstract, final or empty. |
119
|
| Missing a Javadoc comment. |
119
|
| Parameter cALPlayStyle should be final. |
119
|
| Parameter cALLengthOfALine should be final. |
119
|
| switch without "default" clause. |
120
|
net/sourceforge/simplegamenet/connectaline/CALPlayField.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
6
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
13
|
| Line is longer than 80 characters. |
15
|
| Missing a Javadoc comment. |
15
|
| Parameter cALNumberOfColumns should be final. |
15
|
| 'cALNumberOfColumns' hides a field. |
15
|
| Parameter cALNumberOfRows should be final. |
15
|
| 'cALNumberOfRows' hides a field. |
15
|
| Parameter cALLengthOfLine should be final. |
15
|
| 'cALLengthOfLine' hides a field. |
15
|
| Parameter participantsOrder should be final. |
16
|
| 'participantsOrder' hides a field. |
16
|
| Method 'isMoveAllowedGravity' is not designed for extension - needs to be abstract, final or empty. |
29
|
| Missing a Javadoc comment. |
29
|
| Parameter x should be final. |
29
|
| Parameter y should be final. |
29
|
| Expression can be simplified. |
30
|
| Line is longer than 80 characters. |
32
|
| Conditional logic can be removed. |
32
|
| Expression can be simplified. |
32
|
| Expression can be simplified. |
33
|
| Method 'isMoveAllowedAnyEmptySpot' is not designed for extension - needs to be abstract, final or empty. |
40
|
| Missing a Javadoc comment. |
40
|
| Parameter x should be final. |
40
|
| Parameter y should be final. |
40
|
| Method 'isWinner' is not designed for extension - needs to be abstract, final or empty. |
44
|
| Missing a Javadoc comment. |
44
|
| Parameter x should be final. |
44
|
| Parameter y should be final. |
44
|
| Line is longer than 80 characters. |
53
|
| Line is longer than 80 characters. |
63
|
| Line is longer than 80 characters. |
73
|
| Line is longer than 80 characters. |
83
|
| Line is longer than 80 characters. |
94
|
| Line is longer than 80 characters. |
103
|
| Line is longer than 80 characters. |
104
|
| Line is longer than 80 characters. |
115
|
| Line is longer than 80 characters. |
125
|
| Conditional logic can be removed. |
131
|
| Method 'isRemise' is not designed for extension - needs to be abstract, final or empty. |
139
|
| Missing a Javadoc comment. |
139
|
| Expression can be simplified. |
144
|
| Method 'makeMove' is not designed for extension - needs to be abstract, final or empty. |
159
|
| Missing a Javadoc comment. |
159
|
| Parameter x should be final. |
159
|
| Parameter y should be final. |
159
|
| Parameter playerID should be final. |
159
|
| Method 'getSquarePlayerID' is not designed for extension - needs to be abstract, final or empty. |
165
|
| Missing a Javadoc comment. |
165
|
| Parameter i should be final. |
165
|
| Parameter j should be final. |
165
|
| Method 'isOccupied' is not designed for extension - needs to be abstract, final or empty. |
169
|
| Missing a Javadoc comment. |
169
|
| Parameter i should be final. |
169
|
| Parameter j should be final. |
169
|
| Method 'getParticipantAtTurnPlayerID' is not designed for extension - needs to be abstract, final or empty. |
173
|
| Missing a Javadoc comment. |
173
|
| Method 'getParticipantsOrder' is not designed for extension - needs to be abstract, final or empty. |
177
|
| Missing a Javadoc comment. |
177
|
net/sourceforge/simplegamenet/connectaline/CALPlayFieldPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
3
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
6
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
19
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
21
|
| Line is longer than 80 characters. |
23
|
| Missing a Javadoc comment. |
23
|
| Parameter cALPlayerClient should be final. |
23
|
| 'cALPlayerClient' hides a field. |
23
|
| Parameter cALSettings should be final. |
23
|
| Line is longer than 80 characters. |
30
|
| Method 'paintComponent' is not designed for extension - needs to be abstract, final or empty. |
34
|
| Missing a Javadoc comment. |
34
|
| Parameter g should be final. |
34
|
| Line is longer than 80 characters. |
45
|
| '100' is a magic number. |
47
|
| '100' is a magic number. |
47
|
| Line is longer than 80 characters. |
50
|
| '100' is a magic number. |
52
|
| '100' is a magic number. |
52
|
| '200' is a magic number. |
52
|
| Line is longer than 80 characters. |
55
|
| '200' is a magic number. |
57
|
| '100' is a magic number. |
57
|
| '300' is a magic number. |
57
|
| Line is longer than 80 characters. |
60
|
| '100' is a magic number. |
62
|
| '200' is a magic number. |
62
|
| '100' is a magic number. |
62
|
| Line is longer than 80 characters. |
71
|
| Line is longer than 80 characters. |
73
|
| '100' is a magic number. |
73
|
| '100' is a magic number. |
74
|
| '100' is a magic number. |
74
|
| Line is longer than 80 characters. |
81
|
| '100' is a magic number. |
83
|
| '100' is a magic number. |
83
|
| Line is longer than 80 characters. |
87
|
| '100' is a magic number. |
89
|
| '200' is a magic number. |
89
|
| '200' is a magic number. |
89
|
| '300' is a magic number. |
89
|
| Line is longer than 80 characters. |
92
|
| '200' is a magic number. |
94
|
| '300' is a magic number. |
94
|
| '100' is a magic number. |
94
|
| Line is longer than 80 characters. |
95
|
| Line is longer than 80 characters. |
97
|
| '200' is a magic number. |
99
|
| '100' is a magic number. |
99
|
| '300' is a magic number. |
99
|
| '200' is a magic number. |
99
|
| Line is longer than 80 characters. |
100
|
| Line is longer than 80 characters. |
102
|
| '200' is a magic number. |
104
|
| '200' is a magic number. |
104
|
| '300' is a magic number. |
104
|
| '300' is a magic number. |
104
|
| Method 'getCellWidth' is not designed for extension - needs to be abstract, final or empty. |
110
|
| Missing a Javadoc comment. |
110
|
| Method 'getCellHeight' is not designed for extension - needs to be abstract, final or empty. |
114
|
| Missing a Javadoc comment. |
114
|
| Method 'cALSettingsUpdated' is not designed for extension - needs to be abstract, final or empty. |
118
|
| Missing a Javadoc comment. |
118
|
| Parameter cALSettings should be final. |
118
|
| Method 'setEnabled' is not designed for extension - needs to be abstract, final or empty. |
125
|
| Missing a Javadoc comment. |
125
|
| Parameter enabled should be final. |
125
|
| Method 'updateMove' is not designed for extension - needs to be abstract, final or empty. |
129
|
| Missing a Javadoc comment. |
129
|
| Line is longer than 80 characters. |
134
|
| Parameter e should be final. |
137
|
| Expected @param tag for 'e'. |
137
|
| Parameter e should be final. |
144
|
| Expected @param tag for 'e'. |
144
|
| Parameter e should be final. |
150
|
| Expected @param tag for 'e'. |
150
|
| Method 'mousePressed' is not designed for extension - needs to be abstract, final or empty. |
156
|
| Parameter e should be final. |
156
|
| Expected @param tag for 'e'. |
156
|
| Line is longer than 80 characters. |
158
|
| Line is longer than 80 characters. |
159
|
| 'coordinates' hides a field. |
160
|
| switch without "default" clause. |
172
|
| Line is longer than 80 characters. |
174
|
| Line is longer than 80 characters. |
176
|
| Line is longer than 80 characters. |
183
|
| Line is longer than 80 characters. |
186
|
| Parameter e should be final. |
200
|
| Expected @param tag for 'e'. |
200
|
| Line is longer than 80 characters. |
205
|
| Line is longer than 80 characters. |
206
|
| Line is longer than 80 characters. |
209
|
| Parameter e should be final. |
212
|
| Expected @param tag for 'e'. |
212
|
net/sourceforge/simplegamenet/connectaline/CALPlayStyle.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| interfaces should describe a type and hence have methods. |
3
|
| Missing a Javadoc comment. |
5
|
| Redundant 'public' modifier. |
5
|
| Missing a Javadoc comment. |
6
|
| Redundant 'public' modifier. |
6
|
net/sourceforge/simplegamenet/connectaline/CALPlayStyleInterface.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| interfaces should describe a type and hence have methods. |
3
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
6
|
net/sourceforge/simplegamenet/connectaline/CALPlayerClient.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
3
|
| Line is longer than 80 characters. |
13
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
19
|
| Missing a Javadoc comment. |
21
|
| Parameter clientEngine should be final. |
21
|
| Method 'createGamePanel' is not designed for extension - needs to be abstract, final or empty. |
25
|
| Missing a Javadoc comment. |
25
|
| Parameter utilityPanelFactory should be final. |
25
|
| Method 'playerRemoved' is not designed for extension - needs to be abstract, final or empty. |
36
|
| Missing a Javadoc comment. |
36
|
| Parameter playerSettings should be final. |
36
|
| Line is longer than 80 characters. |
38
|
| Method 'receiveData' is not designed for extension - needs to be abstract, final or empty. |
43
|
| Missing a Javadoc comment. |
43
|
| Parameter data should be final. |
43
|
| Line is longer than 80 characters. |
56
|
| Line is longer than 80 characters. |
61
|
| Line is longer than 80 characters. |
84
|
| '+' should be on a new line. |
86
|
| Line is longer than 80 characters. |
109
|
| Method 'getCALSettings' is not designed for extension - needs to be abstract, final or empty. |
123
|
| Missing a Javadoc comment. |
123
|
| Method 'gameSettingsUpdated' is not designed for extension - needs to be abstract, final or empty. |
127
|
| Missing a Javadoc comment. |
127
|
| Parameter outdatedGameSettings should be final. |
127
|
| Parameter updatedGameSettings should be final. |
128
|
| Missing a Javadoc comment. |
138
|
| Line is longer than 80 characters. |
143
|
| Method 'getParticipantAtTurnPlayerID' is not designed for extension - needs to be abstract, final or empty. |
149
|
| Missing a Javadoc comment. |
149
|
| Method 'getCALPlayerAmount' is not designed for extension - needs to be abstract, final or empty. |
154
|
| Missing a Javadoc comment. |
154
|
| Method 'getCALPlayerNickname' is not designed for extension - needs to be abstract, final or empty. |
158
|
| Missing a Javadoc comment. |
158
|
| Parameter CALPlayerID should be final. |
158
|
| Name 'CALPlayerID' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
158
|
| Method 'getCALPlayerID' is not designed for extension - needs to be abstract, final or empty. |
163
|
| Missing a Javadoc comment. |
163
|
| Method 'sendCALPacket' is not designed for extension - needs to be abstract, final or empty. |
167
|
| Missing a Javadoc comment. |
167
|
| Parameter cALPacket should be final. |
167
|
| Method 'getParticipantsOrder' is not designed for extension - needs to be abstract, final or empty. |
171
|
| Missing a Javadoc comment. |
171
|
| Method 'getCALPlayField' is not designed for extension - needs to be abstract, final or empty. |
175
|
| Missing a Javadoc comment. |
175
|
| Method 'isGameStarted' is not designed for extension - needs to be abstract, final or empty. |
179
|
| Missing a Javadoc comment. |
179
|
| Method 'getColorIndexArray' is not designed for extension - needs to be abstract, final or empty. |
183
|
| Missing a Javadoc comment. |
183
|
| Method 'getColors' is not designed for extension - needs to be abstract, final or empty. |
187
|
| Missing a Javadoc comment. |
187
|
| Method 'gameAborting' is not designed for extension - needs to be abstract, final or empty. |
191
|
| Missing a Javadoc comment. |
191
|
net/sourceforge/simplegamenet/connectaline/CALPlayerPanel.java
Error | Line |
| File does not end with a newline. |
0
|
net/sourceforge/simplegamenet/connectaline/CALPlayerPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
3
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
4
|
| Line is longer than 80 characters. |
6
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
12
|
| '6' is a magic number. |
12
|
| Missing a Javadoc comment. |
13
|
| '6' is a magic number. |
13
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
19
|
| Parameter cALPlayerClient should be final. |
19
|
| 'cALPlayerClient' hides a field. |
19
|
| '10' is a magic number. |
22
|
| Line is longer than 80 characters. |
23
|
| '10' is a magic number. |
24
|
| Line is longer than 80 characters. |
25
|
| '10' is a magic number. |
26
|
| '10' is a magic number. |
27
|
| Line is longer than 80 characters. |
28
|
| Line is longer than 80 characters. |
30
|
| '10' is a magic number. |
30
|
| Line is longer than 80 characters. |
31
|
| '3' is a magic number. |
35
|
| '3' is a magic number. |
35
|
| '3' is a magic number. |
40
|
| '3' is a magic number. |
41
|
| '3' is a magic number. |
41
|
| Method 'setCALPlayer' is not designed for extension - needs to be abstract, final or empty. |
45
|
| Missing a Javadoc comment. |
45
|
| Method 'nextCALPlayer' is not designed for extension - needs to be abstract, final or empty. |
58
|
| Missing a Javadoc comment. |
58
|
| Line is longer than 80 characters. |
77
|
| Method 'removePlayerLabels' is not designed for extension - needs to be abstract, final or empty. |
88
|
| Missing a Javadoc comment. |
88
|
net/sourceforge/simplegamenet/connectaline/CALPlayerSettings.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
6
|
| Missing a Javadoc comment. |
8
|
| Parameter score should be final. |
8
|
| 'score' hides a field. |
8
|
| Parameter color should be final. |
8
|
| 'color' hides a field. |
8
|
| Method 'getCALPlayerScore' is not designed for extension - needs to be abstract, final or empty. |
13
|
| Missing a Javadoc comment. |
13
|
| Method 'getCALPlayerColor' is not designed for extension - needs to be abstract, final or empty. |
17
|
| Missing a Javadoc comment. |
17
|
net/sourceforge/simplegamenet/connectaline/CALServer.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
14
|
| Parameter serverEngine should be final. |
14
|
| Method 'playerAdded' is not designed for extension - needs to be abstract, final or empty. |
18
|
| Missing a Javadoc comment. |
18
|
| Parameter playerSettings should be final. |
18
|
| Method 'playerRemoved' is not designed for extension - needs to be abstract, final or empty. |
25
|
| Missing a Javadoc comment. |
25
|
| Parameter playerSettings should be final. |
25
|
| Line is longer than 80 characters. |
27
|
| Method 'gameStarted' is not designed for extension - needs to be abstract, final or empty. |
33
|
| Missing a Javadoc comment. |
33
|
| Method 'receiveData' is not designed for extension - needs to be abstract, final or empty. |
61
|
| Missing a Javadoc comment. |
61
|
| Parameter playerID should be final. |
61
|
| Parameter data should be final. |
61
|
| switch without "default" clause. |
67
|
| Line is longer than 80 characters. |
71
|
| Line is longer than 80 characters. |
75
|
| Line is longer than 80 characters. |
76
|
| Line is longer than 80 characters. |
77
|
| Line is longer than 80 characters. |
81
|
| Line is longer than 80 characters. |
91
|
| Line is longer than 80 characters. |
93
|
| Line is longer than 80 characters. |
97
|
| Line is longer than 80 characters. |
98
|
| Line is longer than 80 characters. |
99
|
| Line is longer than 80 characters. |
103
|
| Method 'sendCALPacket' is not designed for extension - needs to be abstract, final or empty. |
121
|
| Missing a Javadoc comment. |
121
|
| Parameter cALPacket should be final. |
121
|
| Method 'gameAborted' is not designed for extension - needs to be abstract, final or empty. |
125
|
| Missing a Javadoc comment. |
125
|
net/sourceforge/simplegamenet/connectaline/CALSettingOptions.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| interfaces should describe a type and hence have methods. |
3
|
| Missing a Javadoc comment. |
5
|
| Redundant 'public' modifier. |
5
|
| Missing a Javadoc comment. |
6
|
| Redundant 'public' modifier. |
6
|
net/sourceforge/simplegamenet/connectaline/CALSettings.java
Error | Line |
| File does not end with a newline. |
0
|
net/sourceforge/simplegamenet/connectaline/CALSettings.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
3
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
12
|
| '0xFE' is a magic number. |
13
|
| '0x40' is a magic number. |
13
|
| '0x42' is a magic number. |
13
|
| '0xFF' is a magic number. |
14
|
| '0xFE' is a magic number. |
14
|
| '0x49' is a magic number. |
14
|
| '0x40' is a magic number. |
15
|
| '0xFF' is a magic number. |
15
|
| '0xFF' is a magic number. |
16
|
| '0xFF' is a magic number. |
16
|
| '0x41' is a magic number. |
17
|
| '0xFF' is a magic number. |
17
|
| '0xFF' is a magic number. |
17
|
| '0x40' is a magic number. |
18
|
| '0x40' is a magic number. |
18
|
| '0x40' is a magic number. |
18
|
| '0xFF' is a magic number. |
19
|
| '0xB1' is a magic number. |
19
|
| '0x66' is a magic number. |
19
|
| '0xB2' is a magic number. |
20
|
| '0xB2' is a magic number. |
20
|
| '0xB2' is a magic number. |
20
|
| Missing a Javadoc comment. |
24
|
| Missing a Javadoc comment. |
25
|
| '8' is a magic number. |
25
|
| Missing a Javadoc comment. |
26
|
| '4' is a magic number. |
26
|
| Missing a Javadoc comment. |
27
|
| '7' is a magic number. |
27
|
| Missing a Javadoc comment. |
28
|
| '6' is a magic number. |
28
|
| Missing a Javadoc comment. |
29
|
| Missing a Javadoc comment. |
31
|
| Line is longer than 80 characters. |
34
|
| Missing a Javadoc comment. |
34
|
| Parameter maxNumberOfPlayer should be final. |
34
|
| 'maxNumberOfPlayer' hides a field. |
34
|
| Parameter maxNumberOfcon should be final. |
34
|
| 'maxNumberOfcon' hides a field. |
34
|
| Parameter lengthOfALine should be final. |
34
|
| 'lengthOfALine' hides a field. |
34
|
| Parameter numberOfColumns should be final. |
35
|
| 'numberOfColumns' hides a field. |
35
|
| Parameter numberOfRows should be final. |
35
|
| 'numberOfRows' hides a field. |
35
|
| Parameter playStyle should be final. |
35
|
| 'playStyle' hides a field. |
35
|
| Method 'createGameSettingsPanel' is not designed for extension - needs to be abstract, final or empty. |
44
|
| Missing a Javadoc comment. |
44
|
| Line is longer than 80 characters. |
45
|
| Line is longer than 80 characters. |
49
|
| Method 'createChangedGameSettings' is not designed for extension - needs to be abstract, final or empty. |
49
|
| Missing a Javadoc comment. |
49
|
| Parameter gameSettingsPanel should be final. |
49
|
| Line is longer than 80 characters. |
50
|
| Line is longer than 80 characters. |
52
|
| Line is longer than 80 characters. |
53
|
| Method 'isCreateDefaultPlayerSettingsAllowed' is not designed for extension - needs to be abstract, final or empty. |
57
|
| Missing a Javadoc comment. |
57
|
| Parameter playerType should be final. |
57
|
| Line is longer than 80 characters. |
58
|
| Line is longer than 80 characters. |
64
|
| Method 'createDefaultPlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
64
|
| Missing a Javadoc comment. |
64
|
| Parameter playerID should be final. |
64
|
| Parameter playerType should be final. |
64
|
| Parameter nickname should be final. |
65
|
| Avoid inline conditionals. |
66
|
| Line is longer than 80 characters. |
68
|
| Line is longer than 80 characters. |
75
|
| Method 'isChangePlayerSettingsAllowed' is not designed for extension - needs to be abstract, final or empty. |
75
|
| Missing a Javadoc comment. |
75
|
| Parameter currentPlayerSettings should be final. |
75
|
| Line is longer than 80 characters. |
76
|
| Parameter changedPlayerSettings should be final. |
76
|
| Conditional logic can be removed. |
77
|
| Line is longer than 80 characters. |
78
|
| Method 'isStartGameAllowed' is not designed for extension - needs to be abstract, final or empty. |
87
|
| Missing a Javadoc comment. |
87
|
| Conditional logic can be removed. |
88
|
| Method 'getMaxNumberOfPlayer' is not designed for extension - needs to be abstract, final or empty. |
95
|
| Missing a Javadoc comment. |
95
|
| Method 'setMaxNumberOfPlayer' is not designed for extension - needs to be abstract, final or empty. |
99
|
| Missing a Javadoc comment. |
99
|
| Parameter maxNumberOfPlayer should be final. |
99
|
| 'maxNumberOfPlayer' hides a field. |
99
|
| Method 'getMaxNumberOfcon' is not designed for extension - needs to be abstract, final or empty. |
103
|
| Missing a Javadoc comment. |
103
|
| Method 'setMaxNumberOfcon' is not designed for extension - needs to be abstract, final or empty. |
107
|
| Missing a Javadoc comment. |
107
|
| Parameter maxNumberOfcon should be final. |
107
|
| 'maxNumberOfcon' hides a field. |
107
|
| Method 'getLengthOfALine' is not designed for extension - needs to be abstract, final or empty. |
111
|
| Missing a Javadoc comment. |
111
|
| Method 'setLengthOfALine' is not designed for extension - needs to be abstract, final or empty. |
115
|
| Missing a Javadoc comment. |
115
|
| Parameter lengthOfALine should be final. |
115
|
| 'lengthOfALine' hides a field. |
115
|
| Method 'getNumberOfColumns' is not designed for extension - needs to be abstract, final or empty. |
119
|
| Missing a Javadoc comment. |
119
|
| Method 'setNumberOfColumns' is not designed for extension - needs to be abstract, final or empty. |
123
|
| Missing a Javadoc comment. |
123
|
| Parameter numberOfColumns should be final. |
123
|
| 'numberOfColumns' hides a field. |
123
|
| Method 'getNumberOfRows' is not designed for extension - needs to be abstract, final or empty. |
127
|
| Missing a Javadoc comment. |
127
|
| Method 'setNumberOfRows' is not designed for extension - needs to be abstract, final or empty. |
131
|
| Missing a Javadoc comment. |
131
|
| Parameter numberOfRows should be final. |
131
|
| 'numberOfRows' hides a field. |
131
|
| Method 'getPlayStyle' is not designed for extension - needs to be abstract, final or empty. |
135
|
| Missing a Javadoc comment. |
135
|
| Method 'setPlayStyle' is not designed for extension - needs to be abstract, final or empty. |
139
|
| Missing a Javadoc comment. |
139
|
| Parameter playStyle should be final. |
139
|
| 'playStyle' hides a field. |
139
|
net/sourceforge/simplegamenet/connectaline/CALSettingsPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
5
|
| Line is longer than 80 characters. |
7
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
13
|
| Name 'valueList' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
13
|
| Missing a Javadoc comment. |
36
|
| Missing a Javadoc comment. |
37
|
| Missing a Javadoc comment. |
52
|
| Missing a Javadoc comment. |
61
|
| Line is longer than 80 characters. |
63
|
| Missing a Javadoc comment. |
63
|
| Parameter maxNumberOfPlayer should be final. |
63
|
| Parameter maxNumberOfcon should be final. |
63
|
| Parameter lengthOfALine should be final. |
63
|
| Line is longer than 80 characters. |
64
|
| Parameter numberOfColumns should be final. |
64
|
| Parameter numberOfRows should be final. |
64
|
| Parameter playStyle should be final. |
64
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
65
|
| '10' is a magic number. |
68
|
| Line is longer than 80 characters. |
71
|
| '10' is a magic number. |
72
|
| '5' is a magic number. |
86
|
| '10' is a magic number. |
88
|
| Line is longer than 80 characters. |
89
|
| '5' is a magic number. |
90
|
| '5' is a magic number. |
91
|
| Line is longer than 80 characters. |
92
|
| '10' is a magic number. |
93
|
| '10' is a magic number. |
95
|
| Line is longer than 80 characters. |
96
|
| '10' is a magic number. |
97
|
| Line is longer than 80 characters. |
98
|
| '10' is a magic number. |
99
|
| Line is longer than 80 characters. |
100
|
| '10' is a magic number. |
101
|
| '5' is a magic number. |
103
|
| '6' is a magic number. |
109
|
| '16' is a magic number. |
112
|
| '3' is a magic number. |
115
|
| '6' is a magic number. |
115
|
| '3' is a magic number. |
116
|
| '5' is a magic number. |
118
|
| '15' is a magic number. |
118
|
| '4' is a magic number. |
119
|
| '5' is a magic number. |
120
|
| '6' is a magic number. |
122
|
| '6' is a magic number. |
123
|
| '+' should be on a new line. |
129
|
| '3' is a magic number. |
133
|
| '3' is a magic number. |
136
|
| '3' is a magic number. |
136
|
| Line is longer than 80 characters. |
138
|
| '3' is a magic number. |
140
|
| '4' is a magic number. |
141
|
| '5' is a magic number. |
142
|
| switch without "default" clause. |
143
|
| '6' is a magic number. |
145
|
| '6' is a magic number. |
148
|
| Method 'actionPerformed' is not designed for extension - needs to be abstract, final or empty. |
156
|
| Parameter actionEvent should be final. |
156
|
| Expected @param tag for 'actionEvent'. |
156
|
| Line is longer than 80 characters. |
168
|
| Line is longer than 80 characters. |
169
|
| Line is longer than 80 characters. |
174
|
| Line is longer than 80 characters. |
175
|
| Line is longer than 80 characters. |
186
|
| Method 'setEnabled' is not designed for extension - needs to be abstract, final or empty. |
204
|
| Missing a Javadoc comment. |
204
|
| Parameter enabled should be final. |
204
|
| Method 'getMaxNumberOfPlayer' is not designed for extension - needs to be abstract, final or empty. |
211
|
| Missing a Javadoc comment. |
211
|
| Line is longer than 80 characters. |
212
|
| Method 'getMaxNumberOfcon' is not designed for extension - needs to be abstract, final or empty. |
215
|
| Missing a Javadoc comment. |
215
|
| Line is longer than 80 characters. |
216
|
| Method 'getLengthOfALine' is not designed for extension - needs to be abstract, final or empty. |
219
|
| Missing a Javadoc comment. |
219
|
| Line is longer than 80 characters. |
220
|
| '3' is a magic number. |
220
|
| Method 'getNumberOfColumns' is not designed for extension - needs to be abstract, final or empty. |
223
|
| Missing a Javadoc comment. |
223
|
| Line is longer than 80 characters. |
224
|
| '4' is a magic number. |
224
|
| Method 'getNumberOfRows' is not designed for extension - needs to be abstract, final or empty. |
227
|
| Missing a Javadoc comment. |
227
|
| Line is longer than 80 characters. |
228
|
| '5' is a magic number. |
228
|
| Method 'getPlayStyle' is not designed for extension - needs to be abstract, final or empty. |
231
|
| Missing a Javadoc comment. |
231
|
| '6' is a magic number. |
233
|
| switch without "default" clause. |
234
|
net/sourceforge/simplegamenet/connectaline/CALSquare.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
7
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
10
|
| Method 'setPlayerID' is not designed for extension - needs to be abstract, final or empty. |
15
|
| Missing a Javadoc comment. |
15
|
| Parameter playerID should be final. |
15
|
| 'playerID' hides a field. |
15
|
| Method 'getOccupied' is not designed for extension - needs to be abstract, final or empty. |
20
|
| Missing a Javadoc comment. |
20
|
| Method 'getPlayerID' is not designed for extension - needs to be abstract, final or empty. |
24
|
| Missing a Javadoc comment. |
24
|
net/sourceforge/simplegamenet/connectaline/package.html
Error | Line |
| Missing package documentation file. | 0 |