Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
Files | Infos | Warnings | Errors |
37 | 0 | 0 | 1085 |
Files
net/sourceforge/simplegamenet/dice/DiceAll.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
7
|
| '5' is a magic number. |
7
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
10
|
| '6.0' is a magic number. |
12
|
| Method 'rollDice' is not designed for extension - needs to be abstract, final or empty. |
16
|
| Missing a Javadoc comment. |
16
|
| Parameter selectedDice should be final. |
16
|
| '6.0' is a magic number. |
20
|
| '6' is a magic number. |
23
|
| Must have at least one statement. |
27
|
| Method 'holdDice' is not designed for extension - needs to be abstract, final or empty. |
33
|
| Missing a Javadoc comment. |
33
|
| Parameter diceNumber should be final. |
33
|
| Method 'getDice' is not designed for extension - needs to be abstract, final or empty. |
45
|
| Missing a Javadoc comment. |
45
|
net/sourceforge/simplegamenet/dice/DiceFactory.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
13
|
| Line is longer than 80 characters. |
14
|
| Line is longer than 80 characters. |
15
|
| Method 'createGameServer' is not designed for extension - needs to be abstract, final or empty. |
19
|
| Missing a Javadoc comment. |
19
|
| Parameter serverEngine should be final. |
19
|
| Method 'createGamePlayerClient' is not designed for extension - needs to be abstract, final or empty. |
23
|
| Missing a Javadoc comment. |
23
|
| Parameter clientEngine should be final. |
23
|
| Method 'createDefaultGameSettings' is not designed for extension - needs to be abstract, final or empty. |
27
|
| Missing a Javadoc comment. |
27
|
net/sourceforge/simplegamenet/dice/DicePacket.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
7
|
| Variable 'dicePacketCode' must be private and have accessor methods. |
7
|
| Missing a Javadoc comment. |
8
|
| Variable 'diceData' must be private and have accessor methods. |
8
|
| Missing a Javadoc comment. |
10
|
| Parameter dicePacketCode should be final. |
10
|
| 'dicePacketCode' hides a field. |
10
|
| Parameter diceData should be final. |
10
|
| 'diceData' hides a field. |
10
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
15
|
| Missing a Javadoc comment. |
15
|
| '+' should be on a new line. |
16
|
| Avoid inline conditionals. |
17
|
| Method 'getDicePacketCode' is not designed for extension - needs to be abstract, final or empty. |
20
|
| Missing a Javadoc comment. |
20
|
| Method 'getDiceData' is not designed for extension - needs to be abstract, final or empty. |
24
|
| Missing a Javadoc comment. |
24
|
net/sourceforge/simplegamenet/dice/DicePacketCodes.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
5
|
| interfaces should describe a type and hence have methods. |
5
|
| Missing a Javadoc comment. |
7
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
19
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
21
|
net/sourceforge/simplegamenet/dice/DicePanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
3
|
| Line is longer than 80 characters. |
5
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
16
|
| Parameter dicePlayerClient should be final. |
16
|
| 'dicePlayerClient' hides a field. |
16
|
| '5' is a magic number. |
22
|
| '5' is a magic number. |
24
|
| '5' is a magic number. |
25
|
| '9.0' is a magic number. |
26
|
| '5' is a magic number. |
27
|
| '5' is a magic number. |
29
|
| '5' is a magic number. |
31
|
| '3' is a magic number. |
35
|
| '5' is a magic number. |
36
|
| Method 'setupDicePanels' is not designed for extension - needs to be abstract, final or empty. |
39
|
| Missing a Javadoc comment. |
39
|
| Method 'highlightDice' is not designed for extension - needs to be abstract, final or empty. |
44
|
| Missing a Javadoc comment. |
44
|
| Parameter diceNumber should be final. |
44
|
| Method 'enableScorePlayPanel' is not designed for extension - needs to be abstract, final or empty. |
48
|
| Missing a Javadoc comment. |
48
|
| Method 'enablePanelForPlay' is not designed for extension - needs to be abstract, final or empty. |
52
|
| Missing a Javadoc comment. |
52
|
| Parameter dicePlayerID should be final. |
52
|
| '5' is a magic number. |
60
|
| Line is longer than 80 characters. |
65
|
| '+' should be on a new line. |
65
|
| '5' is a magic number. |
70
|
| Line is longer than 80 characters. |
74
|
| Method 'disablePanel' is not designed for extension - needs to be abstract, final or empty. |
78
|
| Missing a Javadoc comment. |
78
|
| '5' is a magic number. |
82
|
| Method 'setRolledDice' is not designed for extension - needs to be abstract, final or empty. |
87
|
| Missing a Javadoc comment. |
87
|
| Parameter rolledDice should be final. |
87
|
| '6' is a magic number. |
90
|
| Method 'setTotalScores' is not designed for extension - needs to be abstract, final or empty. |
96
|
| Missing a Javadoc comment. |
96
|
| Parameter playerTotals should be final. |
96
|
| Method 'setFilledScore' is not designed for extension - needs to be abstract, final or empty. |
101
|
| Missing a Javadoc comment. |
101
|
| Parameter filledScore should be final. |
101
|
| Method 'askQuestion' is not designed for extension - needs to be abstract, final or empty. |
105
|
| Missing a Javadoc comment. |
105
|
| Method 'adjustSettingValues' is not designed for extension - needs to be abstract, final or empty. |
112
|
| Missing a Javadoc comment. |
112
|
| Parameter scoreToCount should be final. |
112
|
| Parameter settingValues should be final. |
112
|
| Line is longer than 80 characters. |
113
|
| '6' is a magic number. |
113
|
| Avoid inline conditionals. |
113
|
| '9' is a magic number. |
113
|
| '6' is a magic number. |
114
|
| Avoid inline conditionals. |
114
|
| '7' is a magic number. |
114
|
| Method 'getDiceScorePlayPanel' is not designed for extension - needs to be abstract, final or empty. |
117
|
| Missing a Javadoc comment. |
117
|
| Method 'showWinner' is not designed for extension - needs to be abstract, final or empty. |
121
|
| Missing a Javadoc comment. |
121
|
| Parameter winner should be final. |
121
|
| '+' should be on a new line. |
126
|
| Line is longer than 80 characters. |
128
|
| '+' should be on a new line. |
128
|
net/sourceforge/simplegamenet/dice/DicePlayDiceComponent.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
3
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
6
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
20
|
| Parameter dicePlayPanel should be final. |
20
|
| 'dicePlayPanel' hides a field. |
20
|
| Parameter diceValue should be final. |
20
|
| 'diceValue' hides a field. |
20
|
| Parameter diceSelected should be final. |
21
|
| 'diceSelected' hides a field. |
21
|
| '70' is a magic number. |
26
|
| '70' is a magic number. |
26
|
| '70' is a magic number. |
27
|
| '70' is a magic number. |
27
|
| Method 'paint' is not designed for extension - needs to be abstract, final or empty. |
31
|
| Missing a Javadoc comment. |
31
|
| Parameter graphics should be final. |
31
|
| Line is longer than 80 characters. |
33
|
| '10' is a magic number. |
33
|
| '10' is a magic number. |
33
|
| '10' is a magic number. |
33
|
| '10' is a magic number. |
33
|
| '300' is a magic number. |
34
|
| '300' is a magic number. |
34
|
| '300' is a magic number. |
34
|
| '300' is a magic number. |
34
|
| switch without "default" clause. |
35
|
| '5' is a magic number. |
38
|
| '5' is a magic number. |
45
|
| '5' is a magic number. |
52
|
| '3' is a magic number. |
57
|
| '5' is a magic number. |
59
|
| Method 'setDiceValue' is not designed for extension - needs to be abstract, final or empty. |
67
|
| Missing a Javadoc comment. |
67
|
| Parameter diceValue should be final. |
67
|
| 'diceValue' hides a field. |
67
|
| Method 'getDiceValue' is not designed for extension - needs to be abstract, final or empty. |
72
|
| Missing a Javadoc comment. |
72
|
| Line is longer than 80 characters. |
77
|
| Parameter mouseEvent should be final. |
79
|
| Expected @param tag for 'mouseEvent'. |
79
|
| Method 'mouseEntered' is not designed for extension - needs to be abstract, final or empty. |
85
|
| Parameter mouseEvent should be final. |
85
|
| Expected @param tag for 'mouseEvent'. |
85
|
| Method 'mouseExited' is not designed for extension - needs to be abstract, final or empty. |
97
|
| Parameter mouseEvent should be final. |
97
|
| Expected @param tag for 'mouseEvent'. |
97
|
| Method 'mousePressed' is not designed for extension - needs to be abstract, final or empty. |
109
|
| Parameter mouseEvent should be final. |
109
|
| Expected @param tag for 'mouseEvent'. |
109
|
| Parameter mouseEvent should be final. |
128
|
| Expected @param tag for 'mouseEvent'. |
128
|
| Method 'highlightDice' is not designed for extension - needs to be abstract, final or empty. |
131
|
| Missing a Javadoc comment. |
131
|
| Expression can be simplified. |
133
|
| '3' is a magic number. |
134
|
| Method 'getDiceSelected' is not designed for extension - needs to be abstract, final or empty. |
145
|
| Missing a Javadoc comment. |
145
|
| Method 'setMyTurn' is not designed for extension - needs to be abstract, final or empty. |
149
|
| Missing a Javadoc comment. |
149
|
| Parameter myTurn should be final. |
149
|
| 'myTurn' hides a field. |
149
|
| '3' is a magic number. |
155
|
| Method 'resetDice' is not designed for extension - needs to be abstract, final or empty. |
160
|
| Missing a Javadoc comment. |
160
|
net/sourceforge/simplegamenet/dice/DicePlayPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
5
|
| Line is longer than 80 characters. |
6
|
| Line is longer than 80 characters. |
9
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
12
|
| '5' is a magic number. |
12
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
17
|
| Parameter dicePlayerClient should be final. |
17
|
| 'dicePlayerClient' hides a field. |
17
|
| '10' is a magic number. |
20
|
| '50' is a magic number. |
21
|
| ';' is not followed by whitespace. |
21
|
| '10' is a magic number. |
22
|
| '50' is a magic number. |
23
|
| ';' is not followed by whitespace. |
23
|
| '10' is a magic number. |
24
|
| '50' is a magic number. |
25
|
| ';' is not followed by whitespace. |
25
|
| '10' is a magic number. |
26
|
| '50' is a magic number. |
27
|
| ';' is not followed by whitespace. |
27
|
| '10' is a magic number. |
28
|
| '50' is a magic number. |
29
|
| ';' is not followed by whitespace. |
29
|
| '10' is a magic number. |
30
|
| '5' is a magic number. |
31
|
| '50' is a magic number. |
33
|
| '20' is a magic number. |
35
|
| '10' is a magic number. |
36
|
| '5' is a magic number. |
37
|
| '5' is a magic number. |
44
|
| '4' is a magic number. |
44
|
| '3' is a magic number. |
45
|
| '6' is a magic number. |
45
|
| '5' is a magic number. |
45
|
| Method 'actionPerformed' is not designed for extension - needs to be abstract, final or empty. |
56
|
| Parameter actionEvent should be final. |
56
|
| Expected @param tag for 'actionEvent'. |
56
|
| Method 'diceClicked' is not designed for extension - needs to be abstract, final or empty. |
67
|
| Missing a Javadoc comment. |
67
|
| Parameter clickedDice should be final. |
67
|
| Line is longer than 80 characters. |
70
|
| Method 'getDice' is not designed for extension - needs to be abstract, final or empty. |
76
|
| Missing a Javadoc comment. |
76
|
| Parameter diceNumber should be final. |
76
|
| Method 'resetDice' is not designed for extension - needs to be abstract, final or empty. |
80
|
| Missing a Javadoc comment. |
80
|
| Method 'setDiceUnclicked' is not designed for extension - needs to be abstract, final or empty. |
87
|
| Missing a Javadoc comment. |
87
|
| Method 'setFirstTimesRolled' is not designed for extension - needs to be abstract, final or empty. |
93
|
| Missing a Javadoc comment. |
93
|
| Method 'setTimesRolled' is not designed for extension - needs to be abstract, final or empty. |
98
|
| Missing a Javadoc comment. |
98
|
| Method 'setEnabled' is not designed for extension - needs to be abstract, final or empty. |
112
|
| Missing a Javadoc comment. |
112
|
| Parameter enabled should be final. |
112
|
net/sourceforge/simplegamenet/dice/DicePlayerClient.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
4
|
| Line is longer than 80 characters. |
10
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
20
|
| Parameter clientEngine should be final. |
20
|
| Method 'createGamePanel' is not designed for extension - needs to be abstract, final or empty. |
24
|
| Missing a Javadoc comment. |
24
|
| Parameter utilityPanelFactory should be final. |
24
|
| Method 'receiveData' is not designed for extension - needs to be abstract, final or empty. |
29
|
| Missing a Javadoc comment. |
29
|
| Parameter data should be final. |
29
|
| '3' is a magic number. |
31
|
| Line is longer than 80 characters. |
56
|
| Line is longer than 80 characters. |
64
|
| Line is longer than 80 characters. |
70
|
| '10' is a magic number. |
72
|
| '11' is a magic number. |
72
|
| '12' is a magic number. |
73
|
| '13' is a magic number. |
73
|
| Line is longer than 80 characters. |
75
|
| Line is longer than 80 characters. |
84
|
| Line is longer than 80 characters. |
90
|
| Line is longer than 80 characters. |
93
|
| Line is longer than 80 characters. |
98
|
| Line is longer than 80 characters. |
101
|
| Method 'checkBonus' is not designed for extension - needs to be abstract, final or empty. |
110
|
| Missing a Javadoc comment. |
110
|
| '3' is a magic number. |
113
|
| '6' is a magic number. |
115
|
| Line is longer than 80 characters. |
120
|
| '3' is a magic number. |
122
|
| '6' is a magic number. |
124
|
| '3' is a magic number. |
129
|
| '6' is a magic number. |
131
|
| Method 'sendDicePacket' is not designed for extension - needs to be abstract, final or empty. |
138
|
| Missing a Javadoc comment. |
138
|
| Parameter dicePacket should be final. |
138
|
| Method 'getSettingValues' is not designed for extension - needs to be abstract, final or empty. |
142
|
| Missing a Javadoc comment. |
142
|
| Method 'getAmountValues' is not designed for extension - needs to be abstract, final or empty. |
146
|
| Missing a Javadoc comment. |
146
|
| Method 'getDicePlayerAmount' is not designed for extension - needs to be abstract, final or empty. |
150
|
| Missing a Javadoc comment. |
150
|
| Method 'getPlayerID' is not designed for extension - needs to be abstract, final or empty. |
154
|
| Missing a Javadoc comment. |
154
|
| Method 'getPlayerIDIndex' is not designed for extension - needs to be abstract, final or empty. |
158
|
| Missing a Javadoc comment. |
158
|
| Method 'getDiceParticipantIDs' is not designed for extension - needs to be abstract, final or empty. |
167
|
| Missing a Javadoc comment. |
167
|
| Method 'getDicePlayerNickname' is not designed for extension - needs to be abstract, final or empty. |
171
|
| Missing a Javadoc comment. |
171
|
| Parameter dicePlayerID should be final. |
171
|
| Method 'getNextPlayer' is not designed for extension - needs to be abstract, final or empty. |
176
|
| Missing a Javadoc comment. |
176
|
| Method 'gameStopping' is not designed for extension - needs to be abstract, final or empty. |
180
|
| Missing a Javadoc comment. |
180
|
| Method 'gameAborting' is not designed for extension - needs to be abstract, final or empty. |
185
|
| Missing a Javadoc comment. |
185
|
| Method 'containsPlayerID' is not designed for extension - needs to be abstract, final or empty. |
190
|
| Missing a Javadoc comment. |
190
|
| Parameter playerID should be final. |
190
|
net/sourceforge/simplegamenet/dice/DicePlayerScore.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
7
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
25
|
| '14' is a magic number. |
26
|
| Method 'setNewPoints' is not designed for extension - needs to be abstract, final or empty. |
34
|
| Missing a Javadoc comment. |
34
|
| Parameter scoreNumber should be final. |
34
|
| Parameter score should be final. |
34
|
| '7' is a magic number. |
35
|
| Method 'getPoints' is not designed for extension - needs to be abstract, final or empty. |
41
|
| Missing a Javadoc comment. |
41
|
| Parameter scoreNumber should be final. |
41
|
| Method 'getPlayerTotal' is not designed for extension - needs to be abstract, final or empty. |
46
|
| Missing a Javadoc comment. |
46
|
| '3' is a magic number. |
47
|
| '7' is a magic number. |
50
|
| '7' is a magic number. |
52
|
| Method 'getBonusFilled' is not designed for extension - needs to be abstract, final or empty. |
61
|
| Missing a Javadoc comment. |
61
|
| Method 'setBonusFilled' is not designed for extension - needs to be abstract, final or empty. |
65
|
| Missing a Javadoc comment. |
65
|
| Parameter bonusFilled should be final. |
65
|
| 'bonusFilled' hides a field. |
65
|
| Method 'getFOAKFilled' is not designed for extension - needs to be abstract, final or empty. |
69
|
| Missing a Javadoc comment. |
69
|
| Method 'setFOAKFilled' is not designed for extension - needs to be abstract, final or empty. |
73
|
| Missing a Javadoc comment. |
73
|
| Parameter fOAKFilled should be final. |
73
|
| 'fOAKFilled' hides a field. |
73
|
| Method 'getFOAKPoints' is not designed for extension - needs to be abstract, final or empty. |
77
|
| Missing a Javadoc comment. |
77
|
| Parameter scoreNumber should be final. |
77
|
| Method 'getGrandTotal' is not designed for extension - needs to be abstract, final or empty. |
81
|
| Missing a Javadoc comment. |
81
|
net/sourceforge/simplegamenet/dice/DiceScore.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
6
|
| Missing a Javadoc comment. |
6
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
22
|
| Missing a Javadoc comment. |
23
|
| Missing a Javadoc comment. |
25
|
| Line is longer than 80 characters. |
29
|
| Missing a Javadoc comment. |
29
|
| Parameter diceParticipantsIDs should be final. |
29
|
| 'diceParticipantsIDs' hides a field. |
29
|
| Parameter diceSettings should be final. |
29
|
| Parameter allDice should be final. |
29
|
| 'allDice' hides a field. |
29
|
| Method 'setDiceSettingValues' is not designed for extension - needs to be abstract, final or empty. |
41
|
| Missing a Javadoc comment. |
41
|
| Parameter diceSettings should be final. |
41
|
| Method 'countScore' is not designed for extension - needs to be abstract, final or empty. |
46
|
| Method length is 164 lines (max allowed is 150). |
46
|
| Missing a Javadoc comment. |
46
|
| Parameter diceParticipantID should be final. |
46
|
| Parameter scoreToCount should be final. |
46
|
| '5' is a magic number. |
47
|
| '6' is a magic number. |
48
|
| '3' is a magic number. |
76
|
| '3' is a magic number. |
81
|
| '3' is a magic number. |
83
|
| '4' is a magic number. |
84
|
| '4' is a magic number. |
89
|
| '4' is a magic number. |
91
|
| '5' is a magic number. |
92
|
| '5' is a magic number. |
97
|
| '5' is a magic number. |
99
|
| '6' is a magic number. |
100
|
| '8' is a magic number. |
105
|
| '9' is a magic number. |
122
|
| '3' is a magic number. |
131
|
| '10' is a magic number. |
139
|
| '3' is a magic number. |
150
|
| '||' should be on a new line. |
150
|
| '5' is a magic number. |
151
|
| '3' is a magic number. |
153
|
| '11' is a magic number. |
159
|
| '4' is a magic number. |
167
|
| '12' is a magic number. |
170
|
| '3' is a magic number. |
176
|
| '5' is a magic number. |
178
|
| '13' is a magic number. |
181
|
| '4' is a magic number. |
190
|
| '6' is a magic number. |
192
|
| '14' is a magic number. |
196
|
| Method 'adjustSettingValues' is not designed for extension - needs to be abstract, final or empty. |
211
|
| Missing a Javadoc comment. |
211
|
| Parameter scoreToCount should be final. |
211
|
| switch without "default" clause. |
212
|
| '6' is a magic number. |
213
|
| switch without "default" clause. |
214
|
| '5' is a magic number. |
219
|
| '10' is a magic number. |
222
|
| '10' is a magic number. |
229
|
| switch without "default" clause. |
230
|
| '3' is a magic number. |
232
|
| '3' is a magic number. |
235
|
| '5' is a magic number. |
235
|
| '3' is a magic number. |
238
|
| '10' is a magic number. |
238
|
| '3' is a magic number. |
241
|
| '3' is a magic number. |
242
|
| '11' is a magic number. |
245
|
| switch without "default" clause. |
246
|
| '4' is a magic number. |
248
|
| '4' is a magic number. |
251
|
| '5' is a magic number. |
251
|
| '4' is a magic number. |
254
|
| '10' is a magic number. |
254
|
| '4' is a magic number. |
257
|
| '4' is a magic number. |
258
|
| '12' is a magic number. |
261
|
| switch without "default" clause. |
262
|
| '5' is a magic number. |
264
|
| '5' is a magic number. |
267
|
| '5' is a magic number. |
267
|
| '5' is a magic number. |
270
|
| '10' is a magic number. |
270
|
| '5' is a magic number. |
273
|
| '5' is a magic number. |
274
|
| '13' is a magic number. |
277
|
| switch without "default" clause. |
278
|
| '6' is a magic number. |
280
|
| '6' is a magic number. |
283
|
| '5' is a magic number. |
283
|
| '6' is a magic number. |
286
|
| '10' is a magic number. |
286
|
| '6' is a magic number. |
289
|
| '6' is a magic number. |
290
|
| Line is longer than 80 characters. |
296
|
| Method 'setPlayerScore' is not designed for extension - needs to be abstract, final or empty. |
296
|
| Missing a Javadoc comment. |
296
|
| Parameter diceParticipantID should be final. |
296
|
| Parameter scoreNumber should be final. |
296
|
| Parameter score should be final. |
296
|
| Method 'getPlayerScore' is not designed for extension - needs to be abstract, final or empty. |
304
|
| Missing a Javadoc comment. |
304
|
| Parameter diceParticipantID should be final. |
304
|
| Parameter scoreNumber should be final. |
304
|
| Method 'getPlayerFOAKScore' is not designed for extension - needs to be abstract, final or empty. |
313
|
| Missing a Javadoc comment. |
313
|
| Parameter diceParticipantID should be final. |
313
|
| '12' is a magic number. |
316
|
| Method 'getPlayerTotals' is not designed for extension - needs to be abstract, final or empty. |
322
|
| Missing a Javadoc comment. |
322
|
| Parameter diceParticipantID should be final. |
322
|
| Method 'checkBonus' is not designed for extension - needs to be abstract, final or empty. |
331
|
| Missing a Javadoc comment. |
331
|
| Parameter diceParticipantID should be final. |
331
|
| '62' is a magic number. |
336
|
| '6' is a magic number. |
338
|
| '62' is a magic number. |
340
|
| '6' is a magic number. |
342
|
| Method 'getPlayerBonusFilled' is not designed for extension - needs to be abstract, final or empty. |
349
|
| Missing a Javadoc comment. |
349
|
| Parameter diceParticipantID should be final. |
349
|
| Method 'setPlayerBonusFilled' is not designed for extension - needs to be abstract, final or empty. |
358
|
| Missing a Javadoc comment. |
358
|
| Parameter diceParticipantID should be final. |
358
|
| Parameter playerBonusFilled should be final. |
359
|
| Method 'getWinner' is not designed for extension - needs to be abstract, final or empty. |
367
|
| Missing a Javadoc comment. |
367
|
| Line is longer than 80 characters. |
382
|
| Method 'getSettingValues' is not designed for extension - needs to be abstract, final or empty. |
389
|
| Missing a Javadoc comment. |
389
|
| Method 'getAmountValues' is not designed for extension - needs to be abstract, final or empty. |
393
|
| Missing a Javadoc comment. |
393
|
net/sourceforge/simplegamenet/dice/DiceScoreComponent.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
3
|
| Line is longer than 80 characters. |
4
|
| Missing a Javadoc comment. |
7
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
12
|
| Parameter enabled should be final. |
12
|
| 'enabled' hides a field. |
12
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
12
|
| Method 'setScoreLabel' is not designed for extension - needs to be abstract, final or empty. |
25
|
| Missing a Javadoc comment. |
25
|
| Parameter score should be final. |
25
|
| Method 'getScoreLabel' is not designed for extension - needs to be abstract, final or empty. |
31
|
| Missing a Javadoc comment. |
31
|
| Method 'setTotalScoreLabel' is not designed for extension - needs to be abstract, final or empty. |
35
|
| Missing a Javadoc comment. |
35
|
| Parameter total should be final. |
35
|
| Method 'isEnabled' is not designed for extension - needs to be abstract, final or empty. |
39
|
| Missing a Javadoc comment. |
39
|
| Method 'setEnabled' is not designed for extension - needs to be abstract, final or empty. |
43
|
| Missing a Javadoc comment. |
43
|
| Parameter enabled should be final. |
43
|
| 'enabled' hides a field. |
43
|
net/sourceforge/simplegamenet/dice/DiceScorePlayPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
3
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
6
|
| Line is longer than 80 characters. |
7
|
| Line is longer than 80 characters. |
10
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
14
|
| Line is longer than 80 characters. |
15
|
| Missing a Javadoc comment. |
15
|
| '16' is a magic number. |
15
|
| '8' is a magic number. |
15
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
34
|
| Missing a Javadoc comment. |
45
|
| Missing a Javadoc comment. |
57
|
| Missing a Javadoc comment. |
58
|
| Missing a Javadoc comment. |
60
|
| Parameter dicePlayerClient should be final. |
60
|
| 'dicePlayerClient' hides a field. |
60
|
| '5' is a magic number. |
63
|
| Line is longer than 80 characters. |
64
|
| '5' is a magic number. |
65
|
| Line is longer than 80 characters. |
66
|
| '20' is a magic number. |
66
|
| '10' is a magic number. |
67
|
| '8' is a magic number. |
68
|
| '20' is a magic number. |
69
|
| '30' is a magic number. |
71
|
| Line is longer than 80 characters. |
72
|
| '5' is a magic number. |
73
|
| Line is longer than 80 characters. |
74
|
| '20' is a magic number. |
74
|
| '10' is a magic number. |
75
|
| '8' is a magic number. |
76
|
| '20' is a magic number. |
77
|
| '5' is a magic number. |
79
|
| '5' is a magic number. |
80
|
| '5' is a magic number. |
82
|
| '8' is a magic number. |
83
|
| '20' is a magic number. |
84
|
| '5' is a magic number. |
86
|
| '16' is a magic number. |
88
|
| '8' is a magic number. |
89
|
| '3' is a magic number. |
90
|
| '6' is a magic number. |
91
|
| Line is longer than 80 characters. |
92
|
| '3' is a magic number. |
92
|
| '3' is a magic number. |
92
|
| '14' is a magic number. |
95
|
| '5' is a magic number. |
95
|
| '10' is a magic number. |
96
|
| '13' is a magic number. |
96
|
| Line is longer than 80 characters. |
97
|
| '9' is a magic number. |
97
|
| '16' is a magic number. |
97
|
| '5' is a magic number. |
97
|
| '16' is a magic number. |
101
|
| '8' is a magic number. |
102
|
| '16' is a magic number. |
107
|
| '8' is a magic number. |
108
|
| '8' is a magic number. |
109
|
| Line is longer than 80 characters. |
110
|
| '5' is a magic number. |
110
|
| '5' is a magic number. |
112
|
| '3' is a magic number. |
112
|
| '8' is a magic number. |
115
|
| Line is longer than 80 characters. |
116
|
| '8' is a magic number. |
116
|
| '18' is a magic number. |
116
|
| '10' is a magic number. |
118
|
| '3' is a magic number. |
118
|
| Line is longer than 80 characters. |
123
|
| '3' is a magic number. |
126
|
| '9' is a magic number. |
126
|
| '16' is a magic number. |
128
|
| '4' is a magic number. |
128
|
| Method 'showScorePlayCases' is not designed for extension - needs to be abstract, final or empty. |
133
|
| Missing a Javadoc comment. |
133
|
| '16' is a magic number. |
134
|
| '8' is a magic number. |
135
|
| Line is longer than 80 characters. |
136
|
| Method 'setScorePlayCases' is not designed for extension - needs to be abstract, final or empty. |
142
|
| Missing a Javadoc comment. |
142
|
| 'settingValues' hides a field. |
145
|
| Line is longer than 80 characters. |
148
|
| '16' is a magic number. |
151
|
| '8' is a magic number. |
152
|
| Line is longer than 80 characters. |
154
|
| '16' is a magic number. |
158
|
| '8' is a magic number. |
159
|
| '8' is a magic number. |
160
|
| '8' is a magic number. |
167
|
| '16' is a magic number. |
170
|
| '8' is a magic number. |
173
|
| Line is longer than 80 characters. |
184
|
| Parameter mouseEvent should be final. |
186
|
| Expected @param tag for 'mouseEvent'. |
186
|
| Method 'mouseEntered' is not designed for extension - needs to be abstract, final or empty. |
192
|
| Parameter mouseEvent should be final. |
192
|
| Expected @param tag for 'mouseEvent'. |
192
|
| Line is longer than 80 characters. |
195
|
| '7' is a magic number. |
196
|
| Line is longer than 80 characters. |
197
|
| '6' is a magic number. |
199
|
| Line is longer than 80 characters. |
201
|
| Line is longer than 80 characters. |
203
|
| '8' is a magic number. |
203
|
| Line is longer than 80 characters. |
204
|
| '8' is a magic number. |
204
|
| '8' is a magic number. |
205
|
| Line is longer than 80 characters. |
206
|
| Method 'mouseExited' is not designed for extension - needs to be abstract, final or empty. |
217
|
| Parameter mouseEvent should be final. |
217
|
| Expected @param tag for 'mouseEvent'. |
217
|
| Line is longer than 80 characters. |
220
|
| '7' is a magic number. |
221
|
| Line is longer than 80 characters. |
222
|
| '6' is a magic number. |
224
|
| Line is longer than 80 characters. |
226
|
| Line is longer than 80 characters. |
228
|
| '8' is a magic number. |
228
|
| Line is longer than 80 characters. |
229
|
| '8' is a magic number. |
229
|
| '8' is a magic number. |
230
|
| Line is longer than 80 characters. |
231
|
| Method 'mousePressed' is not designed for extension - needs to be abstract, final or empty. |
242
|
| Parameter mouseEvent should be final. |
242
|
| Expected @param tag for 'mouseEvent'. |
242
|
| Line is longer than 80 characters. |
245
|
| '7' is a magic number. |
246
|
| Line is longer than 80 characters. |
247
|
| '6' is a magic number. |
249
|
| Line is longer than 80 characters. |
251
|
| Line is longer than 80 characters. |
254
|
| Line is longer than 80 characters. |
257
|
| '8' is a magic number. |
257
|
| Line is longer than 80 characters. |
258
|
| '8' is a magic number. |
258
|
| '8' is a magic number. |
259
|
| Line is longer than 80 characters. |
260
|
| Line is longer than 80 characters. |
263
|
| '8' is a magic number. |
263
|
| Parameter mouseEvent should be final. |
275
|
| Expected @param tag for 'mouseEvent'. |
275
|
| Method 'setMyTurn' is not designed for extension - needs to be abstract, final or empty. |
278
|
| Missing a Javadoc comment. |
278
|
| Parameter myTurn should be final. |
278
|
| 'myTurn' hides a field. |
278
|
| '8' is a magic number. |
281
|
| '8' is a magic number. |
289
|
| '8' is a magic number. |
290
|
| '8' is a magic number. |
293
|
| Line is longer than 80 characters. |
300
|
| '7' is a magic number. |
301
|
| '6' is a magic number. |
303
|
| Line is longer than 80 characters. |
305
|
| '8' is a magic number. |
308
|
| '8' is a magic number. |
309
|
| Line is longer than 80 characters. |
310
|
| Method 'checkAllDisabled' is not designed for extension - needs to be abstract, final or empty. |
318
|
| Missing a Javadoc comment. |
318
|
| Parameter playerIDIndex should be final. |
318
|
| '6' is a magic number. |
319
|
| Method 'fillScore' is not designed for extension - needs to be abstract, final or empty. |
327
|
| Missing a Javadoc comment. |
327
|
| Parameter filledScore should be final. |
327
|
| '8' is a magic number. |
328
|
| Line is longer than 80 characters. |
329
|
| '8' is a magic number. |
332
|
| '8' is a magic number. |
333
|
| '8' is a magic number. |
333
|
| Method 'adjustSettingValue' is not designed for extension - needs to be abstract, final or empty. |
338
|
| Missing a Javadoc comment. |
338
|
| Parameter caseNumber should be final. |
338
|
| Parameter settingValue should be final. |
338
|
| Line is longer than 80 characters. |
339
|
| Method 'fillTotals' is not designed for extension - needs to be abstract, final or empty. |
342
|
| Missing a Javadoc comment. |
342
|
| Parameter leftTotal should be final. |
342
|
| Parameter rightTotal should be final. |
342
|
| Line is longer than 80 characters. |
344
|
| '7' is a magic number. |
345
|
| '8' is a magic number. |
347
|
| '7' is a magic number. |
347
|
| Method 'checkEnabled' is not designed for extension - needs to be abstract, final or empty. |
353
|
| Missing a Javadoc comment. |
353
|
| Parameter diceParticipantID should be final. |
353
|
| '6' is a magic number. |
356
|
| Method 'gameOver' is not designed for extension - needs to be abstract, final or empty. |
362
|
| Missing a Javadoc comment. |
362
|
| '16' is a magic number. |
363
|
| '8' is a magic number. |
364
|
net/sourceforge/simplegamenet/dice/DiceScoreTotalPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
3
|
| Line is longer than 80 characters. |
4
|
| Missing a Javadoc comment. |
7
|
| Missing a Javadoc comment. |
9
|
| Line is longer than 80 characters. |
10
|
| Missing a Javadoc comment. |
10
|
| '8' is a magic number. |
10
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
12
|
| '8' is a magic number. |
12
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
15
|
| Parameter dicePlayerClient should be final. |
15
|
| 'dicePlayerClient' hides a field. |
15
|
| Line is longer than 80 characters. |
18
|
| '5' is a magic number. |
18
|
| Line is longer than 80 characters. |
19
|
| Line is longer than 80 characters. |
20
|
| '10' is a magic number. |
20
|
| '8' is a magic number. |
21
|
| Line is longer than 80 characters. |
22
|
| '20' is a magic number. |
22
|
| Line is longer than 80 characters. |
24
|
| '5' is a magic number. |
24
|
| '5' is a magic number. |
25
|
| '10' is a magic number. |
27
|
| '20' is a magic number. |
28
|
| '5' is a magic number. |
29
|
| '3' is a magic number. |
32
|
| '8' is a magic number. |
33
|
| Line is longer than 80 characters. |
36
|
| '3' is a magic number. |
36
|
| '3' is a magic number. |
36
|
| Method 'showScoreTotalCases' is not designed for extension - needs to be abstract, final or empty. |
41
|
| Missing a Javadoc comment. |
41
|
| '8' is a magic number. |
42
|
| Line is longer than 80 characters. |
43
|
| Method 'setScoreTotalCases' is not designed for extension - needs to be abstract, final or empty. |
47
|
| Missing a Javadoc comment. |
47
|
| '8' is a magic number. |
50
|
| Line is longer than 80 characters. |
52
|
| '8' is a magic number. |
54
|
| '8' is a magic number. |
55
|
| Line is longer than 80 characters. |
58
|
| Method 'setPlayerNicknames' is not designed for extension - needs to be abstract, final or empty. |
63
|
| Missing a Javadoc comment. |
63
|
| Line is longer than 80 characters. |
68
|
| Line is longer than 80 characters. |
71
|
| '3' is a magic number. |
71
|
| Method 'fillTotal' is not designed for extension - needs to be abstract, final or empty. |
75
|
| Missing a Javadoc comment. |
75
|
| Parameter playerTotal should be final. |
75
|
| Line is longer than 80 characters. |
77
|
| Line is longer than 80 characters. |
78
|
net/sourceforge/simplegamenet/dice/DiceServer.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
20
|
| Parameter serverEngine should be final. |
20
|
| Missing a Javadoc comment. |
24
|
| Parameter diceParticipantIndex should be final. |
24
|
| Avoid inline conditionals. |
28
|
| Method 'sendDicePacket' is not designed for extension - needs to be abstract, final or empty. |
34
|
| Missing a Javadoc comment. |
34
|
| Parameter dicePacket should be final. |
34
|
| 'dicePacket' hides a field. |
34
|
| Method 'receiveData' is not designed for extension - needs to be abstract, final or empty. |
38
|
| Missing a Javadoc comment. |
38
|
| Parameter diceParticipantID should be final. |
38
|
| Parameter data should be final. |
38
|
| 'dicePacket' hides a field. |
39
|
| '3' is a magic number. |
40
|
| Line is longer than 80 characters. |
44
|
| Line is longer than 80 characters. |
45
|
| Line is longer than 80 characters. |
50
|
| Line is longer than 80 characters. |
54
|
| Line is longer than 80 characters. |
64
|
| Line is longer than 80 characters. |
66
|
| Line is longer than 80 characters. |
67
|
| Line is longer than 80 characters. |
68
|
| '10' is a magic number. |
68
|
| '11' is a magic number. |
68
|
| '12' is a magic number. |
68
|
| '13' is a magic number. |
69
|
| Line is longer than 80 characters. |
79
|
| Line is longer than 80 characters. |
80
|
| Line is longer than 80 characters. |
90
|
| Line is longer than 80 characters. |
92
|
| Method 'gameStarted' is not designed for extension - needs to be abstract, final or empty. |
102
|
| Missing a Javadoc comment. |
102
|
| Line is longer than 80 characters. |
103
|
| Line is longer than 80 characters. |
107
|
| Line is longer than 80 characters. |
109
|
| Line is longer than 80 characters. |
116
|
| Line is longer than 80 characters. |
118
|
| Method 'getDiceParticipantIDs' is not designed for extension - needs to be abstract, final or empty. |
121
|
| Missing a Javadoc comment. |
121
|
| Method 'getDiceSettings' is not designed for extension - needs to be abstract, final or empty. |
125
|
| Missing a Javadoc comment. |
125
|
| Method 'getSettingValues' is not designed for extension - needs to be abstract, final or empty. |
129
|
| Missing a Javadoc comment. |
129
|
| Method 'gameAborted' is not designed for extension - needs to be abstract, final or empty. |
133
|
| Missing a Javadoc comment. |
133
|
| Method 'getDicePlayerNickname' is not designed for extension - needs to be abstract, final or empty. |
137
|
| Missing a Javadoc comment. |
137
|
| Parameter dicePlayerID should be final. |
137
|
| Missing a Javadoc comment. |
142
|
| Line is longer than 80 characters. |
144
|
| '+' should be on a new line. |
147
|
| Line is longer than 80 characters. |
148
|
| '+' should be on a new line. |
148
|
| Method 'playerRemoved' is not designed for extension - needs to be abstract, final or empty. |
154
|
| Missing a Javadoc comment. |
154
|
| Parameter playerSettings should be final. |
154
|
| Line is longer than 80 characters. |
156
|
| Method 'containsPlayerID' is not designed for extension - needs to be abstract, final or empty. |
161
|
| Missing a Javadoc comment. |
161
|
| Parameter playerID should be final. |
161
|
net/sourceforge/simplegamenet/dice/DiceSettingOptions.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| interfaces should describe a type and hence have methods. |
3
|
| Missing a Javadoc comment. |
6
|
| Redundant 'public' modifier. |
6
|
| Missing a Javadoc comment. |
7
|
| Redundant 'public' modifier. |
7
|
| Missing a Javadoc comment. |
8
|
| Redundant 'public' modifier. |
8
|
| Missing a Javadoc comment. |
9
|
| Redundant 'public' modifier. |
9
|
net/sourceforge/simplegamenet/dice/DiceSettings.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
10
|
| '8' is a magic number. |
10
|
| '8' is a magic number. |
10
|
| Missing a Javadoc comment. |
14
|
| '35' is a magic number. |
14
|
| '25' is a magic number. |
14
|
| '30' is a magic number. |
14
|
| '40' is a magic number. |
14
|
| '50' is a magic number. |
14
|
| Missing a Javadoc comment. |
23
|
| Missing a Javadoc comment. |
26
|
| Parameter amountValues should be final. |
26
|
| 'amountValues' hides a field. |
26
|
| Parameter settingValues should be final. |
26
|
| 'settingValues' hides a field. |
26
|
| Method 'createGameSettingsPanel' is not designed for extension - needs to be abstract, final or empty. |
31
|
| Missing a Javadoc comment. |
31
|
| switch without "default" clause. |
34
|
| Line is longer than 80 characters. |
37
|
| Line is longer than 80 characters. |
41
|
| Line is longer than 80 characters. |
48
|
| Line is longer than 80 characters. |
50
|
| Line is longer than 80 characters. |
52
|
| Line is longer than 80 characters. |
54
|
| '3' is a magic number. |
54
|
| Line is longer than 80 characters. |
58
|
| Line is longer than 80 characters. |
64
|
| Method 'createChangedGameSettings' is not designed for extension - needs to be abstract, final or empty. |
64
|
| Missing a Javadoc comment. |
64
|
| Parameter gameSettingsPanel should be final. |
64
|
| Line is longer than 80 characters. |
65
|
| Line is longer than 80 characters. |
69
|
| Line is longer than 80 characters. |
71
|
| Line is longer than 80 characters. |
72
|
| Line is longer than 80 characters. |
74
|
| Line is longer than 80 characters. |
76
|
| Line is longer than 80 characters. |
78
|
| Line is longer than 80 characters. |
80
|
| '3' is a magic number. |
80
|
| Line is longer than 80 characters. |
84
|
| Line is longer than 80 characters. |
86
|
| Line is longer than 80 characters. |
88
|
| Line is longer than 80 characters. |
90
|
| '3' is a magic number. |
90
|
| Line is longer than 80 characters. |
95
|
| '3' is a magic number. |
95
|
| '3' is a magic number. |
96
|
| Line is longer than 80 characters. |
97
|
| '4' is a magic number. |
97
|
| '4' is a magic number. |
98
|
| Line is longer than 80 characters. |
99
|
| '5' is a magic number. |
99
|
| '5' is a magic number. |
100
|
| Line is longer than 80 characters. |
101
|
| '6' is a magic number. |
101
|
| '6' is a magic number. |
102
|
| Line is longer than 80 characters. |
103
|
| '7' is a magic number. |
103
|
| Method 'getAmountValues' is not designed for extension - needs to be abstract, final or empty. |
108
|
| Missing a Javadoc comment. |
108
|
| Line is longer than 80 characters. |
110
|
| Method 'getSettingValues' is not designed for extension - needs to be abstract, final or empty. |
114
|
| Missing a Javadoc comment. |
114
|
| Line is longer than 80 characters. |
116
|
| Method 'isChangeGameSettingsAllowed' is not designed for extension - needs to be abstract, final or empty. |
120
|
| Missing a Javadoc comment. |
120
|
| Parameter newGameSettings should be final. |
120
|
| Conditional logic can be removed. |
122
|
| Method 'isCreateDefaultPlayerSettingsAllowed' is not designed for extension - needs to be abstract, final or empty. |
132
|
| Missing a Javadoc comment. |
132
|
| Parameter playerType should be final. |
132
|
| Line is longer than 80 characters. |
133
|
| Line is longer than 80 characters. |
139
|
| Method 'createDefaultPlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
139
|
| Missing a Javadoc comment. |
139
|
| Parameter playerID should be final. |
139
|
| Parameter playerType should be final. |
139
|
| Parameter nickname should be final. |
140
|
| Avoid inline conditionals. |
141
|
| Line is longer than 80 characters. |
143
|
| Line is longer than 80 characters. |
146
|
| Line is longer than 80 characters. |
150
|
| Method 'isChangePlayerSettingsAllowed' is not designed for extension - needs to be abstract, final or empty. |
150
|
| Missing a Javadoc comment. |
150
|
| Parameter currentPlayerSettings should be final. |
150
|
| Line is longer than 80 characters. |
151
|
| Parameter changedPlayerSettings should be final. |
151
|
| Conditional logic can be removed. |
152
|
| Line is longer than 80 characters. |
153
|
| Line is longer than 80 characters. |
154
|
| Method 'isStartGameAllowed' is not designed for extension - needs to be abstract, final or empty. |
161
|
| Missing a Javadoc comment. |
161
|
net/sourceforge/simplegamenet/dice/DiceSettingsPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
5
|
| Line is longer than 80 characters. |
7
|
| Line is longer than 80 characters. |
10
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
19
|
| Missing a Javadoc comment. |
21
|
| Name 'valueList' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
21
|
| Missing a Javadoc comment. |
49
|
| Missing a Javadoc comment. |
68
|
| Missing a Javadoc comment. |
78
|
| Missing a Javadoc comment. |
79
|
| Missing a Javadoc comment. |
81
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
81
|
| '10' is a magic number. |
85
|
| '10' is a magic number. |
90
|
| '10' is a magic number. |
92
|
| Line is longer than 80 characters. |
93
|
| '10' is a magic number. |
94
|
| '5' is a magic number. |
99
|
| '10' is a magic number. |
101
|
| Line is longer than 80 characters. |
102
|
| '5' is a magic number. |
103
|
| '5' is a magic number. |
104
|
| Line is longer than 80 characters. |
105
|
| '10' is a magic number. |
106
|
| Line is longer than 80 characters. |
107
|
| '10' is a magic number. |
108
|
| Line is longer than 80 characters. |
109
|
| '5' is a magic number. |
110
|
| '5' is a magic number. |
112
|
| '10' is a magic number. |
114
|
| '10' is a magic number. |
116
|
| '10' is a magic number. |
118
|
| '5' is a magic number. |
120
|
| '5' is a magic number. |
130
|
| '10' is a magic number. |
132
|
| '10' is a magic number. |
134
|
| '5' is a magic number. |
136
|
| Line is longer than 80 characters. |
145
|
| '100' is a magic number. |
164
|
| Line is longer than 80 characters. |
173
|
| '5' is a magic number. |
173
|
| Line is longer than 80 characters. |
174
|
| '3' is a magic number. |
174
|
| '5' is a magic number. |
174
|
| '3' is a magic number. |
179
|
| '3' is a magic number. |
180
|
| '5' is a magic number. |
180
|
| '5' is a magic number. |
182
|
| '3' is a magic number. |
184
|
| '5' is a magic number. |
184
|
| '6' is a magic number. |
185
|
| '7' is a magic number. |
185
|
| '5' is a magic number. |
187
|
| '11' is a magic number. |
187
|
| '7' is a magic number. |
189
|
| '11' is a magic number. |
189
|
| Line is longer than 80 characters. |
193
|
| Line is longer than 80 characters. |
195
|
| '16' is a magic number. |
197
|
| '8' is a magic number. |
199
|
| '8' is a magic number. |
201
|
| '8' is a magic number. |
206
|
| '3' is a magic number. |
213
|
| '3' is a magic number. |
214
|
| '3' is a magic number. |
215
|
| '3' is a magic number. |
215
|
| '7' is a magic number. |
216
|
| '3' is a magic number. |
216
|
| '5' is a magic number. |
217
|
| '3' is a magic number. |
217
|
| Method 'actionPerformed' is not designed for extension - needs to be abstract, final or empty. |
220
|
| Missing a Javadoc comment. |
220
|
| Parameter actionEvent should be final. |
220
|
| Line is longer than 80 characters. |
222
|
| Line is longer than 80 characters. |
223
|
| Line is longer than 80 characters. |
228
|
| Line is longer than 80 characters. |
229
|
| Line is longer than 80 characters. |
230
|
| Line is longer than 80 characters. |
250
|
| Method 'setEnabled' is not designed for extension - needs to be abstract, final or empty. |
268
|
| Missing a Javadoc comment. |
268
|
| Parameter enabled should be final. |
268
|
| Method 'getSettingComboBoxesLength' is not designed for extension - needs to be abstract, final or empty. |
277
|
| Missing a Javadoc comment. |
277
|
| Method 'getSettingComboBoxesSelectedIndex' is not designed for extension - needs to be abstract, final or empty. |
281
|
| Missing a Javadoc comment. |
281
|
| Parameter i should be final. |
281
|
| Method 'setSettingComboBoxesSelectedIndex' is not designed for extension - needs to be abstract, final or empty. |
285
|
| Missing a Javadoc comment. |
285
|
| Parameter i should be final. |
285
|
| Parameter selection should be final. |
285
|
| Method 'getSettingComboBoxesScoresSelectedItem' is not designed for extension - needs to be abstract, final or empty. |
289
|
| Missing a Javadoc comment. |
289
|
| Parameter i should be final. |
289
|
| Method 'setMaximumParticipantsComboBoxSelectedIndex' is not designed for extension - needs to be abstract, final or empty. |
293
|
| Missing a Javadoc comment. |
293
|
| Parameter i should be final. |
293
|
| Method 'getMaximumParticipantsComboBoxSelectedItem' is not designed for extension - needs to be abstract, final or empty. |
297
|
| Missing a Javadoc comment. |
297
|
| Method 'setMaximumConnectionsComboBoxSelectedIndex' is not designed for extension - needs to be abstract, final or empty. |
301
|
| Missing a Javadoc comment. |
301
|
| Parameter i should be final. |
301
|
| Method 'getMaximumConnectionsComboBoxSelectedItem' is not designed for extension - needs to be abstract, final or empty. |
305
|
| Missing a Javadoc comment. |
305
|
net/sourceforge/simplegamenet/dice/DiceSingle.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
6
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
11
|
| First sentence should end with a period. |
13
|
| Parameter diceValue should be final. |
18
|
| 'diceValue' hides a field. |
18
|
| Method 'setDiceHeld' is not designed for extension - needs to be abstract, final or empty. |
27
|
| Parameter holdDice should be final. |
27
|
| Method 'isDiceHeld' is not designed for extension - needs to be abstract, final or empty. |
36
|
| Method 'getDiceValue' is not designed for extension - needs to be abstract, final or empty. |
45
|
| Method 'setDiceValue' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Parameter diceValue should be final. |
54
|
| 'diceValue' hides a field. |
54
|
net/sourceforge/simplegamenet/dice/package.html
Error | Line |
| Missing package documentation file. | 0 |