Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
Files | Infos | Warnings | Errors |
50 | 0 | 0 | 996 |
Files
net/sourceforge/simplegamenet/specs/gui/GamePanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
3
|
| Line is longer than 80 characters. |
6
|
| Line is longer than 80 characters. |
8
|
| Line is longer than 80 characters. |
9
|
| Line is longer than 80 characters. |
11
|
| Line is longer than 80 characters. |
12
|
| Line is longer than 80 characters. |
16
|
| 'public' modifier out of order with the JLS suggestions. |
18
|
| Line is longer than 80 characters. |
21
|
| Line is longer than 80 characters. |
24
|
| Line is longer than 80 characters. |
27
|
net/sourceforge/simplegamenet/specs/gui/GameSettingsPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
3
|
| Line is longer than 80 characters. |
6
|
| Line is longer than 80 characters. |
7
|
| Line is longer than 80 characters. |
8
|
| Line is longer than 80 characters. |
9
|
| Line is longer than 80 characters. |
10
|
| Line is longer than 80 characters. |
12
|
| Line is longer than 80 characters. |
13
|
| Line is longer than 80 characters. |
14
|
| Line is longer than 80 characters. |
17
|
| 'public' modifier out of order with the JLS suggestions. |
23
|
| Line is longer than 80 characters. |
26
|
| Line is longer than 80 characters. |
27
|
| Line is longer than 80 characters. |
30
|
| Line is longer than 80 characters. |
31
|
| Method 'areSettingsAcceptable' is not designed for extension - needs to be abstract, final or empty. |
36
|
| Method 'setEnabled' is not designed for extension - needs to be abstract, final or empty. |
40
|
| Missing a Javadoc comment. |
40
|
| Parameter enabled should be final. |
40
|
net/sourceforge/simplegamenet/specs/gui/PlayerSettingsPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
3
|
| Line is longer than 80 characters. |
6
|
| Line is longer than 80 characters. |
7
|
| Line is longer than 80 characters. |
8
|
| Line is longer than 80 characters. |
9
|
| Line is longer than 80 characters. |
11
|
| Line is longer than 80 characters. |
12
|
| Line is longer than 80 characters. |
13
|
| Line is longer than 80 characters. |
14
|
| Line is longer than 80 characters. |
16
|
| 'public' modifier out of order with the JLS suggestions. |
22
|
| Line is longer than 80 characters. |
25
|
| Line is longer than 80 characters. |
26
|
| Line is longer than 80 characters. |
27
|
| Line is longer than 80 characters. |
29
|
| Line is longer than 80 characters. |
30
|
| Method 'areSettingsAcceptable' is not designed for extension - needs to be abstract, final or empty. |
35
|
| Method 'setEnabled' is not designed for extension - needs to be abstract, final or empty. |
39
|
| Missing a Javadoc comment. |
39
|
| Parameter enabled should be final. |
39
|
net/sourceforge/simplegamenet/specs/gui/UtilityPanelFactory.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
3
|
| Line is longer than 80 characters. |
6
|
| Line is longer than 80 characters. |
7
|
| Line is longer than 80 characters. |
12
|
| Line is longer than 80 characters. |
17
|
| Line is longer than 80 characters. |
18
|
| Line is longer than 80 characters. |
19
|
| Line is longer than 80 characters. |
20
|
| Redundant 'public' modifier. |
26
|
net/sourceforge/simplegamenet/specs/gui/package.html
Error | Line |
| Missing package documentation file. | 0 |
net/sourceforge/simplegamenet/specs/model/ClientEngine.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| First sentence should end with a period. |
6
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
16
|
net/sourceforge/simplegamenet/specs/model/Engine.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| First sentence should end with a period. |
7
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
17
|
net/sourceforge/simplegamenet/specs/model/GameFactory.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
8
|
| Line is longer than 80 characters. |
9
|
| Line is longer than 80 characters. |
10
|
| 'public' modifier out of order with the JLS suggestions. |
18
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
21
|
| Missing a Javadoc comment. |
22
|
| Missing a Javadoc comment. |
23
|
| Line is longer than 80 characters. |
26
|
| Line is longer than 80 characters. |
31
|
| Line is longer than 80 characters. |
33
|
| Line is longer than 80 characters. |
36
|
| Parameter name should be final. |
38
|
| 'name' hides a field. |
38
|
| Parameter version should be final. |
38
|
| 'version' hides a field. |
38
|
| Parameter description should be final. |
38
|
| 'description' hides a field. |
38
|
| Parameter author should be final. |
39
|
| 'author' hides a field. |
39
|
| Parameter serverEngine should be final. |
52
|
| Line is longer than 80 characters. |
57
|
| Line is longer than 80 characters. |
60
|
| Parameter clientEngine should be final. |
60
|
| Line is longer than 80 characters. |
63
|
| Method 'createDefaultGameSettings' is not designed for extension - needs to be abstract, final or empty. |
68
|
| Line is longer than 80 characters. |
73
|
| Line is longer than 80 characters. |
74
|
| Method 'isBotProvided' is not designed for extension - needs to be abstract, final or empty. |
79
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
95
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
104
|
| Method 'getVersion' is not designed for extension - needs to be abstract, final or empty. |
113
|
| Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. |
122
|
| Method 'getAuthor' is not designed for extension - needs to be abstract, final or empty. |
131
|
| Line is longer than 80 characters. |
136
|
| Line is longer than 80 characters. |
137
|
| Line is longer than 80 characters. |
138
|
| Line is longer than 80 characters. |
140
|
| Line is longer than 80 characters. |
143
|
| Method 'getMinimumSimpleGameNetVersion' is not designed for extension - needs to be abstract, final or empty. |
145
|
| Line is longer than 80 characters. |
150
|
| Line is longer than 80 characters. |
154
|
| Definition of 'equals()' without corresponding definition of 'hashCode()'. |
156
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
156
|
| Parameter o should be final. |
156
|
| Line is longer than 80 characters. |
161
|
| Line is longer than 80 characters. |
165
|
| Line is longer than 80 characters. |
168
|
| Line is longer than 80 characters. |
169
|
| Line is longer than 80 characters. |
170
|
| Line is longer than 80 characters. |
171
|
| Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. |
174
|
| Parameter o should be final. |
174
|
net/sourceforge/simplegamenet/specs/model/GamePlayerClient.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
9
|
| 'public' modifier out of order with the JLS suggestions. |
9
|
| Missing a Javadoc comment. |
11
|
| Variable 'clientEngine' must be private and have accessor methods. |
11
|
| Missing a Javadoc comment. |
13
|
| Parameter clientEngine should be final. |
13
|
| 'clientEngine' hides a field. |
13
|
| Line is longer than 80 characters. |
17
|
| Missing a Javadoc comment. |
17
|
| Parameter utilityPanelFactory should be final. |
17
|
| Missing a Javadoc comment. |
19
|
| Parameter outdatedGameSettings should be final. |
19
|
| Parameter updatedGameSettings should be final. |
20
|
| Missing a Javadoc comment. |
23
|
| Parameter playerSettings should be final. |
23
|
| Missing a Javadoc comment. |
26
|
| Parameter outdatedPlayerSettings should be final. |
26
|
| Parameter updatedPlayerSettings should be final. |
27
|
| Missing a Javadoc comment. |
30
|
| Parameter playerSettings should be final. |
30
|
| Missing a Javadoc comment. |
33
|
| Missing a Javadoc comment. |
36
|
| Parameter data should be final. |
36
|
| Missing a Javadoc comment. |
38
|
| Missing a Javadoc comment. |
41
|
| Missing a Javadoc comment. |
44
|
| Missing a Javadoc comment. |
47
|
net/sourceforge/simplegamenet/specs/model/GameServer.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
7
|
| 'public' modifier out of order with the JLS suggestions. |
7
|
| Missing a Javadoc comment. |
9
|
| Variable 'serverEngine' must be private and have accessor methods. |
9
|
| Missing a Javadoc comment. |
11
|
| Parameter serverEngine should be final. |
11
|
| 'serverEngine' hides a field. |
11
|
| Missing a Javadoc comment. |
15
|
| Parameter outdatedGameSettings should be final. |
15
|
| Parameter updatedGameSettings should be final. |
16
|
| Missing a Javadoc comment. |
19
|
| Parameter playerSettings should be final. |
19
|
| Missing a Javadoc comment. |
22
|
| Parameter outdatedPlayerSettings should be final. |
22
|
| Parameter updatedPlayerSettings should be final. |
23
|
| Method 'playerRemoved' is not designed for extension - needs to be abstract, final or empty. |
26
|
| Missing a Javadoc comment. |
26
|
| Parameter playerSettings should be final. |
26
|
| Missing a Javadoc comment. |
30
|
| Missing a Javadoc comment. |
32
|
| Parameter playerID should be final. |
32
|
| Parameter data should be final. |
32
|
| Missing a Javadoc comment. |
34
|
| Missing a Javadoc comment. |
37
|
net/sourceforge/simplegamenet/specs/model/ServerEngine.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| First sentence should end with a period. |
5
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
13
|
| Line is longer than 80 characters. |
15
|
| Missing a Javadoc comment. |
15
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
15
|
| Missing a Javadoc comment. |
17
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
18
|
| Missing a Javadoc comment. |
20
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
21
|
| Missing a Javadoc comment. |
23
|
| Missing a Javadoc comment. |
25
|
net/sourceforge/simplegamenet/specs/model/package.html
Error | Line |
| Missing package documentation file. | 0 |
net/sourceforge/simplegamenet/specs/to/GameSettings.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Unused import - net.sourceforge.simplegamenet.specs.tools.MultiPlayerGameSettings. |
6
|
| Line is longer than 80 characters. |
10
|
| Line is longer than 80 characters. |
11
|
| Line is longer than 80 characters. |
12
|
| Line is longer than 80 characters. |
15
|
| Line is longer than 80 characters. |
18
|
| Line is longer than 80 characters. |
19
|
| Line is longer than 80 characters. |
20
|
| Line is longer than 80 characters. |
21
|
| Line is longer than 80 characters. |
22
|
| Line is longer than 80 characters. |
27
|
| Line is longer than 80 characters. |
33
|
| Line is longer than 80 characters. |
34
|
| Line is longer than 80 characters. |
36
|
| Line is longer than 80 characters. |
37
|
| Line is longer than 80 characters. |
38
|
| Variable 'engine' must be private and have accessor methods. |
41
|
| Line is longer than 80 characters. |
44
|
| Line is longer than 80 characters. |
45
|
| Line is longer than 80 characters. |
47
|
| Line is longer than 80 characters. |
48
|
| Line is longer than 80 characters. |
58
|
| Line is longer than 80 characters. |
59
|
| Line is longer than 80 characters. |
60
|
| Line is longer than 80 characters. |
61
|
| Line is longer than 80 characters. |
70
|
| Line is longer than 80 characters. |
72
|
| Line is longer than 80 characters. |
75
|
| Line is longer than 80 characters. |
80
|
| Line is longer than 80 characters. |
83
|
| Parameter gameSettingsPanel should be final. |
83
|
| Line is longer than 80 characters. |
86
|
| Line is longer than 80 characters. |
90
|
| Line is longer than 80 characters. |
91
|
| Line is longer than 80 characters. |
94
|
| Line is longer than 80 characters. |
97
|
| Method 'isChangeGameSettingsAllowed' is not designed for extension - needs to be abstract, final or empty. |
97
|
| Parameter changedGameSettings should be final. |
97
|
| Line is longer than 80 characters. |
102
|
| Line is longer than 80 characters. |
103
|
| Line is longer than 80 characters. |
104
|
| Line is longer than 80 characters. |
107
|
| Line is longer than 80 characters. |
110
|
| Method 'isCreateDefaultPlayerSettingsAllowed' is not designed for extension - needs to be abstract, final or empty. |
113
|
| Parameter playerType should be final. |
113
|
| Line is longer than 80 characters. |
118
|
| Line is longer than 80 characters. |
119
|
| Line is longer than 80 characters. |
120
|
| Line is longer than 80 characters. |
123
|
| Line is longer than 80 characters. |
124
|
| Line is longer than 80 characters. |
125
|
| Line is longer than 80 characters. |
128
|
| Line is longer than 80 characters. |
129
|
| Line is longer than 80 characters. |
133
|
| Method 'createDefaultPlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
133
|
| Parameter playerID should be final. |
133
|
| Parameter playerType should be final. |
133
|
| Parameter nickname should be final. |
134
|
| Avoid inline conditionals. |
135
|
| Line is longer than 80 characters. |
137
|
| Line is longer than 80 characters. |
142
|
| Line is longer than 80 characters. |
145
|
| Line is longer than 80 characters. |
148
|
| Line is longer than 80 characters. |
149
|
| Line is longer than 80 characters. |
154
|
| Line is longer than 80 characters. |
156
|
| Method 'isChangePlayerSettingsAllowed' is not designed for extension - needs to be abstract, final or empty. |
156
|
| Parameter currentPlayerSettings should be final. |
156
|
| Line is longer than 80 characters. |
157
|
| Parameter changedPlayerSettings should be final. |
157
|
| Line is longer than 80 characters. |
162
|
| Line is longer than 80 characters. |
164
|
| Line is longer than 80 characters. |
165
|
| Method 'isStartGameAllowed' is not designed for extension - needs to be abstract, final or empty. |
170
|
| Line is longer than 80 characters. |
175
|
| Parameter engine should be final. |
180
|
| 'engine' hides a field. |
180
|
| Expected @param tag for 'engine'. |
180
|
net/sourceforge/simplegamenet/specs/to/PlayerSettings.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Unused import - net.sourceforge.simplegamenet.specs.tools.StandardPlayerSettings. |
6
|
| Line is longer than 80 characters. |
9
|
| Line is longer than 80 characters. |
10
|
| Line is longer than 80 characters. |
11
|
| Line is longer than 80 characters. |
14
|
| Line is longer than 80 characters. |
17
|
| Line is longer than 80 characters. |
18
|
| Line is longer than 80 characters. |
19
|
| Line is longer than 80 characters. |
20
|
| Line is longer than 80 characters. |
21
|
| Line is longer than 80 characters. |
22
|
| First sentence should end with a period. |
32
|
| Line is longer than 80 characters. |
60
|
| Line is longer than 80 characters. |
61
|
| Variable 'engine' must be private and have accessor methods. |
64
|
| Missing a Javadoc comment. |
66
|
| Missing a Javadoc comment. |
67
|
| Missing a Javadoc comment. |
69
|
| Missing a Javadoc comment. |
70
|
| Line is longer than 80 characters. |
74
|
| Line is longer than 80 characters. |
77
|
| Line is longer than 80 characters. |
78
|
| Line is longer than 80 characters. |
83
|
| Line is longer than 80 characters. |
84
|
| Line is longer than 80 characters. |
87
|
| Line is longer than 80 characters. |
90
|
| Parameter engine should be final. |
90
|
| 'engine' hides a field. |
90
|
| Parameter playerID should be final. |
90
|
| 'playerID' hides a field. |
90
|
| Parameter playerType should be final. |
90
|
| 'playerType' hides a field. |
90
|
| Parameter nickname should be final. |
90
|
| 'nickname' hides a field. |
90
|
| Parameter playingState should be final. |
91
|
| 'playingState' hides a field. |
91
|
| Line is longer than 80 characters. |
95
|
| Line is longer than 80 characters. |
100
|
| Line is longer than 80 characters. |
101
|
| Line is longer than 80 characters. |
109
|
| Line is longer than 80 characters. |
110
|
| Line is longer than 80 characters. |
111
|
| Line is longer than 80 characters. |
114
|
| Line is longer than 80 characters. |
117
|
| Unused @param tag for 'gameSettingsPanel'. |
117
|
| Parameter playerSettingsPanel should be final. |
121
|
| Expected @param tag for 'playerSettingsPanel'. |
121
|
| Line is longer than 80 characters. |
124
|
| Line is longer than 80 characters. |
125
|
| Line is longer than 80 characters. |
128
|
| Line is longer than 80 characters. |
129
|
| Line is longer than 80 characters. |
132
|
| Line is longer than 80 characters. |
133
|
| Line is longer than 80 characters. |
136
|
| Method 'isChangePlayerSettingsAllowed' is not designed for extension - needs to be abstract, final or empty. |
136
|
| Parameter changedPlayerSettings should be final. |
136
|
| Line is longer than 80 characters. |
141
|
| Line is longer than 80 characters. |
143
|
| Line is longer than 80 characters. |
145
|
| Method 'isChattingAllowedDuringGame' is not designed for extension - needs to be abstract, final or empty. |
147
|
| Method 'getPlayerID' is not designed for extension - needs to be abstract, final or empty. |
162
|
| Line is longer than 80 characters. |
167
|
| Method 'getPlayerType' is not designed for extension - needs to be abstract, final or empty. |
171
|
| Method 'getNickname' is not designed for extension - needs to be abstract, final or empty. |
180
|
| Line is longer than 80 characters. |
185
|
| Method 'getPlayingState' is not designed for extension - needs to be abstract, final or empty. |
189
|
| Line is longer than 80 characters. |
194
|
| Line is longer than 80 characters. |
195
|
| Method 'setPlayingState' is not designed for extension - needs to be abstract, final or empty. |
200
|
| Parameter playingState should be final. |
200
|
| 'playingState' hides a field. |
200
|
| Line is longer than 80 characters. |
208
|
| Definition of 'equals()' without corresponding definition of 'hashCode()'. |
210
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
210
|
| Parameter object should be final. |
210
|
| Line is longer than 80 characters. |
222
|
| Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. |
224
|
| Parameter object should be final. |
224
|
| Line is longer than 80 characters. |
232
|
| Parameter engine should be final. |
237
|
| 'engine' hides a field. |
237
|
| Expected @param tag for 'engine'. |
237
|
| Line is longer than 80 characters. |
242
|
| Method 'setNickname' is not designed for extension - needs to be abstract, final or empty. |
247
|
| Parameter nickname should be final. |
247
|
| 'nickname' hides a field. |
247
|
| Expected @param tag for 'nickname'. |
247
|
| Line is longer than 80 characters. |
248
|
net/sourceforge/simplegamenet/specs/to/PlayerSettingsMap.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
9
|
| Line is longer than 80 characters. |
15
|
| Missing a Javadoc comment. |
19
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
22
|
| '8' is a magic number. |
23
|
| Line is longer than 80 characters. |
26
|
| Missing a Javadoc comment. |
26
|
| Parameter engine should be final. |
26
|
| Parameter playerSettingsArray should be final. |
26
|
| '8' is a magic number. |
27
|
| Line is longer than 80 characters. |
30
|
| Line is longer than 80 characters. |
31
|
| Line is longer than 80 characters. |
38
|
| Line is longer than 80 characters. |
41
|
| Method 'containsPlayerID' is not designed for extension - needs to be abstract, final or empty. |
43
|
| Parameter playerID should be final. |
43
|
| Line is longer than 80 characters. |
48
|
| Line is longer than 80 characters. |
49
|
| Line is longer than 80 characters. |
51
|
| Line is longer than 80 characters. |
52
|
| Method 'getPlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
55
|
| Parameter playerID should be final. |
55
|
| Avoid inline conditionals. |
57
|
| Line is longer than 80 characters. |
61
|
| Method 'getHostPlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
66
|
| Line is longer than 80 characters. |
68
|
| Method 'getPlayerIDs' is not designed for extension - needs to be abstract, final or empty. |
81
|
| Line is longer than 80 characters. |
91
|
| Line is longer than 80 characters. |
93
|
| Method 'getPlayerSettingsArray' is not designed for extension - needs to be abstract, final or empty. |
95
|
| Line is longer than 80 characters. |
99
|
| Line is longer than 80 characters. |
106
|
| Line is longer than 80 characters. |
108
|
| Method 'getParticipantIDs' is not designed for extension - needs to be abstract, final or empty. |
110
|
| Line is longer than 80 characters. |
125
|
| Line is longer than 80 characters. |
128
|
| Method 'getParticipantSettingsArray' is not designed for extension - needs to be abstract, final or empty. |
131
|
| Line is longer than 80 characters. |
132
|
| Line is longer than 80 characters. |
135
|
| Method 'getParticipantsAmount' is not designed for extension - needs to be abstract, final or empty. |
150
|
| Method 'getConnectionsAmount' is not designed for extension - needs to be abstract, final or empty. |
159
|
| Method 'containsPlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
163
|
| Missing a Javadoc comment. |
163
|
| Parameter playerID should be final. |
163
|
| Expected an @return tag. |
174
|
| Line is longer than 80 characters. |
174
|
| Method 'getUniqueNickname' is not designed for extension - needs to be abstract, final or empty. |
174
|
| Parameter nickname should be final. |
174
|
| Expected @param tag for 'nickname'. |
174
|
| Parameter ignorablePlayerID should be final. |
174
|
| Expected @param tag for 'ignorablePlayerID'. |
174
|
| Line is longer than 80 characters. |
177
|
| Line is longer than 80 characters. |
185
|
| Line is longer than 80 characters. |
195
|
| Missing a Javadoc comment. |
195
|
| Parameter nickname should be final. |
195
|
| Parameter ignorablePlayerID should be final. |
195
|
| Line is longer than 80 characters. |
203
|
| Method 'addPlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
215
|
| Parameter playerSettings should be final. |
215
|
| Expected @param tag for 'playerSettings'. |
215
|
| Method 'updatePlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
227
|
| Parameter updatedPlayerSettings should be final. |
227
|
| Expected @param tag for 'updatedPlayerSettings'. |
227
|
| Line is longer than 80 characters. |
229
|
| Line is longer than 80 characters. |
230
|
| Line is longer than 80 characters. |
233
|
| Expected an @return tag. |
245
|
| Method 'removePlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
245
|
| Parameter playerID should be final. |
245
|
| Expected @param tag for 'playerID'. |
245
|
net/sourceforge/simplegamenet/specs/to/Version.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
6
|
| Line is longer than 80 characters. |
7
|
| Missing a Javadoc comment. |
16
|
| Line is longer than 80 characters. |
19
|
| Line is longer than 80 characters. |
20
|
| Parameter level0Value should be final. |
24
|
| Parameter level0Value should be final. |
35
|
| Parameter level1Value should be final. |
35
|
| Parameter level0Value should be final. |
48
|
| Parameter level1Value should be final. |
48
|
| Parameter level2Value should be final. |
48
|
| '3' is a magic number. |
49
|
| Line is longer than 80 characters. |
56
|
| Line is longer than 80 characters. |
58
|
| Parameter levelValues should be final. |
60
|
| 'levelValues' hides a field. |
60
|
| Line is longer than 80 characters. |
69
|
| Line is longer than 80 characters. |
70
|
| Line is longer than 80 characters. |
73
|
| Line is longer than 80 characters. |
74
|
| Line is longer than 80 characters. |
75
|
| Definition of 'equals()' without corresponding definition of 'hashCode()'. |
80
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
80
|
| Parameter object should be final. |
80
|
| Line is longer than 80 characters. |
85
|
| Line is longer than 80 characters. |
91
|
| Line is longer than 80 characters. |
97
|
| Line is longer than 80 characters. |
107
|
| Line is longer than 80 characters. |
110
|
| Line is longer than 80 characters. |
111
|
| Line is longer than 80 characters. |
112
|
| Line is longer than 80 characters. |
115
|
| Line is longer than 80 characters. |
116
|
| Line is longer than 80 characters. |
117
|
| Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. |
119
|
| Parameter object should be final. |
119
|
| Line is longer than 80 characters. |
124
|
| Line is longer than 80 characters. |
132
|
| Line is longer than 80 characters. |
140
|
| Line is longer than 80 characters. |
152
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
157
|
| Line is longer than 80 characters. |
158
|
net/sourceforge/simplegamenet/specs/to/package.html
Error | Line |
| Missing package documentation file. | 0 |
net/sourceforge/simplegamenet/specs/tools/ColorIcon.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
3
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
4
|
| Missing a Javadoc comment. |
6
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
12
|
| Parameter color should be final. |
12
|
| 'color' hides a field. |
12
|
| '20' is a magic number. |
13
|
| '16' is a magic number. |
13
|
| Missing a Javadoc comment. |
16
|
| Parameter color should be final. |
16
|
| 'color' hides a field. |
16
|
| Parameter iconWidth should be final. |
16
|
| 'iconWidth' hides a field. |
16
|
| Parameter iconHeight should be final. |
16
|
| 'iconHeight' hides a field. |
16
|
| Method 'getIconHeight' is not designed for extension - needs to be abstract, final or empty. |
27
|
| Method 'getIconWidth' is not designed for extension - needs to be abstract, final or empty. |
36
|
| Line is longer than 80 characters. |
41
|
| Line is longer than 80 characters. |
42
|
| Method 'paintIcon' is not designed for extension - needs to be abstract, final or empty. |
44
|
| Parameter c should be final. |
44
|
| Expected @param tag for 'c'. |
44
|
| Parameter g should be final. |
44
|
| Expected @param tag for 'g'. |
44
|
| Parameter x should be final. |
44
|
| Expected @param tag for 'x'. |
44
|
| Parameter y should be final. |
44
|
| Expected @param tag for 'y'. |
44
|
| Method 'getColor' is not designed for extension - needs to be abstract, final or empty. |
53
|
| Missing a Javadoc comment. |
53
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
57
|
| Missing a Javadoc comment. |
57
|
net/sourceforge/simplegamenet/specs/tools/ColoredPlayerSettings.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
3
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
19
|
| Line is longer than 80 characters. |
21
|
| Missing a Javadoc comment. |
21
|
| Parameter engine should be final. |
21
|
| Parameter playerID should be final. |
21
|
| Parameter playerType should be final. |
21
|
| Parameter nickname should be final. |
22
|
| Parameter playingState should be final. |
22
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
23
|
| Line is longer than 80 characters. |
24
|
| Line is longer than 80 characters. |
27
|
| Missing a Javadoc comment. |
27
|
| Parameter engine should be final. |
27
|
| Parameter playerID should be final. |
27
|
| Parameter playerType should be final. |
27
|
| Line is longer than 80 characters. |
28
|
| Parameter nickname should be final. |
28
|
| Parameter playingState should be final. |
28
|
| Parameter colorsIndex should be final. |
28
|
| 'colorsIndex' hides a field. |
28
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
29
|
| Line is longer than 80 characters. |
30
|
| Line is longer than 80 characters. |
34
|
| Missing a Javadoc comment. |
34
|
| Parameter engine should be final. |
34
|
| Parameter playerID should be final. |
34
|
| Parameter playerType should be final. |
34
|
| Line is longer than 80 characters. |
35
|
| Parameter nickname should be final. |
35
|
| Parameter playingState should be final. |
35
|
| Parameter colors should be final. |
35
|
| 'colors' hides a field. |
35
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
36
|
| Line is longer than 80 characters. |
37
|
| Line is longer than 80 characters. |
40
|
| Missing a Javadoc comment. |
40
|
| Parameter engine should be final. |
40
|
| Parameter playerID should be final. |
40
|
| Parameter playerType should be final. |
40
|
| Line is longer than 80 characters. |
41
|
| Parameter nickname should be final. |
41
|
| Parameter playingState should be final. |
41
|
| Parameter colors should be final. |
41
|
| 'colors' hides a field. |
41
|
| Parameter defaultColorsIndex should be final. |
42
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
43
|
| Line is longer than 80 characters. |
48
|
| Missing a Javadoc comment. |
48
|
| More than 7 parameters. |
48
|
| Parameter engine should be final. |
48
|
| Parameter playerID should be final. |
48
|
| Parameter playerType should be final. |
48
|
| Line is longer than 80 characters. |
49
|
| Parameter nickname should be final. |
49
|
| Parameter playingState should be final. |
49
|
| Parameter colors should be final. |
49
|
| 'colors' hides a field. |
49
|
| Line is longer than 80 characters. |
50
|
| Parameter defaultColorsIndex should be final. |
50
|
| Parameter uniqueColorIndex should be final. |
50
|
| 'uniqueColorIndex' hides a field. |
50
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
51
|
| Line is longer than 80 characters. |
54
|
| Line is longer than 80 characters. |
55
|
| Line is longer than 80 characters. |
67
|
| Line is longer than 80 characters. |
75
|
| Method 'createPlayerSettingsPanel' is not designed for extension - needs to be abstract, final or empty. |
92
|
| Missing a Javadoc comment. |
92
|
| Line is longer than 80 characters. |
93
|
| Line is longer than 80 characters. |
97
|
| Method 'createChangedPlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
97
|
| Missing a Javadoc comment. |
97
|
| Parameter playerSettingsPanel should be final. |
97
|
| Line is longer than 80 characters. |
100
|
| Line is longer than 80 characters. |
112
|
| Method 'isChangePlayerSettingsAllowed' is not designed for extension - needs to be abstract, final or empty. |
112
|
| Missing a Javadoc comment. |
112
|
| Parameter changedPlayerSettings should be final. |
112
|
| Line is longer than 80 characters. |
113
|
| Line is longer than 80 characters. |
117
|
| Method 'getColorsIndex' is not designed for extension - needs to be abstract, final or empty. |
131
|
| Missing a Javadoc comment. |
131
|
| Method 'setColorsIndex' is not designed for extension - needs to be abstract, final or empty. |
138
|
| Missing a Javadoc comment. |
138
|
| Parameter colorsIndex should be final. |
138
|
| 'colorsIndex' hides a field. |
138
|
| Method 'getColor' is not designed for extension - needs to be abstract, final or empty. |
142
|
| Missing a Javadoc comment. |
142
|
net/sourceforge/simplegamenet/specs/tools/ColoredPlayerSettingsPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
3
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
6
|
| Line is longer than 80 characters. |
9
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
19
|
| Missing a Javadoc comment. |
20
|
| Line is longer than 80 characters. |
22
|
| Missing a Javadoc comment. |
22
|
| Parameter nickname should be final. |
22
|
| Parameter playingState should be final. |
22
|
| Parameter colors should be final. |
22
|
| Parameter defaultColorsIndex should be final. |
23
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
24
|
| Line is longer than 80 characters. |
26
|
| Line is longer than 80 characters. |
27
|
| '10' is a magic number. |
32
|
| '10' is a magic number. |
37
|
| '10' is a magic number. |
39
|
| '3' is a magic number. |
46
|
| '3' is a magic number. |
47
|
| '3' is a magic number. |
57
|
| '3' is a magic number. |
57
|
| '5' is a magic number. |
58
|
| switch without "default" clause. |
61
|
| '3' is a magic number. |
70
|
| '5' is a magic number. |
70
|
| Method 'areSettingsAcceptable' is not designed for extension - needs to be abstract, final or empty. |
73
|
| Missing a Javadoc comment. |
73
|
| Method 'setEnabled' is not designed for extension - needs to be abstract, final or empty. |
94
|
| Missing a Javadoc comment. |
94
|
| Parameter enabled should be final. |
94
|
| Method 'getNickname' is not designed for extension - needs to be abstract, final or empty. |
101
|
| Missing a Javadoc comment. |
101
|
| Method 'getPlayingState' is not designed for extension - needs to be abstract, final or empty. |
105
|
| Missing a Javadoc comment. |
105
|
| switch without "default" clause. |
106
|
| Method 'getColorsIndex' is not designed for extension - needs to be abstract, final or empty. |
115
|
| Missing a Javadoc comment. |
115
|
| Method 'getColor' is not designed for extension - needs to be abstract, final or empty. |
122
|
| Missing a Javadoc comment. |
122
|
| Method 'actionPerformed' is not designed for extension - needs to be abstract, final or empty. |
132
|
| Parameter actionEvent should be final. |
132
|
| Expected @param tag for 'actionEvent'. |
132
|
| switch without "default" clause. |
134
|
net/sourceforge/simplegamenet/specs/tools/MultiPlayerGameSettings.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
7
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
19
|
| '8' is a magic number. |
20
|
| '8' is a magic number. |
20
|
| '16' is a magic number. |
20
|
| Line is longer than 80 characters. |
23
|
| Missing a Javadoc comment. |
23
|
| Parameter maximumParticipantsAmount should be final. |
23
|
| 'maximumParticipantsAmount' hides a field. |
23
|
| Parameter maximumConnectionsAmount should be final. |
23
|
| 'maximumConnectionsAmount' hides a field. |
23
|
| Missing a Javadoc comment. |
28
|
| Parameter defaultMaximumParticipantsAmount should be final. |
28
|
| Parameter minimumMaximumParticipantsAmount should be final. |
29
|
| 'minimumMaximumParticipantsAmount' hides a field. |
29
|
| Parameter maximumMaximumParticipantsAmount should be final. |
30
|
| 'maximumMaximumParticipantsAmount' hides a field. |
30
|
| Parameter defaultMaximumConnectionsAmount should be final. |
31
|
| Parameter minimumMaximumConnectionsAmount should be final. |
32
|
| 'minimumMaximumConnectionsAmount' hides a field. |
32
|
| Parameter maximumMaximumConnectionsAmount should be final. |
33
|
| 'maximumMaximumConnectionsAmount' hides a field. |
33
|
| Line is longer than 80 characters. |
36
|
| Line is longer than 80 characters. |
38
|
| Missing a Javadoc comment. |
41
|
| Parameter minimumParticipantsAmount should be final. |
41
|
| 'minimumParticipantsAmount' hides a field. |
41
|
| Parameter defaultMaximumParticipantsAmount should be final. |
42
|
| Parameter minimumMaximumParticipantsAmount should be final. |
43
|
| 'minimumMaximumParticipantsAmount' hides a field. |
43
|
| Parameter maximumMaximumParticipantsAmount should be final. |
44
|
| 'maximumMaximumParticipantsAmount' hides a field. |
44
|
| Parameter defaultMaximumConnectionsAmount should be final. |
45
|
| Parameter minimumMaximumConnectionsAmount should be final. |
46
|
| 'minimumMaximumConnectionsAmount' hides a field. |
46
|
| Parameter maximumMaximumConnectionsAmount should be final. |
47
|
| 'maximumMaximumConnectionsAmount' hides a field. |
47
|
| Line is longer than 80 characters. |
50
|
| Line is longer than 80 characters. |
51
|
| Method 'createGameSettingsPanel' is not designed for extension - needs to be abstract, final or empty. |
57
|
| Missing a Javadoc comment. |
57
|
| Line is longer than 80 characters. |
66
|
| Method 'createChangedGameSettings' is not designed for extension - needs to be abstract, final or empty. |
66
|
| Missing a Javadoc comment. |
66
|
| Parameter gameSettingsPanel should be final. |
66
|
| Line is longer than 80 characters. |
71
|
| Line is longer than 80 characters. |
73
|
| Line is longer than 80 characters. |
76
|
| Method 'isChangeGameSettingsAllowed' is not designed for extension - needs to be abstract, final or empty. |
76
|
| Missing a Javadoc comment. |
76
|
| Parameter changedGameSettings should be final. |
76
|
| Line is longer than 80 characters. |
77
|
| Conditional logic can be removed. |
79
|
| Method 'isCreateDefaultPlayerSettingsAllowed' is not designed for extension - needs to be abstract, final or empty. |
89
|
| Missing a Javadoc comment. |
89
|
| Parameter playerType should be final. |
89
|
| Line is longer than 80 characters. |
97
|
| Method 'createDefaultPlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
97
|
| Missing a Javadoc comment. |
97
|
| Parameter playerID should be final. |
97
|
| Parameter playerType should be final. |
97
|
| Parameter nickname should be final. |
98
|
| Avoid inline conditionals. |
99
|
| Line is longer than 80 characters. |
105
|
| Line is longer than 80 characters. |
109
|
| Method 'isChangePlayerSettingsAllowed' is not designed for extension - needs to be abstract, final or empty. |
109
|
| Missing a Javadoc comment. |
109
|
| Parameter currentPlayerSettings should be final. |
109
|
| Line is longer than 80 characters. |
110
|
| Parameter changedPlayerSettings should be final. |
110
|
| Conditional logic can be removed. |
111
|
| Line is longer than 80 characters. |
112
|
| Method 'isStartGameAllowed' is not designed for extension - needs to be abstract, final or empty. |
121
|
| Missing a Javadoc comment. |
121
|
| Method 'getMinimumParticipantsAmount' is not designed for extension - needs to be abstract, final or empty. |
129
|
| Missing a Javadoc comment. |
129
|
| Method 'setMinimumParticipantsAmount' is not designed for extension - needs to be abstract, final or empty. |
133
|
| Missing a Javadoc comment. |
133
|
| Parameter minimumParticipantsAmount should be final. |
133
|
| 'minimumParticipantsAmount' hides a field. |
133
|
| Method 'getMaximumParticipantsAmount' is not designed for extension - needs to be abstract, final or empty. |
137
|
| Missing a Javadoc comment. |
137
|
| Method 'setMaximumParticipantsAmount' is not designed for extension - needs to be abstract, final or empty. |
141
|
| Missing a Javadoc comment. |
141
|
| Parameter maximumParticipantsAmount should be final. |
141
|
| 'maximumParticipantsAmount' hides a field. |
141
|
| Method 'getMaximumConnectionsAmount' is not designed for extension - needs to be abstract, final or empty. |
145
|
| Missing a Javadoc comment. |
145
|
| Method 'setMaximumConnectionsAmount' is not designed for extension - needs to be abstract, final or empty. |
149
|
| Missing a Javadoc comment. |
149
|
| Parameter maximumConnectionsAmount should be final. |
149
|
| 'maximumConnectionsAmount' hides a field. |
149
|
| Method 'getMinimumMaximumParticipantsAmount' is not designed for extension - needs to be abstract, final or empty. |
153
|
| Missing a Javadoc comment. |
153
|
| Line is longer than 80 characters. |
157
|
| Method 'setMinimumMaximumParticipantsAmount' is not designed for extension - needs to be abstract, final or empty. |
157
|
| Missing a Javadoc comment. |
157
|
| Parameter minimumMaximumParticipantsAmount should be final. |
157
|
| 'minimumMaximumParticipantsAmount' hides a field. |
157
|
| Line is longer than 80 characters. |
158
|
| Method 'getMaximumMaximumParticipantsAmount' is not designed for extension - needs to be abstract, final or empty. |
161
|
| Missing a Javadoc comment. |
161
|
| Line is longer than 80 characters. |
165
|
| Method 'setMaximumMaximumParticipantsAmount' is not designed for extension - needs to be abstract, final or empty. |
165
|
| Missing a Javadoc comment. |
165
|
| Parameter maximumMaximumParticipantsAmount should be final. |
165
|
| 'maximumMaximumParticipantsAmount' hides a field. |
165
|
| Line is longer than 80 characters. |
166
|
| Method 'getMinimumMaximumConnectionsAmount' is not designed for extension - needs to be abstract, final or empty. |
169
|
| Missing a Javadoc comment. |
169
|
| Line is longer than 80 characters. |
173
|
| Method 'setMinimumMaximumConnectionsAmount' is not designed for extension - needs to be abstract, final or empty. |
173
|
| Missing a Javadoc comment. |
173
|
| Parameter minimumMaximumConnectionsAmount should be final. |
173
|
| 'minimumMaximumConnectionsAmount' hides a field. |
173
|
| Method 'getMaximumMaximumConnectionsAmount' is not designed for extension - needs to be abstract, final or empty. |
177
|
| Missing a Javadoc comment. |
177
|
| Line is longer than 80 characters. |
181
|
| Method 'setMaximumMaximumConnectionsAmount' is not designed for extension - needs to be abstract, final or empty. |
181
|
| Missing a Javadoc comment. |
181
|
| Parameter maximumMaximumConnectionsAmount should be final. |
181
|
| 'maximumMaximumConnectionsAmount' hides a field. |
181
|
net/sourceforge/simplegamenet/specs/tools/MultiPlayerGameSettingsPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
5
|
| Line is longer than 80 characters. |
7
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
18
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
18
|
| '8' is a magic number. |
19
|
| '8' is a magic number. |
19
|
| '16' is a magic number. |
19
|
| Missing a Javadoc comment. |
22
|
| Parameter defaultMaximumParticipantsAmount should be final. |
22
|
| Parameter defaultMaximumConnectionsAmount should be final. |
23
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
24
|
| Line is longer than 80 characters. |
25
|
| Line is longer than 80 characters. |
26
|
| Missing a Javadoc comment. |
29
|
| Parameter defaultMaximumParticipantsAmount should be final. |
29
|
| Parameter minimumMaximumParticipantsAmount should be final. |
30
|
| Parameter maximumMaximumParticipantsAmount should be final. |
31
|
| Parameter defaultMaximumConnectionsAmount should be final. |
32
|
| Parameter minimumMaximumConnectionsAmount should be final. |
33
|
| Parameter maximumMaximumConnectionsAmount should be final. |
34
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
35
|
| Line is longer than 80 characters. |
38
|
| Line is longer than 80 characters. |
41
|
| Line is longer than 80 characters. |
42
|
| Line is longer than 80 characters. |
46
|
| Line is longer than 80 characters. |
47
|
| Line is longer than 80 characters. |
51
|
| Line is longer than 80 characters. |
52
|
| Line is longer than 80 characters. |
53
|
| '10' is a magic number. |
58
|
| '10' is a magic number. |
62
|
| Line is longer than 80 characters. |
67
|
| Line is longer than 80 characters. |
69
|
| '3' is a magic number. |
91
|
| '3' is a magic number. |
92
|
| Method 'actionPerformed' is not designed for extension - needs to be abstract, final or empty. |
98
|
| Parameter actionEvent should be final. |
98
|
| Expected @param tag for 'actionEvent'. |
98
|
| Line is longer than 80 characters. |
100
|
| Line is longer than 80 characters. |
101
|
| Line is longer than 80 characters. |
106
|
| Line is longer than 80 characters. |
107
|
| Line is longer than 80 characters. |
108
|
| Method 'getMaximumParticipantsAmount' is not designed for extension - needs to be abstract, final or empty. |
116
|
| Missing a Javadoc comment. |
116
|
| Line is longer than 80 characters. |
117
|
| Method 'getMaximumConnectionsAmount' is not designed for extension - needs to be abstract, final or empty. |
120
|
| Missing a Javadoc comment. |
120
|
| Line is longer than 80 characters. |
121
|
| Method 'setEnabled' is not designed for extension - needs to be abstract, final or empty. |
124
|
| Missing a Javadoc comment. |
124
|
| Parameter enabled should be final. |
124
|
net/sourceforge/simplegamenet/specs/tools/StandardPlayerSettings.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
7
|
| Line is longer than 80 characters. |
9
|
| Missing a Javadoc comment. |
9
|
| Parameter engine should be final. |
9
|
| Parameter playerID should be final. |
9
|
| Parameter playerType should be final. |
9
|
| Parameter nickname should be final. |
10
|
| Parameter playingState should be final. |
10
|
| Method 'createPlayerSettingsPanel' is not designed for extension - needs to be abstract, final or empty. |
14
|
| Missing a Javadoc comment. |
14
|
| Line is longer than 80 characters. |
15
|
| Line is longer than 80 characters. |
18
|
| Method 'createChangedPlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
18
|
| Missing a Javadoc comment. |
18
|
| Parameter playerSettingsPanel should be final. |
18
|
| Line is longer than 80 characters. |
21
|
net/sourceforge/simplegamenet/specs/tools/StandardPlayerSettingsPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
3
|
| Line is longer than 80 characters. |
6
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
16
|
| Parameter nickname should be final. |
16
|
| Parameter playingState should be final. |
16
|
| '10' is a magic number. |
20
|
| '10' is a magic number. |
25
|
| '3' is a magic number. |
32
|
| '3' is a magic number. |
33
|
| switch without "default" clause. |
36
|
| '3' is a magic number. |
44
|
| '3' is a magic number. |
44
|
| Method 'areSettingsAcceptable' is not designed for extension - needs to be abstract, final or empty. |
47
|
| Missing a Javadoc comment. |
47
|
| Method 'setEnabled' is not designed for extension - needs to be abstract, final or empty. |
68
|
| Missing a Javadoc comment. |
68
|
| Parameter enabled should be final. |
68
|
| Method 'getNickname' is not designed for extension - needs to be abstract, final or empty. |
74
|
| Missing a Javadoc comment. |
74
|
| Method 'getPlayingState' is not designed for extension - needs to be abstract, final or empty. |
78
|
| Missing a Javadoc comment. |
78
|
| switch without "default" clause. |
79
|
net/sourceforge/simplegamenet/specs/tools/TwoPlayerGameSettings.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
7
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
14
|
| '8' is a magic number. |
15
|
| '8' is a magic number. |
15
|
| Missing a Javadoc comment. |
18
|
| Parameter defaultMaximumConnectionsAmount should be final. |
18
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
19
|
| Line is longer than 80 characters. |
20
|
| Missing a Javadoc comment. |
23
|
| Parameter defaultMaximumConnectionsAmount should be final. |
23
|
| Parameter minimumMaximumConnectionsAmount should be final. |
24
|
| 'minimumMaximumConnectionsAmount' hides a field. |
24
|
| Parameter maximumMaximumConnectionsAmount should be final. |
25
|
| 'maximumMaximumConnectionsAmount' hides a field. |
25
|
| Method 'createGameSettingsPanel' is not designed for extension - needs to be abstract, final or empty. |
31
|
| Missing a Javadoc comment. |
31
|
| Line is longer than 80 characters. |
37
|
| Method 'createChangedGameSettings' is not designed for extension - needs to be abstract, final or empty. |
37
|
| Missing a Javadoc comment. |
37
|
| Parameter gameSettingsPanel should be final. |
37
|
| Line is longer than 80 characters. |
40
|
| Line is longer than 80 characters. |
41
|
| Line is longer than 80 characters. |
44
|
| Method 'isChangeGameSettingsAllowed' is not designed for extension - needs to be abstract, final or empty. |
44
|
| Missing a Javadoc comment. |
44
|
| Parameter changedGameSettings should be final. |
44
|
| Line is longer than 80 characters. |
45
|
| Conditional logic can be removed. |
47
|
| Method 'isCreateDefaultPlayerSettingsAllowed' is not designed for extension - needs to be abstract, final or empty. |
55
|
| Missing a Javadoc comment. |
55
|
| Parameter playerType should be final. |
55
|
| Line is longer than 80 characters. |
63
|
| Method 'createDefaultPlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
63
|
| Missing a Javadoc comment. |
63
|
| Parameter playerID should be final. |
63
|
| Parameter playerType should be final. |
63
|
| Parameter nickname should be final. |
64
|
| Avoid inline conditionals. |
65
|
| Line is longer than 80 characters. |
70
|
| Line is longer than 80 characters. |
74
|
| Method 'isChangePlayerSettingsAllowed' is not designed for extension - needs to be abstract, final or empty. |
74
|
| Missing a Javadoc comment. |
74
|
| Parameter currentPlayerSettings should be final. |
74
|
| Line is longer than 80 characters. |
75
|
| Parameter changedPlayerSettings should be final. |
75
|
| Conditional logic can be removed. |
76
|
| Line is longer than 80 characters. |
77
|
| Method 'isStartGameAllowed' is not designed for extension - needs to be abstract, final or empty. |
85
|
| Missing a Javadoc comment. |
85
|
| Method 'getMaximumConnectionsAmount' is not designed for extension - needs to be abstract, final or empty. |
92
|
| Missing a Javadoc comment. |
92
|
| Method 'setMaximumConnectionsAmount' is not designed for extension - needs to be abstract, final or empty. |
96
|
| Missing a Javadoc comment. |
96
|
| Parameter maximumConnectionsAmount should be final. |
96
|
| 'maximumConnectionsAmount' hides a field. |
96
|
| Method 'getMinimumMaximumConnectionsAmount' is not designed for extension - needs to be abstract, final or empty. |
100
|
| Missing a Javadoc comment. |
100
|
| Line is longer than 80 characters. |
104
|
| Method 'setMinimumMaximumConnectionsAmount' is not designed for extension - needs to be abstract, final or empty. |
104
|
| Missing a Javadoc comment. |
104
|
| Parameter minimumMaximumConnectionsAmount should be final. |
104
|
| 'minimumMaximumConnectionsAmount' hides a field. |
104
|
| Method 'getMaximumMaximumConnectionsAmount' is not designed for extension - needs to be abstract, final or empty. |
108
|
| Missing a Javadoc comment. |
108
|
| Line is longer than 80 characters. |
112
|
| Method 'setMaximumMaximumConnectionsAmount' is not designed for extension - needs to be abstract, final or empty. |
112
|
| Missing a Javadoc comment. |
112
|
| Parameter maximumMaximumConnectionsAmount should be final. |
112
|
| 'maximumMaximumConnectionsAmount' hides a field. |
112
|
net/sourceforge/simplegamenet/specs/tools/TwoPlayerGameSettingsPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
3
|
| Line is longer than 80 characters. |
5
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
13
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
13
|
| '8' is a magic number. |
14
|
| Missing a Javadoc comment. |
17
|
| Parameter defaultMaximumConnectionsAmount should be final. |
17
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
18
|
| Line is longer than 80 characters. |
19
|
| Missing a Javadoc comment. |
23
|
| Parameter defaultMaximumConnectionsAmount should be final. |
23
|
| Parameter minimumMaximumConnectionsAmount should be final. |
24
|
| Parameter maximumMaximumConnectionsAmount should be final. |
25
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
26
|
| '10' is a magic number. |
29
|
| Line is longer than 80 characters. |
36
|
| Line is longer than 80 characters. |
38
|
| Method 'getMaximumConnectionsAmount' is not designed for extension - needs to be abstract, final or empty. |
50
|
| Missing a Javadoc comment. |
50
|
| Line is longer than 80 characters. |
51
|
| Method 'setEnabled' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Missing a Javadoc comment. |
54
|
| Parameter enabled should be final. |
54
|
net/sourceforge/simplegamenet/specs/tools/package.html
Error | Line |
| Missing package documentation file. | 0 |