Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
Files | Infos | Warnings | Errors |
104 | 0 | 0 | 2178 |
Files
net/sourceforge/simplegamenet/framework/GameFactoryManager.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
16
|
| First sentence should end with a period. |
21
|
| Class GameFactoryManager should be declared as final. |
24
|
| Missing a Javadoc comment. |
26
|
| Missing a Javadoc comment. |
28
|
| Missing a Javadoc comment. |
32
|
| Parameter gameFactoriesList should be final. |
32
|
| Line is longer than 80 characters. |
33
|
| Missing a Javadoc comment. |
37
|
| Line is longer than 80 characters. |
48
|
| Line is longer than 80 characters. |
49
|
| Line is longer than 80 characters. |
52
|
| Missing a Javadoc comment. |
61
|
| Line is longer than 80 characters. |
63
|
| Line is longer than 80 characters. |
65
|
| Line is longer than 80 characters. |
71
|
| Missing a Javadoc comment. |
71
|
| Parameter files should be final. |
71
|
| Parameter path should be final. |
71
|
| Line is longer than 80 characters. |
84
|
| Missing a Javadoc comment. |
84
|
| Parameter files should be final. |
84
|
| Parameter gamesClassLoader should be final. |
84
|
| Parameter pathFile should be final. |
85
|
| Line is longer than 80 characters. |
97
|
| Line is longer than 80 characters. |
101
|
| Line is longer than 80 characters. |
111
|
| Line is longer than 80 characters. |
116
|
| Line is longer than 80 characters. |
119
|
| Missing a Javadoc comment. |
142
|
| Missing a Javadoc comment. |
143
|
| Line is longer than 80 characters. |
145
|
| Missing a Javadoc comment. |
145
|
| Parameter gamesClassLoader should be final. |
145
|
| 'gamesClassLoader' hides a field. |
145
|
| Parameter gameFactoriesList should be final. |
145
|
| 'gameFactoriesList' hides a field. |
145
|
| Missing a Javadoc comment. |
150
|
| Missing a Javadoc comment. |
154
|
| Line is longer than 80 characters. |
155
|
| Missing a Javadoc comment. |
158
|
| Parameter gameIdentification should be final. |
158
|
| Line is longer than 80 characters. |
162
|
| Missing a Javadoc comment. |
169
|
| Missing a Javadoc comment. |
171
|
| Parameter pathname should be final. |
171
|
net/sourceforge/simplegamenet/framework/gui/AboutDialog.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
3
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
6
|
| Line is longer than 80 characters. |
8
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
15
|
| Parameter simpleGameNetFrame should be final. |
15
|
| '10' is a magic number. |
20
|
| '10' is a magic number. |
22
|
| '10' is a magic number. |
24
|
| '10' is a magic number. |
25
|
| '10' is a magic number. |
27
|
| '10' is a magic number. |
29
|
| Line is longer than 80 characters. |
32
|
| '10' is a magic number. |
32
|
| Line is longer than 80 characters. |
35
|
| '10' is a magic number. |
35
|
| Line is longer than 80 characters. |
37
|
| '10' is a magic number. |
37
|
| Line is longer than 80 characters. |
39
|
| '10' is a magic number. |
39
|
| '3' is a magic number. |
45
|
| '3' is a magic number. |
47
|
| '3' is a magic number. |
51
|
| '3' is a magic number. |
51
|
| '5' is a magic number. |
53
|
| '3' is a magic number. |
59
|
| '5' is a magic number. |
59
|
| Line is longer than 80 characters. |
62
|
| '5' is a magic number. |
62
|
| Line is longer than 80 characters. |
66
|
| '3' is a magic number. |
66
|
| '5' is a magic number. |
66
|
| Line is longer than 80 characters. |
67
|
| '10' is a magic number. |
70
|
| '7' is a magic number. |
72
|
| '3' is a magic number. |
72
|
| Line is longer than 80 characters. |
74
|
| '9' is a magic number. |
74
|
| '3' is a magic number. |
75
|
| '3' is a magic number. |
75
|
| '9' is a magic number. |
75
|
| Method 'actionPerformed' is not designed for extension - needs to be abstract, final or empty. |
83
|
| Missing a Javadoc comment. |
83
|
| Parameter actionEvent should be final. |
83
|
net/sourceforge/simplegamenet/framework/gui/ChatClientPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
5
|
| Line is longer than 80 characters. |
10
|
| Line is longer than 80 characters. |
14
|
| Line is longer than 80 characters. |
19
|
| Missing a Javadoc comment. |
23
|
| Missing a Javadoc comment. |
25
|
| Missing a Javadoc comment. |
26
|
| Missing a Javadoc comment. |
27
|
| '50' is a magic number. |
27
|
| Missing a Javadoc comment. |
28
|
| Missing a Javadoc comment. |
30
|
| Parameter chatLogDocument should be final. |
30
|
| '50' is a magic number. |
32
|
| '10' is a magic number. |
33
|
| '10' is a magic number. |
36
|
| Parameter e should be final. |
46
|
| Parameter e should be final. |
49
|
| Parameter e should be final. |
52
|
| Line is longer than 80 characters. |
56
|
| '3' is a magic number. |
59
|
| Line is longer than 80 characters. |
62
|
| Method 'gameJoined' is not designed for extension - needs to be abstract, final or empty. |
68
|
| Missing a Javadoc comment. |
68
|
| Parameter clientGUIFacade should be final. |
68
|
| 'clientGUIFacade' hides a field. |
68
|
| Method 'joinedGameQuit' is not designed for extension - needs to be abstract, final or empty. |
73
|
| Missing a Javadoc comment. |
73
|
| Method 'setEnabled' is not designed for extension - needs to be abstract, final or empty. |
78
|
| Missing a Javadoc comment. |
78
|
| Parameter enabled should be final. |
78
|
| Method 'actionPerformed' is not designed for extension - needs to be abstract, final or empty. |
83
|
| Missing a Javadoc comment. |
83
|
| Parameter actionEvent should be final. |
83
|
| '4' is a magic number. |
89
|
| '7' is a magic number. |
92
|
| Line is longer than 80 characters. |
101
|
net/sourceforge/simplegamenet/framework/gui/ChatTabPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
3
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
6
|
| Line is longer than 80 characters. |
12
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
22
|
| Missing a Javadoc comment. |
24
|
| Missing a Javadoc comment. |
25
|
| Missing a Javadoc comment. |
27
|
| Missing a Javadoc comment. |
28
|
| Missing a Javadoc comment. |
32
|
| Missing a Javadoc comment. |
33
|
| Missing a Javadoc comment. |
35
|
| Missing a Javadoc comment. |
36
|
| Missing a Javadoc comment. |
38
|
| '10' is a magic number. |
40
|
| '10' is a magic number. |
42
|
| '10' is a magic number. |
43
|
| '10' is a magic number. |
45
|
| '10' is a magic number. |
51
|
| '10' is a magic number. |
53
|
| '10' is a magic number. |
55
|
| '3' is a magic number. |
60
|
| Line is longer than 80 characters. |
68
|
| '10' is a magic number. |
74
|
| '0.5' is a magic number. |
75
|
| '0.5' is a magic number. |
76
|
| Method 'getChatLogDocument' is not designed for extension - needs to be abstract, final or empty. |
80
|
| Missing a Javadoc comment. |
80
|
| Method 'gameJoined' is not designed for extension - needs to be abstract, final or empty. |
84
|
| Missing a Javadoc comment. |
84
|
| Parameter clientGUIFacade should be final. |
84
|
| 'clientGUIFacade' hides a field. |
84
|
| Parameter playerSettingsPanel should be final. |
85
|
| Line is longer than 80 characters. |
86
|
| Parameter playerSettingsMap should be final. |
86
|
| Parameter clientIsHost should be final. |
86
|
| Line is longer than 80 characters. |
88
|
| Line is longer than 80 characters. |
90
|
| Method 'joinedGameQuit' is not designed for extension - needs to be abstract, final or empty. |
99
|
| Missing a Javadoc comment. |
99
|
| Method 'gameStarted' is not designed for extension - needs to be abstract, final or empty. |
112
|
| Missing a Javadoc comment. |
112
|
| Parameter clientIsHost should be final. |
112
|
| Method 'gameEnding' is not designed for extension - needs to be abstract, final or empty. |
118
|
| Missing a Javadoc comment. |
118
|
| Parameter clientIsHost should be final. |
118
|
| Method 'gameEnded' is not designed for extension - needs to be abstract, final or empty. |
124
|
| Missing a Javadoc comment. |
124
|
| Parameter clientIsHost should be final. |
124
|
| Line is longer than 80 characters. |
130
|
| Method 'playerSettingsUpdated' is not designed for extension - needs to be abstract, final or empty. |
130
|
| Missing a Javadoc comment. |
130
|
| Parameter updatedPlayerSettings should be final. |
130
|
| Parameter thisClient should be final. |
130
|
| Method 'actionPerformed' is not designed for extension - needs to be abstract, final or empty. |
139
|
| Missing a Javadoc comment. |
139
|
| Parameter actionEvent should be final. |
139
|
net/sourceforge/simplegamenet/framework/gui/ClientGUIFacade.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
3
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
6
|
| Missing a Javadoc comment. |
24
|
| Missing a Javadoc comment. |
26
|
| Variable 'simpleGameNetFrame' must be private and have accessor methods. |
26
|
| Missing a Javadoc comment. |
28
|
| Variable 'statusTabPanel' must be private and have accessor methods. |
28
|
| Missing a Javadoc comment. |
29
|
| Variable 'chatTabPanel' must be private and have accessor methods. |
29
|
| Missing a Javadoc comment. |
30
|
| Variable 'gameTabPanel' must be private and have accessor methods. |
30
|
| Missing a Javadoc comment. |
31
|
| Variable 'gameSettingsTabPanel' must be private and have accessor methods. |
31
|
| Missing a Javadoc comment. |
33
|
| Variable 'chatLogDocument' must be private and have accessor methods. |
33
|
| Missing a Javadoc comment. |
34
|
| Variable 'logTextArea' must be private and have accessor methods. |
34
|
| Missing a Javadoc comment. |
36
|
| Missing a Javadoc comment. |
38
|
| Line is longer than 80 characters. |
40
|
| Missing a Javadoc comment. |
40
|
| Parameter simpleGameNetFrame should be final. |
40
|
| 'simpleGameNetFrame' hides a field. |
40
|
| Parameter statusTabPanel should be final. |
40
|
| 'statusTabPanel' hides a field. |
40
|
| Parameter chatTabPanel should be final. |
41
|
| 'chatTabPanel' hides a field. |
41
|
| Parameter gameTabPanel should be final. |
41
|
| 'gameTabPanel' hides a field. |
41
|
| Parameter gameSettingsTabPanel should be final. |
42
|
| 'gameSettingsTabPanel' hides a field. |
42
|
| Parameter logTextArea should be final. |
43
|
| 'logTextArea' hides a field. |
43
|
| Parameter clientIsHost should be final. |
43
|
| 'clientIsHost' hides a field. |
43
|
| Method 'joinGame' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Missing a Javadoc comment. |
54
|
| Parameter connectionConfig should be final. |
54
|
| Line is longer than 80 characters. |
57
|
| Line is longer than 80 characters. |
58
|
| Line is longer than 80 characters. |
61
|
| Line is longer than 80 characters. |
63
|
| Line is longer than 80 characters. |
64
|
| Line is longer than 80 characters. |
69
|
| Line is longer than 80 characters. |
73
|
| Line is longer than 80 characters. |
74
|
| '4' is a magic number. |
74
|
| Line is longer than 80 characters. |
76
|
| Method 'receiveChatMessage' is not designed for extension - needs to be abstract, final or empty. |
84
|
| Missing a Javadoc comment. |
84
|
| Parameter type should be final. |
84
|
| Parameter message should be final. |
84
|
| switch without "default" clause. |
85
|
| Method 'receiveChatMessage' is not designed for extension - needs to be abstract, final or empty. |
95
|
| Missing a Javadoc comment. |
95
|
| Parameter type should be final. |
95
|
| Parameter message should be final. |
95
|
| Parameter nickname should be final. |
95
|
| switch without "default" clause. |
96
|
| '3' is a magic number. |
101
|
| Line is longer than 80 characters. |
106
|
| Method 'sendChatMessage' is not designed for extension - needs to be abstract, final or empty. |
106
|
| Missing a Javadoc comment. |
106
|
| Parameter type should be final. |
106
|
| Parameter message should be final. |
106
|
| Redundant throws: 'IllegalStateException' is unchecked exception. |
106
|
| Method 'changeGameSettings' is not designed for extension - needs to be abstract, final or empty. |
110
|
| Missing a Javadoc comment. |
110
|
| Parameter gameSettingsPanel should be final. |
110
|
| Redundant throws: 'IllegalStateException' is unchecked exception. |
111
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
111
|
| Method 'gameSettingsUpdated' is not designed for extension - needs to be abstract, final or empty. |
116
|
| Missing a Javadoc comment. |
116
|
| Parameter outdatedGameSettings should be final. |
116
|
| Parameter updatedGameSettings should be final. |
117
|
| '5' is a magic number. |
122
|
| Line is longer than 80 characters. |
128
|
| Method 'playerAdded' is not designed for extension - needs to be abstract, final or empty. |
128
|
| Missing a Javadoc comment. |
128
|
| Parameter playerSettingsMap should be final. |
128
|
| Parameter playerSettings should be final. |
128
|
| '6' is a magic number. |
134
|
| Line is longer than 80 characters. |
136
|
| Method 'changePlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
140
|
| Missing a Javadoc comment. |
140
|
| Parameter playerSettingsPanel should be final. |
140
|
| Redundant throws: 'IllegalStateException' is unchecked exception. |
141
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
141
|
| Line is longer than 80 characters. |
142
|
| Method 'playerSettingsUpdated' is not designed for extension - needs to be abstract, final or empty. |
147
|
| Missing a Javadoc comment. |
147
|
| Parameter playerSettingsMap should be final. |
147
|
| Parameter outdatedPlayerSettings should be final. |
148
|
| Parameter updatedPlayerSettings should be final. |
149
|
| Line is longer than 80 characters. |
154
|
| Line is longer than 80 characters. |
159
|
| '6' is a magic number. |
160
|
| Line is longer than 80 characters. |
177
|
| Method 'removePlayer' is not designed for extension - needs to be abstract, final or empty. |
177
|
| Missing a Javadoc comment. |
177
|
| Parameter playerSettingsMap should be final. |
177
|
| Parameter playerSettings should be final. |
177
|
| Parameter removePlayerType should be final. |
178
|
| switch without "default" clause. |
184
|
| '6' is a magic number. |
186
|
| Line is longer than 80 characters. |
188
|
| Line is longer than 80 characters. |
192
|
| '6' is a magic number. |
193
|
| Line is longer than 80 characters. |
195
|
| Line is longer than 80 characters. |
200
|
| '6' is a magic number. |
200
|
| Line is longer than 80 characters. |
202
|
| Line is longer than 80 characters. |
206
|
| '6' is a magic number. |
206
|
| Line is longer than 80 characters. |
208
|
| Line is longer than 80 characters. |
212
|
| '6' is a magic number. |
212
|
| Line is longer than 80 characters. |
214
|
| Line is longer than 80 characters. |
219
|
| '6' is a magic number. |
220
|
| Method 'startGame' is not designed for extension - needs to be abstract, final or empty. |
229
|
| Missing a Javadoc comment. |
229
|
| Redundant throws: 'IllegalStateException' is unchecked exception. |
229
|
| Method 'gameStarted' is not designed for extension - needs to be abstract, final or empty. |
233
|
| Missing a Javadoc comment. |
233
|
| '7' is a magic number. |
237
|
| Method 'abortGame' is not designed for extension - needs to be abstract, final or empty. |
243
|
| Missing a Javadoc comment. |
243
|
| Redundant throws: 'IllegalStateException' is unchecked exception. |
243
|
| Method 'gameStopping' is not designed for extension - needs to be abstract, final or empty. |
247
|
| Missing a Javadoc comment. |
247
|
| Method 'gameAborting' is not designed for extension - needs to be abstract, final or empty. |
254
|
| Missing a Javadoc comment. |
254
|
| Method 'gameEnded' is not designed for extension - needs to be abstract, final or empty. |
261
|
| Missing a Javadoc comment. |
261
|
| '7' is a magic number. |
263
|
| Method 'leaveServer' is not designed for extension - needs to be abstract, final or empty. |
269
|
| Missing a Javadoc comment. |
269
|
| Method 'joinedGameQuit' is not designed for extension - needs to be abstract, final or empty. |
273
|
| Missing a Javadoc comment. |
273
|
| Parameter removePlayerType should be final. |
273
|
| switch without "default" clause. |
280
|
| '4' is a magic number. |
282
|
| Line is longer than 80 characters. |
288
|
| '4' is a magic number. |
288
|
| '4' is a magic number. |
294
|
| '4' is a magic number. |
300
|
| '4' is a magic number. |
306
|
| Line is longer than 80 characters. |
312
|
| '4' is a magic number. |
312
|
| Line is longer than 80 characters. |
314
|
| '4' is a magic number. |
318
|
| Missing a Javadoc comment. |
327
|
| Parameter message should be final. |
327
|
| Parameter styleIndex should be final. |
327
|
| switch without "default" clause. |
330
|
| '3' is a magic number. |
340
|
| '4' is a magic number. |
343
|
| '5' is a magic number. |
346
|
| Line is longer than 80 characters. |
347
|
| '0x80' is a magic number. |
347
|
| '6' is a magic number. |
349
|
| Line is longer than 80 characters. |
350
|
| '0x80' is a magic number. |
350
|
| '7' is a magic number. |
352
|
| Line is longer than 80 characters. |
357
|
| Method 'createChatClientPanel' is not designed for extension - needs to be abstract, final or empty. |
364
|
| Missing a Javadoc comment. |
364
|
net/sourceforge/simplegamenet/framework/gui/ConnectionConfig.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| First sentence should end with a period. |
18
|
| Line is longer than 80 characters. |
23
|
| Missing a Javadoc comment. |
23
|
| Missing a Javadoc comment. |
25
|
| Missing a Javadoc comment. |
26
|
| Missing a Javadoc comment. |
27
|
| Missing a Javadoc comment. |
28
|
| Missing a Javadoc comment. |
30
|
| Line is longer than 80 characters. |
36
|
| Missing a Javadoc comment. |
49
|
| Parameter connectionConfig should be final. |
49
|
| Line is longer than 80 characters. |
54
|
| Missing a Javadoc comment. |
64
|
| Line is longer than 80 characters. |
65
|
| Avoid inline conditionals. |
66
|
| ':' should be on a new line. |
66
|
| Missing a Javadoc comment. |
71
|
| Missing a Javadoc comment. |
73
|
| Missing a Javadoc comment. |
74
|
| Missing a Javadoc comment. |
75
|
| Missing a Javadoc comment. |
77
|
| Missing a Javadoc comment. |
79
|
| Method 'getNickname' is not designed for extension - needs to be abstract, final or empty. |
87
|
| Missing a Javadoc comment. |
87
|
| Method 'setNickname' is not designed for extension - needs to be abstract, final or empty. |
91
|
| Missing a Javadoc comment. |
91
|
| Parameter nickname should be final. |
91
|
| 'nickname' hides a field. |
91
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
91
|
| Line is longer than 80 characters. |
97
|
| Method 'getHostAddress' is not designed for extension - needs to be abstract, final or empty. |
103
|
| Missing a Javadoc comment. |
103
|
| Method 'setHostAddress' is not designed for extension - needs to be abstract, final or empty. |
107
|
| Missing a Javadoc comment. |
107
|
| Parameter hostAddress should be final. |
107
|
| 'hostAddress' hides a field. |
107
|
| Method 'getPort' is not designed for extension - needs to be abstract, final or empty. |
111
|
| Missing a Javadoc comment. |
111
|
| Method 'setPort' is not designed for extension - needs to be abstract, final or empty. |
115
|
| Missing a Javadoc comment. |
115
|
| Parameter port should be final. |
115
|
| 'port' hides a field. |
115
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
115
|
| Line is longer than 80 characters. |
117
|
| Method 'isBadLanguageFiltered' is not designed for extension - needs to be abstract, final or empty. |
122
|
| Missing a Javadoc comment. |
122
|
| Method 'setBadLanguageFiltered' is not designed for extension - needs to be abstract, final or empty. |
126
|
| Missing a Javadoc comment. |
126
|
| Parameter badLanguageFiltered should be final. |
126
|
| 'badLanguageFiltered' hides a field. |
126
|
| Method 'getGameSettings' is not designed for extension - needs to be abstract, final or empty. |
130
|
| Missing a Javadoc comment. |
130
|
| Method 'setGameSettings' is not designed for extension - needs to be abstract, final or empty. |
134
|
| Missing a Javadoc comment. |
134
|
| Parameter gameSettings should be final. |
134
|
| 'gameSettings' hides a field. |
134
|
net/sourceforge/simplegamenet/framework/gui/ConnectionWizardDialog.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
3
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
7
|
| Line is longer than 80 characters. |
11
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
21
|
| Missing a Javadoc comment. |
22
|
| Missing a Javadoc comment. |
23
|
| Missing a Javadoc comment. |
24
|
| Missing a Javadoc comment. |
26
|
| Name 'stepTitles' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
26
|
| Missing a Javadoc comment. |
31
|
| Name 'stepStrings' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
31
|
| Missing a Javadoc comment. |
35
|
| Name 'stepEnabledStates' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
35
|
| Missing a Javadoc comment. |
43
|
| Missing a Javadoc comment. |
44
|
| Missing a Javadoc comment. |
46
|
| Missing a Javadoc comment. |
47
|
| Missing a Javadoc comment. |
48
|
| Missing a Javadoc comment. |
49
|
| '4' is a magic number. |
49
|
| Missing a Javadoc comment. |
55
|
| Missing a Javadoc comment. |
56
|
| Missing a Javadoc comment. |
57
|
| Missing a Javadoc comment. |
58
|
| Missing a Javadoc comment. |
59
|
| Missing a Javadoc comment. |
61
|
| Missing a Javadoc comment. |
63
|
| Missing a Javadoc comment. |
65
|
| Missing a Javadoc comment. |
67
|
| Parameter simpleGameNetFrame should be final. |
67
|
| 'simpleGameNetFrame' hides a field. |
67
|
| Missing a Javadoc comment. |
71
|
| Parameter simpleGameNetFrame should be final. |
71
|
| 'simpleGameNetFrame' hides a field. |
71
|
| Parameter connectionType should be final. |
72
|
| '10' is a magic number. |
79
|
| '10' is a magic number. |
81
|
| '10' is a magic number. |
82
|
| '10' is a magic number. |
84
|
| '10' is a magic number. |
86
|
| '10' is a magic number. |
88
|
| Line is longer than 80 characters. |
97
|
| Line is longer than 80 characters. |
102
|
| '3' is a magic number. |
103
|
| Line is longer than 80 characters. |
106
|
| '10' is a magic number. |
106
|
| Line is longer than 80 characters. |
108
|
| '10' is a magic number. |
108
|
| Line is longer than 80 characters. |
110
|
| '10' is a magic number. |
110
|
| '3' is a magic number. |
117
|
| '5' is a magic number. |
123
|
| switch without "default" clause. |
124
|
| Method 'actionPerformed' is not designed for extension - needs to be abstract, final or empty. |
148
|
| Parameter actionEvent should be final. |
148
|
| Expected @param tag for 'actionEvent'. |
148
|
| '3' is a magic number. |
155
|
| Missing a Javadoc comment. |
160
|
| switch without "default" clause. |
161
|
| Missing a Javadoc comment. |
177
|
| switch without "default" clause. |
178
|
| switch without "default" clause. |
183
|
| Line is longer than 80 characters. |
202
|
| Line is longer than 80 characters. |
203
|
| Missing a Javadoc comment. |
209
|
| switch without "default" clause. |
210
|
| Line is longer than 80 characters. |
225
|
| Line is longer than 80 characters. |
229
|
| Line is longer than 80 characters. |
230
|
| Line is longer than 80 characters. |
236
|
| Line is longer than 80 characters. |
240
|
| Line is longer than 80 characters. |
242
|
| Line is longer than 80 characters. |
246
|
| Line is longer than 80 characters. |
247
|
| Line is longer than 80 characters. |
253
|
| Line is longer than 80 characters. |
259
|
| Line is longer than 80 characters. |
263
|
| Line is longer than 80 characters. |
264
|
| Line is longer than 80 characters. |
269
|
| Line is longer than 80 characters. |
283
|
| Line is longer than 80 characters. |
284
|
| Missing a Javadoc comment. |
304
|
| Parameter state should be final. |
304
|
| 'state' hides a field. |
304
|
| Method 'getConnectionConfig' is not designed for extension - needs to be abstract, final or empty. |
314
|
| Missing a Javadoc comment. |
314
|
net/sourceforge/simplegamenet/framework/gui/GameChoicePanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
3
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
6
|
| Line is longer than 80 characters. |
8
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
19
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
21
|
| Missing a Javadoc comment. |
22
|
| Missing a Javadoc comment. |
24
|
| Missing a Javadoc comment. |
26
|
| Parameter connectionWizardDialog should be final. |
26
|
| 'connectionWizardDialog' hides a field. |
26
|
| Parameter gameFactories should be final. |
27
|
| 'gameFactories' hides a field. |
27
|
| '10' is a magic number. |
32
|
| '10' is a magic number. |
34
|
| '10' is a magic number. |
36
|
| '10' is a magic number. |
38
|
| '10' is a magic number. |
40
|
| '10' is a magic number. |
42
|
| Line is longer than 80 characters. |
51
|
| '5' is a magic number. |
51
|
| Line is longer than 80 characters. |
52
|
| Line is longer than 80 characters. |
53
|
| '5' is a magic number. |
53
|
| Line is longer than 80 characters. |
54
|
| Line is longer than 80 characters. |
56
|
| '5' is a magic number. |
56
|
| Line is longer than 80 characters. |
58
|
| Line is longer than 80 characters. |
63
|
| '300' is a magic number. |
66
|
| '150' is a magic number. |
66
|
| Line is longer than 80 characters. |
69
|
| Line is longer than 80 characters. |
70
|
| '3' is a magic number. |
74
|
| '5' is a magic number. |
75
|
| '3' is a magic number. |
75
|
| '4' is a magic number. |
76
|
| '3' is a magic number. |
77
|
| '4' is a magic number. |
77
|
| '6' is a magic number. |
78
|
| '3' is a magic number. |
79
|
| '6' is a magic number. |
79
|
| Method 'areSettingsAcceptable' is not designed for extension - needs to be abstract, final or empty. |
82
|
| Missing a Javadoc comment. |
82
|
| Method 'getGameFactoriesIndex' is not designed for extension - needs to be abstract, final or empty. |
86
|
| Missing a Javadoc comment. |
86
|
| Method 'actionPerformed' is not designed for extension - needs to be abstract, final or empty. |
93
|
| Parameter actionEvent should be final. |
93
|
| Expected @param tag for 'actionEvent'. |
93
|
| Line is longer than 80 characters. |
99
|
net/sourceforge/simplegamenet/framework/gui/GameSettingsChoicePanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
3
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
4
|
| Line is longer than 80 characters. |
9
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
19
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
21
|
| Missing a Javadoc comment. |
23
|
| Missing a Javadoc comment. |
25
|
| Missing a Javadoc comment. |
27
|
| Parameter connectionWizardDialog should be final. |
27
|
| 'connectionWizardDialog' hides a field. |
27
|
| Parameter gameFactories should be final. |
28
|
| 'gameFactories' hides a field. |
28
|
| '5' is a magic number. |
34
|
| '5' is a magic number. |
36
|
| '5' is a magic number. |
39
|
| Line is longer than 80 characters. |
50
|
| Method 'areSettingsAcceptable' is not designed for extension - needs to be abstract, final or empty. |
56
|
| Missing a Javadoc comment. |
56
|
| Line is longer than 80 characters. |
58
|
| Method 'setGameFactoriesIndex' is not designed for extension - needs to be abstract, final or empty. |
66
|
| Missing a Javadoc comment. |
66
|
| Parameter gameFactoriesIndex should be final. |
66
|
| 'gameFactoriesIndex' hides a field. |
66
|
net/sourceforge/simplegamenet/framework/gui/GameSettingsTabPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
5
|
| Line is longer than 80 characters. |
7
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
17
|
| '10' is a magic number. |
19
|
| '10' is a magic number. |
21
|
| '10' is a magic number. |
22
|
| '10' is a magic number. |
24
|
| '10' is a magic number. |
26
|
| Line is longer than 80 characters. |
31
|
| '3' is a magic number. |
31
|
| '3' is a magic number. |
31
|
| Line is longer than 80 characters. |
35
|
| Method 'gameJoined' is not designed for extension - needs to be abstract, final or empty. |
35
|
| Missing a Javadoc comment. |
35
|
| Parameter serverGUIFacade should be final. |
35
|
| Parameter gameSettingsPanel should be final. |
35
|
| 'gameSettingsPanel' hides a field. |
35
|
| Parameter clientIsHost should be final. |
36
|
| Method 'joinedGameQuit' is not designed for extension - needs to be abstract, final or empty. |
45
|
| Missing a Javadoc comment. |
45
|
| Line is longer than 80 characters. |
53
|
| Method 'gameSettingsUpdated' is not designed for extension - needs to be abstract, final or empty. |
53
|
| Missing a Javadoc comment. |
53
|
| Parameter updatedGameSettingsPanel should be final. |
53
|
| Method 'actionPerformed' is not designed for extension - needs to be abstract, final or empty. |
63
|
| Parameter actionEvent should be final. |
63
|
| Expected @param tag for 'actionEvent'. |
63
|
| Line is longer than 80 characters. |
64
|
| Line is longer than 80 characters. |
75
|
net/sourceforge/simplegamenet/framework/gui/GameTabPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
3
|
| Line is longer than 80 characters. |
5
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
12
|
| '10' is a magic number. |
14
|
| '10' is a magic number. |
16
|
| '10' is a magic number. |
17
|
| '10' is a magic number. |
19
|
| Method 'gameJoined' is not designed for extension - needs to be abstract, final or empty. |
23
|
| Missing a Javadoc comment. |
23
|
| Parameter gamePanel should be final. |
23
|
| 'gamePanel' hides a field. |
23
|
| Method 'joinedGameQuit' is not designed for extension - needs to be abstract, final or empty. |
29
|
| Missing a Javadoc comment. |
29
|
net/sourceforge/simplegamenet/framework/gui/HostSettingsPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
3
|
| Line is longer than 80 characters. |
5
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
20
|
| Parameter connectionWizardDialog should be final. |
20
|
| 'connectionWizardDialog' hides a field. |
20
|
| '10' is a magic number. |
25
|
| '10' is a magic number. |
27
|
| '20' is a magic number. |
29
|
| '10' is a magic number. |
30
|
| '10' is a magic number. |
33
|
| '10' is a magic number. |
35
|
| Line is longer than 80 characters. |
42
|
| '3' is a magic number. |
49
|
| '3' is a magic number. |
49
|
| '3' is a magic number. |
50
|
| '4' is a magic number. |
51
|
| '3' is a magic number. |
51
|
| Line is longer than 80 characters. |
52
|
| '5' is a magic number. |
52
|
| '4' is a magic number. |
52
|
| '3' is a magic number. |
52
|
| '5' is a magic number. |
52
|
| Missing a Javadoc comment. |
55
|
| Line is longer than 80 characters. |
59
|
| Line is longer than 80 characters. |
64
|
| Line is longer than 80 characters. |
66
|
| Line is longer than 80 characters. |
70
|
net/sourceforge/simplegamenet/framework/gui/JoinHostGamePanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
3
|
| Line is longer than 80 characters. |
4
|
| Redundant import from the same package - net.sourceforge.simplegamenet.framework.gui.ConnectionWizardDialog. |
6
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
19
|
| Parameter connectionWizardDialog should be final. |
19
|
| 'connectionWizardDialog' hides a field. |
19
|
| '10' is a magic number. |
23
|
| '10' is a magic number. |
25
|
| '10' is a magic number. |
28
|
| Line is longer than 80 characters. |
36
|
| Missing a Javadoc comment. |
40
|
| Missing a Javadoc comment. |
49
|
| Missing a Javadoc comment. |
53
|
| Parameter connectionType should be final. |
53
|
| 'connectionType' hides a field. |
53
|
| switch without "default" clause. |
54
|
net/sourceforge/simplegamenet/framework/gui/JoinSettingsPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
5
|
| Line is longer than 80 characters. |
7
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
19
|
| Missing a Javadoc comment. |
21
|
| Missing a Javadoc comment. |
23
|
| Parameter connectionWizardDialog should be final. |
23
|
| 'connectionWizardDialog' hides a field. |
23
|
| '10' is a magic number. |
28
|
| '10' is a magic number. |
30
|
| '20' is a magic number. |
32
|
| '10' is a magic number. |
33
|
| '10' is a magic number. |
36
|
| '10' is a magic number. |
38
|
| Line is longer than 80 characters. |
45
|
| '15' is a magic number. |
45
|
| Line is longer than 80 characters. |
46
|
| '3' is a magic number. |
51
|
| '3' is a magic number. |
51
|
| '3' is a magic number. |
52
|
| '3' is a magic number. |
53
|
| '3' is a magic number. |
53
|
| '3' is a magic number. |
53
|
| '3' is a magic number. |
53
|
| '5' is a magic number. |
54
|
| '4' is a magic number. |
55
|
| '5' is a magic number. |
55
|
| Missing a Javadoc comment. |
58
|
| Line is longer than 80 characters. |
62
|
| Line is longer than 80 characters. |
78
|
| Line is longer than 80 characters. |
80
|
net/sourceforge/simplegamenet/framework/gui/OptionsDialog.java
Error | Line |
| File does not end with a newline. |
0
|
net/sourceforge/simplegamenet/framework/gui/OptionsDialog.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
3
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
6
|
| Line is longer than 80 characters. |
7
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
21
|
| Missing a Javadoc comment. |
22
|
| Missing a Javadoc comment. |
24
|
| Missing a Javadoc comment. |
26
|
| Parameter simpleGameNetFrame should be final. |
26
|
| 'simpleGameNetFrame' hides a field. |
26
|
| '10' is a magic number. |
31
|
| Line is longer than 80 characters. |
33
|
| '10' is a magic number. |
34
|
| Line is longer than 80 characters. |
35
|
| '10' is a magic number. |
36
|
| Line is longer than 80 characters. |
37
|
| '10' is a magic number. |
38
|
| '10' is a magic number. |
39
|
| Line is longer than 80 characters. |
40
|
| '10' is a magic number. |
41
|
| Line is longer than 80 characters. |
42
|
| '10' is a magic number. |
43
|
| Line is longer than 80 characters. |
46
|
| '10' is a magic number. |
46
|
| Line is longer than 80 characters. |
47
|
| Line is longer than 80 characters. |
48
|
| '10' is a magic number. |
48
|
| Line is longer than 80 characters. |
49
|
| Line is longer than 80 characters. |
50
|
| '10' is a magic number. |
50
|
| Line is longer than 80 characters. |
51
|
| '10' is a magic number. |
51
|
| Line is longer than 80 characters. |
52
|
| Line is longer than 80 characters. |
53
|
| '10' is a magic number. |
53
|
| Line is longer than 80 characters. |
64
|
| Line is longer than 80 characters. |
71
|
| '3' is a magic number. |
71
|
| Line is longer than 80 characters. |
73
|
| '6' is a magic number. |
73
|
| '3' is a magic number. |
80
|
| '4' is a magic number. |
81
|
| '3' is a magic number. |
81
|
| '6' is a magic number. |
82
|
| '3' is a magic number. |
82
|
| Method 'actionPerformed' is not designed for extension - needs to be abstract, final or empty. |
93
|
| Missing a Javadoc comment. |
93
|
| Parameter actionEvent should be final. |
93
|
| Missing a Javadoc comment. |
104
|
| Line is longer than 80 characters. |
106
|
net/sourceforge/simplegamenet/framework/gui/PlayersListPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
3
|
| Missing a Javadoc comment. |
6
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
17
|
| Parameter playerSettingsMap should be final. |
17
|
| Missing a Javadoc comment. |
21
|
| Parameter listType should be final. |
21
|
| 'listType' hides a field. |
21
|
| Parameter playerSettingsMap should be final. |
21
|
net/sourceforge/simplegamenet/framework/gui/PlayersTabPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
5
|
| Line is longer than 80 characters. |
8
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
19
|
| Missing a Javadoc comment. |
21
|
| '10' is a magic number. |
23
|
| '10' is a magic number. |
25
|
| '10' is a magic number. |
26
|
| '10' is a magic number. |
28
|
| '10' is a magic number. |
30
|
| Line is longer than 80 characters. |
36
|
| '5' is a magic number. |
36
|
| Line is longer than 80 characters. |
37
|
| Line is longer than 80 characters. |
38
|
| '5' is a magic number. |
38
|
| Line is longer than 80 characters. |
39
|
| Line is longer than 80 characters. |
40
|
| Line is longer than 80 characters. |
41
|
| '10' is a magic number. |
41
|
| Line is longer than 80 characters. |
42
|
| Line is longer than 80 characters. |
43
|
| '5' is a magic number. |
43
|
| '3' is a magic number. |
50
|
| '3' is a magic number. |
50
|
| Line is longer than 80 characters. |
51
|
| '3' is a magic number. |
52
|
| Missing a Javadoc comment. |
55
|
| Parameter clientGUIFacade should be final. |
55
|
| 'clientGUIFacade' hides a field. |
55
|
| Parameter playerSettingsPanel should be final. |
56
|
| 'playerSettingsPanel' hides a field. |
56
|
| Parameter playerSettingsMap should be final. |
57
|
| Missing a Javadoc comment. |
68
|
| Line is longer than 80 characters. |
77
|
| Missing a Javadoc comment. |
77
|
| Parameter updatedPlayerSettingsPanel should be final. |
77
|
| Parameter actionEvent should be final. |
88
|
| Expected @param tag for 'actionEvent'. |
88
|
| Line is longer than 80 characters. |
89
|
| Line is longer than 80 characters. |
100
|
net/sourceforge/simplegamenet/framework/gui/ServerGUIFacade.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
5
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
15
|
| Variable 'simpleGameNetFrame' must be private and have accessor methods. |
15
|
| Missing a Javadoc comment. |
17
|
| Variable 'logTextArea' must be private and have accessor methods. |
17
|
| Missing a Javadoc comment. |
19
|
| Line is longer than 80 characters. |
21
|
| Missing a Javadoc comment. |
21
|
| Parameter simpleGameNetFrame should be final. |
21
|
| 'simpleGameNetFrame' hides a field. |
21
|
| Parameter logTextArea should be final. |
21
|
| 'logTextArea' hides a field. |
21
|
| Line is longer than 80 characters. |
26
|
| Method 'hostGame' is not designed for extension - needs to be abstract, final or empty. |
26
|
| Missing a Javadoc comment. |
26
|
| Parameter connectionConfig should be final. |
26
|
| Parameter gameFactory should be final. |
26
|
| Line is longer than 80 characters. |
28
|
| Line is longer than 80 characters. |
33
|
| Method 'gameSettingsUpdated' is not designed for extension - needs to be abstract, final or empty. |
37
|
| Missing a Javadoc comment. |
37
|
| Parameter gameSettings should be final. |
37
|
| Line is longer than 80 characters. |
41
|
| Method 'playerAdded' is not designed for extension - needs to be abstract, final or empty. |
41
|
| Missing a Javadoc comment. |
41
|
| Parameter playerSettingsMap should be final. |
41
|
| Parameter playerSettings should be final. |
41
|
| Line is longer than 80 characters. |
42
|
| Method 'playerSettingsUpdated' is not designed for extension - needs to be abstract, final or empty. |
45
|
| Missing a Javadoc comment. |
45
|
| Parameter playerSettingsMap should be final. |
45
|
| Parameter updatedPlayerSettings should be final. |
46
|
| Line is longer than 80 characters. |
52
|
| Method 'removePlayer' is not designed for extension - needs to be abstract, final or empty. |
52
|
| Missing a Javadoc comment. |
52
|
| Parameter playerSettingsMap should be final. |
52
|
| Parameter playerSettings should be final. |
52
|
| Parameter removePlayerType should be final. |
53
|
| switch without "default" clause. |
54
|
| Line is longer than 80 characters. |
56
|
| Line is longer than 80 characters. |
59
|
| Line is longer than 80 characters. |
63
|
| Line is longer than 80 characters. |
66
|
| Line is longer than 80 characters. |
69
|
| Method 'gameStarted' is not designed for extension - needs to be abstract, final or empty. |
79
|
| Missing a Javadoc comment. |
79
|
| Method 'gameStopping' is not designed for extension - needs to be abstract, final or empty. |
83
|
| Missing a Javadoc comment. |
83
|
| Method 'gameAborting' is not designed for extension - needs to be abstract, final or empty. |
87
|
| Missing a Javadoc comment. |
87
|
| Method 'gameEnded' is not designed for extension - needs to be abstract, final or empty. |
91
|
| Missing a Javadoc comment. |
91
|
| Method 'closeServer' is not designed for extension - needs to be abstract, final or empty. |
95
|
| Missing a Javadoc comment. |
95
|
| Method 'hostedGameQuit' is not designed for extension - needs to be abstract, final or empty. |
99
|
| Missing a Javadoc comment. |
99
|
net/sourceforge/simplegamenet/framework/gui/SimpleGameNetFrame.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
3
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
10
|
| Line is longer than 80 characters. |
15
|
| Line is longer than 80 characters. |
19
|
| Line is longer than 80 characters. |
22
|
| Line is longer than 80 characters. |
23
|
| Class SimpleGameNetFrame should be declared as final. |
32
|
| Missing a Javadoc comment. |
34
|
| Missing a Javadoc comment. |
35
|
| Missing a Javadoc comment. |
36
|
| Missing a Javadoc comment. |
38
|
| Missing a Javadoc comment. |
48
|
| Missing a Javadoc comment. |
49
|
| Missing a Javadoc comment. |
50
|
| Missing a Javadoc comment. |
51
|
| Missing a Javadoc comment. |
52
|
| Missing a Javadoc comment. |
53
|
| Missing a Javadoc comment. |
54
|
| Missing a Javadoc comment. |
56
|
| Missing a Javadoc comment. |
62
|
| Missing a Javadoc comment. |
63
|
| Missing a Javadoc comment. |
64
|
| Line is longer than 80 characters. |
65
|
| Missing a Javadoc comment. |
65
|
| Missing a Javadoc comment. |
67
|
| Missing a Javadoc comment. |
69
|
| Missing a Javadoc comment. |
70
|
| Missing a Javadoc comment. |
72
|
| Missing a Javadoc comment. |
74
|
| Missing a Javadoc comment. |
84
|
| Parameter windowEvent should be final. |
91
|
| Parameter windowEvent should be final. |
95
|
| Missing a Javadoc comment. |
102
|
| Line is longer than 80 characters. |
103
|
| Parameter event should be final. |
105
|
| Line is longer than 80 characters. |
112
|
| Line is longer than 80 characters. |
114
|
| Parameter event should be final. |
116
|
| Line is longer than 80 characters. |
120
|
| Line is longer than 80 characters. |
121
|
| Parameter event should be final. |
125
|
| Parameter event should be final. |
137
|
| Line is longer than 80 characters. |
147
|
| Parameter event should be final. |
149
|
| Line is longer than 80 characters. |
150
|
| Line is longer than 80 characters. |
155
|
| Parameter event should be final. |
159
|
| Parameter event should be final. |
168
|
| Line is longer than 80 characters. |
169
|
| Missing a Javadoc comment. |
177
|
| Missing a Javadoc comment. |
198
|
| '10' is a magic number. |
201
|
| '10' is a magic number. |
203
|
| '10' is a magic number. |
204
|
| '10' is a magic number. |
206
|
| Line is longer than 80 characters. |
209
|
| Parameter changeEvent should be final. |
215
|
| switch without "default" clause. |
216
|
| '3' is a magic number. |
226
|
| Missing a Javadoc comment. |
235
|
| Parameter newAppState should be final. |
235
|
| Parameter statusTitle should be final. |
235
|
| '3' is a magic number. |
250
|
| Line is longer than 80 characters. |
256
|
| Missing a Javadoc comment. |
256
|
| Parameter connectionConfig should be final. |
256
|
| Parameter gameFactory should be final. |
256
|
| Line is longer than 80 characters. |
264
|
| Missing a Javadoc comment. |
271
|
| Parameter connectionConfig should be final. |
271
|
| Line is longer than 80 characters. |
276
|
| Missing a Javadoc comment. |
283
|
| switch without "default" clause. |
284
|
| Missing a Javadoc comment. |
294
|
| Missing a Javadoc comment. |
298
|
net/sourceforge/simplegamenet/framework/gui/StatusTabPanel.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
3
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
5
|
| Line is longer than 80 characters. |
8
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
13
|
| Name 'stateStrings' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
13
|
| Missing a Javadoc comment. |
21
|
| Missing a Javadoc comment. |
22
|
| Missing a Javadoc comment. |
23
|
| Missing a Javadoc comment. |
24
|
| Missing a Javadoc comment. |
25
|
| Missing a Javadoc comment. |
26
|
| Missing a Javadoc comment. |
28
|
| Missing a Javadoc comment. |
29
|
| Missing a Javadoc comment. |
30
|
| Missing a Javadoc comment. |
31
|
| Missing a Javadoc comment. |
32
|
| Missing a Javadoc comment. |
33
|
| Missing a Javadoc comment. |
34
|
| Missing a Javadoc comment. |
36
|
| Missing a Javadoc comment. |
37
|
| Line is longer than 80 characters. |
38
|
| Missing a Javadoc comment. |
38
|
| Missing a Javadoc comment. |
39
|
| Missing a Javadoc comment. |
42
|
| Missing a Javadoc comment. |
44
|
| '10' is a magic number. |
46
|
| '10' is a magic number. |
48
|
| '3.0' is a magic number. |
49
|
| '10' is a magic number. |
50
|
| '10' is a magic number. |
52
|
| '10' is a magic number. |
54
|
| '10' is a magic number. |
55
|
| '10' is a magic number. |
57
|
| '10' is a magic number. |
59
|
| '10' is a magic number. |
61
|
| Line is longer than 80 characters. |
62
|
| '10' is a magic number. |
63
|
| '10' is a magic number. |
65
|
| Line is longer than 80 characters. |
66
|
| '10' is a magic number. |
67
|
| '10' is a magic number. |
68
|
| '10' is a magic number. |
69
|
| '3' is a magic number. |
74
|
| '3' is a magic number. |
75
|
| '3' is a magic number. |
77
|
| '3' is a magic number. |
77
|
| '5' is a magic number. |
78
|
| '3' is a magic number. |
78
|
| '7' is a magic number. |
80
|
| '3' is a magic number. |
80
|
| '5' is a magic number. |
81
|
| '3' is a magic number. |
83
|
| '5' is a magic number. |
83
|
| Line is longer than 80 characters. |
85
|
| '5' is a magic number. |
85
|
| Line is longer than 80 characters. |
86
|
| Line is longer than 80 characters. |
87
|
| '5' is a magic number. |
87
|
| Line is longer than 80 characters. |
88
|
| Line is longer than 80 characters. |
89
|
| Line is longer than 80 characters. |
90
|
| '5' is a magic number. |
90
|
| Line is longer than 80 characters. |
95
|
| '400' is a magic number. |
98
|
| '150' is a magic number. |
98
|
| Line is longer than 80 characters. |
99
|
| '7' is a magic number. |
102
|
| '7' is a magic number. |
102
|
| '4' is a magic number. |
102
|
| '7' is a magic number. |
102
|
| '9' is a magic number. |
103
|
| '3' is a magic number. |
105
|
| '9' is a magic number. |
105
|
| '5' is a magic number. |
106
|
| '9' is a magic number. |
106
|
| '7' is a magic number. |
108
|
| '9' is a magic number. |
108
|
| '11' is a magic number. |
109
|
| '3' is a magic number. |
111
|
| '11' is a magic number. |
111
|
| '5' is a magic number. |
112
|
| '11' is a magic number. |
112
|
| '7' is a magic number. |
114
|
| '11' is a magic number. |
114
|
| '5' is a magic number. |
116
|
| Line is longer than 80 characters. |
117
|
| '5' is a magic number. |
118
|
| Line is longer than 80 characters. |
120
|
| '5' is a magic number. |
121
|
| '400' is a magic number. |
129
|
| '150' is a magic number. |
129
|
| '13' is a magic number. |
132
|
| '7' is a magic number. |
132
|
| '4' is a magic number. |
132
|
| '13' is a magic number. |
132
|
| Method 'getLogTextArea' is not designed for extension - needs to be abstract, final or empty. |
136
|
| Missing a Javadoc comment. |
136
|
| Line is longer than 80 characters. |
140
|
| Method 'gameJoined' is not designed for extension - needs to be abstract, final or empty. |
140
|
| Missing a Javadoc comment. |
140
|
| Parameter hostInetAddress should be final. |
140
|
| Parameter port should be final. |
140
|
| Parameter gameFactory should be final. |
140
|
| Line is longer than 80 characters. |
141
|
| Parameter playerSettingsMap should be final. |
141
|
| Parameter clientIsHost should be final. |
141
|
| Line is longer than 80 characters. |
142
|
| Avoid inline conditionals. |
142
|
| Method 'playerSettingsUpdated' is not designed for extension - needs to be abstract, final or empty. |
155
|
| Missing a Javadoc comment. |
155
|
| Parameter playerSettingsMap should be final. |
155
|
| Method 'joinedGameQuit' is not designed for extension - needs to be abstract, final or empty. |
162
|
| Missing a Javadoc comment. |
162
|
net/sourceforge/simplegamenet/framework/gui/package.html
Error | Line |
| Missing package documentation file. | 0 |
net/sourceforge/simplegamenet/framework/model/ChatMessage.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
6
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
13
|
| Name 'badLanguageList' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
13
|
| Line is longer than 80 characters. |
15
|
| Missing a Javadoc comment. |
22
|
| Parameter string should be final. |
22
|
| Missing a Javadoc comment. |
31
|
| Missing a Javadoc comment. |
32
|
| Missing a Javadoc comment. |
33
|
| Missing a Javadoc comment. |
35
|
| Parameter type should be final. |
35
|
| 'type' hides a field. |
35
|
| Parameter message should be final. |
35
|
| 'message' hides a field. |
35
|
| Missing a Javadoc comment. |
39
|
| Parameter type should be final. |
39
|
| 'type' hides a field. |
39
|
| Parameter message should be final. |
39
|
| 'message' hides a field. |
39
|
| Parameter playerID should be final. |
39
|
| 'playerID' hides a field. |
39
|
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. |
45
|
| Missing a Javadoc comment. |
45
|
| Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
49
|
| Missing a Javadoc comment. |
49
|
| Method 'setMessage' is not designed for extension - needs to be abstract, final or empty. |
53
|
| Missing a Javadoc comment. |
53
|
| Parameter message should be final. |
53
|
| 'message' hides a field. |
53
|
| Method 'getPlayerID' is not designed for extension - needs to be abstract, final or empty. |
57
|
| Missing a Javadoc comment. |
57
|
net/sourceforge/simplegamenet/framework/model/ChatServer.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
4
|
| Missing a Javadoc comment. |
6
|
| Missing a Javadoc comment. |
8
|
| Line is longer than 80 characters. |
10
|
| Missing a Javadoc comment. |
10
|
| Parameter serverEngine should be final. |
10
|
| 'serverEngine' hides a field. |
10
|
| Parameter badLanguageFiltered should be final. |
10
|
| 'badLanguageFiltered' hides a field. |
10
|
| Method 'filterNickname' is not designed for extension - needs to be abstract, final or empty. |
15
|
| Missing a Javadoc comment. |
15
|
| Parameter nickname should be final. |
15
|
| Method 'receiveChatMessage' is not designed for extension - needs to be abstract, final or empty. |
22
|
| Missing a Javadoc comment. |
22
|
| Parameter playerID should be final. |
22
|
| Parameter chatMessage should be final. |
22
|
| Line is longer than 80 characters. |
26
|
| Method 'appendSystemChatMessage' is not designed for extension - needs to be abstract, final or empty. |
32
|
| Missing a Javadoc comment. |
32
|
| Parameter playerID should be final. |
32
|
| Parameter message should be final. |
32
|
| Method 'appendSystemChatMessage' is not designed for extension - needs to be abstract, final or empty. |
37
|
| Missing a Javadoc comment. |
37
|
| Parameter message should be final. |
37
|
| Line is longer than 80 characters. |
38
|
| Method 'appendGameChatMessage' is not designed for extension - needs to be abstract, final or empty. |
41
|
| Missing a Javadoc comment. |
41
|
| Parameter playerID should be final. |
41
|
| Parameter message should be final. |
41
|
| Method 'appendGameChatMessage' is not designed for extension - needs to be abstract, final or empty. |
46
|
| Missing a Javadoc comment. |
46
|
| Parameter message should be final. |
46
|
| Line is longer than 80 characters. |
47
|
net/sourceforge/simplegamenet/framework/model/ClientEngineImpl.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
22
|
| Parameter clientGUIFacade should be final. |
22
|
| 'clientGUIFacade' hides a field. |
22
|
| Parameter clientConnectionData should be final. |
23
|
| Method 'receiveChatMessage' is not designed for extension - needs to be abstract, final or empty. |
44
|
| Missing a Javadoc comment. |
44
|
| Parameter chatMessage should be final. |
44
|
| switch without "default" clause. |
45
|
| Line is longer than 80 characters. |
55
|
| Line is longer than 80 characters. |
61
|
| Method 'sendChatMessage' is not designed for extension - needs to be abstract, final or empty. |
61
|
| Missing a Javadoc comment. |
61
|
| Parameter type should be final. |
61
|
| Parameter message should be final. |
61
|
| Redundant throws: 'IllegalStateException' is unchecked exception. |
61
|
| Method 'changeGameSettings' is not designed for extension - needs to be abstract, final or empty. |
70
|
| Missing a Javadoc comment. |
70
|
| Parameter changedGameSettings should be final. |
70
|
| Redundant throws: 'IllegalStateException' is unchecked exception. |
71
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
71
|
| Line is longer than 80 characters. |
77
|
| Method 'updateGameSettings' is not designed for extension - needs to be abstract, final or empty. |
83
|
| Missing a Javadoc comment. |
83
|
| Parameter updatedGameSettings should be final. |
83
|
| Line is longer than 80 characters. |
87
|
| Line is longer than 80 characters. |
88
|
| Method 'addPlayer' is not designed for extension - needs to be abstract, final or empty. |
91
|
| Missing a Javadoc comment. |
91
|
| Parameter playerSettings should be final. |
91
|
| Method 'changePlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
98
|
| Missing a Javadoc comment. |
98
|
| Parameter changedPlayerSettings should be final. |
98
|
| Redundant throws: 'IllegalStateException' is unchecked exception. |
99
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
99
|
| Line is longer than 80 characters. |
104
|
| Line is longer than 80 characters. |
108
|
| Line is longer than 80 characters. |
109
|
| Line is longer than 80 characters. |
110
|
| Method 'updatePlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
116
|
| Missing a Javadoc comment. |
116
|
| Parameter updatedPlayerSettings should be final. |
116
|
| Line is longer than 80 characters. |
118
|
| Line is longer than 80 characters. |
123
|
| Method 'removePlayer' is not designed for extension - needs to be abstract, final or empty. |
127
|
| Missing a Javadoc comment. |
127
|
| Parameter playerID should be final. |
127
|
| 'playerID' hides a field. |
127
|
| Parameter removePlayerType should be final. |
127
|
| Line is longer than 80 characters. |
128
|
| Line is longer than 80 characters. |
130
|
| Method 'startGame' is not designed for extension - needs to be abstract, final or empty. |
133
|
| Missing a Javadoc comment. |
133
|
| Redundant throws: 'IllegalStateException' is unchecked exception. |
133
|
| Method 'gameStarted' is not designed for extension - needs to be abstract, final or empty. |
141
|
| Missing a Javadoc comment. |
141
|
| Method 'receiveData' is not designed for extension - needs to be abstract, final or empty. |
147
|
| Missing a Javadoc comment. |
147
|
| Parameter data should be final. |
147
|
| Method 'sendData' is not designed for extension - needs to be abstract, final or empty. |
153
|
| Missing a Javadoc comment. |
153
|
| Parameter data should be final. |
153
|
| Method 'abortGame' is not designed for extension - needs to be abstract, final or empty. |
159
|
| Missing a Javadoc comment. |
159
|
| Redundant throws: 'IllegalStateException' is unchecked exception. |
159
|
| Method 'gameStopping' is not designed for extension - needs to be abstract, final or empty. |
167
|
| Missing a Javadoc comment. |
167
|
| Method 'gameAborting' is not designed for extension - needs to be abstract, final or empty. |
173
|
| Missing a Javadoc comment. |
173
|
| Method 'gameEnded' is not designed for extension - needs to be abstract, final or empty. |
179
|
| Missing a Javadoc comment. |
179
|
| Method 'leaveServer' is not designed for extension - needs to be abstract, final or empty. |
185
|
| Missing a Javadoc comment. |
185
|
| Method 'leaveProtocolViolatingServer' is not designed for extension - needs to be abstract, final or empty. |
189
|
| Missing a Javadoc comment. |
189
|
| Method 'joinedGameQuit' is not designed for extension - needs to be abstract, final or empty. |
193
|
| Missing a Javadoc comment. |
193
|
| Parameter removePlayerType should be final. |
193
|
| Method 'getGamePlayerClient' is not designed for extension - needs to be abstract, final or empty. |
198
|
| Missing a Javadoc comment. |
198
|
| Method 'getPlayerID' is not designed for extension - needs to be abstract, final or empty. |
202
|
| Missing a Javadoc comment. |
202
|
| Method 'getPlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
206
|
| Missing a Javadoc comment. |
206
|
net/sourceforge/simplegamenet/framework/model/EngineImpl.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
16
|
| Variable 'gameFactory' must be private and have accessor methods. |
16
|
| Missing a Javadoc comment. |
17
|
| Variable 'gameSettings' must be private and have accessor methods. |
17
|
| Missing a Javadoc comment. |
18
|
| Variable 'playerSettingsMap' must be private and have accessor methods. |
18
|
| Missing a Javadoc comment. |
20
|
| Variable 'gameState' must be private and have accessor methods. |
20
|
| Missing a Javadoc comment. |
22
|
| Parameter gameFactory should be final. |
22
|
| 'gameFactory' hides a field. |
22
|
| Parameter gameSettings should be final. |
22
|
| 'gameSettings' hides a field. |
22
|
| Parameter playerSettingsMap should be final. |
23
|
| 'playerSettingsMap' hides a field. |
23
|
| Method 'getGameFactory' is not designed for extension - needs to be abstract, final or empty. |
30
|
| Missing a Javadoc comment. |
30
|
| Method 'getGameSettings' is not designed for extension - needs to be abstract, final or empty. |
34
|
| Missing a Javadoc comment. |
34
|
| Method 'getPlayerSettingsMap' is not designed for extension - needs to be abstract, final or empty. |
38
|
| Missing a Javadoc comment. |
38
|
| Method 'isGamePlaying' is not designed for extension - needs to be abstract, final or empty. |
42
|
| Missing a Javadoc comment. |
42
|
net/sourceforge/simplegamenet/framework/model/ServerEngineImpl.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
21
|
| Missing a Javadoc comment. |
23
|
| Missing a Javadoc comment. |
25
|
| Parameter serverGUIFacade should be final. |
25
|
| 'serverGUIFacade' hides a field. |
25
|
| Parameter port should be final. |
25
|
| Line is longer than 80 characters. |
26
|
| Parameter badLanguageFiltered should be final. |
26
|
| Parameter gameFactory should be final. |
26
|
| Parameter gameSettings should be final. |
27
|
| Line is longer than 80 characters. |
44
|
| Method 'receiveChatMessage' is not designed for extension - needs to be abstract, final or empty. |
44
|
| Missing a Javadoc comment. |
44
|
| Parameter playerID should be final. |
44
|
| Parameter chatMessage should be final. |
44
|
| Method 'sendChatMessage' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Missing a Javadoc comment. |
54
|
| Parameter playerID should be final. |
54
|
| Parameter chatMessage should be final. |
54
|
| Method 'sendChatMessage' is not designed for extension - needs to be abstract, final or empty. |
58
|
| Missing a Javadoc comment. |
58
|
| Parameter chatMessage should be final. |
58
|
| Method 'appendGameChatMessage' is not designed for extension - needs to be abstract, final or empty. |
62
|
| Missing a Javadoc comment. |
62
|
| Parameter playerID should be final. |
62
|
| Parameter message should be final. |
62
|
| Method 'appendGameChatMessage' is not designed for extension - needs to be abstract, final or empty. |
69
|
| Missing a Javadoc comment. |
69
|
| Parameter message should be final. |
69
|
| Method 'changeGameSettings' is not designed for extension - needs to be abstract, final or empty. |
73
|
| Missing a Javadoc comment. |
73
|
| Parameter changedGameSettings should be final. |
73
|
| Redundant throws: 'IllegalStateException' is unchecked exception. |
74
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
74
|
| Line is longer than 80 characters. |
80
|
| Line is longer than 80 characters. |
85
|
| Method 'refreshGameSettings' is not designed for extension - needs to be abstract, final or empty. |
89
|
| Missing a Javadoc comment. |
89
|
| Method 'createPlayer' is not designed for extension - needs to be abstract, final or empty. |
94
|
| Missing a Javadoc comment. |
94
|
| Parameter playerType should be final. |
94
|
| Parameter nickname should be final. |
94
|
| Redundant throws: 'IllegalStateException' is unchecked exception. |
95
|
| Line is longer than 80 characters. |
102
|
| Method 'playerAdded' is not designed for extension - needs to be abstract, final or empty. |
109
|
| Missing a Javadoc comment. |
109
|
| Parameter playerID should be final. |
109
|
| Line is longer than 80 characters. |
110
|
| Method 'changePlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
115
|
| Missing a Javadoc comment. |
115
|
| Parameter changedPlayerSettings should be final. |
115
|
| Redundant throws: 'IllegalStateException' is unchecked exception. |
116
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
116
|
| Line is longer than 80 characters. |
123
|
| Line is longer than 80 characters. |
126
|
| Line is longer than 80 characters. |
128
|
| Line is longer than 80 characters. |
131
|
| Line is longer than 80 characters. |
139
|
| Line is longer than 80 characters. |
142
|
| Method 'refreshPlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
142
|
| Missing a Javadoc comment. |
142
|
| Parameter playerID should be final. |
142
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
142
|
| Line is longer than 80 characters. |
149
|
| Method 'kickPlayer' is not designed for extension - needs to be abstract, final or empty. |
152
|
| Missing a Javadoc comment. |
152
|
| Parameter playerID should be final. |
152
|
| Method 'banPlayer' is not designed for extension - needs to be abstract, final or empty. |
156
|
| Missing a Javadoc comment. |
156
|
| Parameter playerID should be final. |
156
|
| Method 'kickProtocolViolatingPlayer' is not designed for extension - needs to be abstract, final or empty. |
160
|
| Missing a Javadoc comment. |
160
|
| Parameter playerID should be final. |
160
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
161
|
| Method 'removePlayer' is not designed for extension - needs to be abstract, final or empty. |
165
|
| Missing a Javadoc comment. |
165
|
| Parameter playerID should be final. |
165
|
| Parameter removePlayerType should be final. |
165
|
| Line is longer than 80 characters. |
166
|
| Line is longer than 80 characters. |
168
|
| Method 'startGame' is not designed for extension - needs to be abstract, final or empty. |
171
|
| Missing a Javadoc comment. |
171
|
| Redundant throws: 'IllegalStateException' is unchecked exception. |
171
|
| Method 'receiveData' is not designed for extension - needs to be abstract, final or empty. |
181
|
| Missing a Javadoc comment. |
181
|
| Parameter playerID should be final. |
181
|
| Parameter data should be final. |
181
|
| Method 'sendData' is not designed for extension - needs to be abstract, final or empty. |
187
|
| Missing a Javadoc comment. |
187
|
| Parameter playerID should be final. |
187
|
| Parameter data should be final. |
187
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
188
|
| Method 'sendData' is not designed for extension - needs to be abstract, final or empty. |
194
|
| Missing a Javadoc comment. |
194
|
| Parameter data should be final. |
194
|
| Method 'stopGame' is not designed for extension - needs to be abstract, final or empty. |
200
|
| Missing a Javadoc comment. |
200
|
| Method 'abortGame' is not designed for extension - needs to be abstract, final or empty. |
208
|
| Missing a Javadoc comment. |
208
|
| Redundant throws: 'IllegalStateException' is unchecked exception. |
208
|
| Method 'gameEnded' is not designed for extension - needs to be abstract, final or empty. |
217
|
| Missing a Javadoc comment. |
217
|
| Method 'closeServerInServerThread' is not designed for extension - needs to be abstract, final or empty. |
222
|
| Missing a Javadoc comment. |
222
|
| Method 'hostedGameQuit' is not designed for extension - needs to be abstract, final or empty. |
226
|
| Missing a Javadoc comment. |
226
|
net/sourceforge/simplegamenet/framework/model/SimpleGameNetSettings.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Class SimpleGameNetSettings should be declared as final. |
6
|
| Missing a Javadoc comment. |
6
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
24
|
| Missing a Javadoc comment. |
26
|
| Line is longer than 80 characters. |
27
|
| Missing a Javadoc comment. |
37
|
| Missing a Javadoc comment. |
41
|
| Missing a Javadoc comment. |
45
|
| Missing a Javadoc comment. |
49
|
net/sourceforge/simplegamenet/framework/model/package.html
Error | Line |
| Missing package documentation file. | 0 |
net/sourceforge/simplegamenet/framework/package.html
Error | Line |
| Missing package documentation file. | 0 |
net/sourceforge/simplegamenet/framework/transport/ClientConnection.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
12
|
| Parameter clientModem should be final. |
12
|
| 'clientModem' hides a field. |
12
|
| Parameter socket should be final. |
12
|
| Parameter objectInputStream should be final. |
13
|
| Parameter objectOutputStream should be final. |
14
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
19
|
| Missing a Javadoc comment. |
19
|
| Method 'sendPacket' is not designed for extension - needs to be abstract, final or empty. |
39
|
| Missing a Javadoc comment. |
39
|
| Parameter packet should be final. |
39
|
net/sourceforge/simplegamenet/framework/transport/ClientConnectionData.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
15
|
| Line is longer than 80 characters. |
17
|
| Missing a Javadoc comment. |
17
|
| Parameter socket should be final. |
17
|
| 'socket' hides a field. |
17
|
| Parameter objectInputStream should be final. |
17
|
| 'objectInputStream' hides a field. |
17
|
| Line is longer than 80 characters. |
18
|
| Parameter objectOutputStream should be final. |
18
|
| 'objectOutputStream' hides a field. |
18
|
| Parameter loginData should be final. |
18
|
| 'loginData' hides a field. |
18
|
| Parameter gameFactory should be final. |
19
|
| 'gameFactory' hides a field. |
19
|
| Method 'getSocket' is not designed for extension - needs to be abstract, final or empty. |
27
|
| Missing a Javadoc comment. |
27
|
| Method 'setSocket' is not designed for extension - needs to be abstract, final or empty. |
31
|
| Missing a Javadoc comment. |
31
|
| Parameter socket should be final. |
31
|
| 'socket' hides a field. |
31
|
| Method 'getObjectInputStream' is not designed for extension - needs to be abstract, final or empty. |
35
|
| Missing a Javadoc comment. |
35
|
| Method 'setObjectInputStream' is not designed for extension - needs to be abstract, final or empty. |
39
|
| Missing a Javadoc comment. |
39
|
| Parameter objectInputStream should be final. |
39
|
| 'objectInputStream' hides a field. |
39
|
| Method 'getObjectOutputStream' is not designed for extension - needs to be abstract, final or empty. |
43
|
| Missing a Javadoc comment. |
43
|
| Method 'setObjectOutputStream' is not designed for extension - needs to be abstract, final or empty. |
47
|
| Missing a Javadoc comment. |
47
|
| Parameter objectOutputStream should be final. |
47
|
| 'objectOutputStream' hides a field. |
47
|
| Method 'getLoginData' is not designed for extension - needs to be abstract, final or empty. |
51
|
| Missing a Javadoc comment. |
51
|
| Method 'setLoginData' is not designed for extension - needs to be abstract, final or empty. |
55
|
| Missing a Javadoc comment. |
55
|
| Parameter loginData should be final. |
55
|
| 'loginData' hides a field. |
55
|
| Method 'getGameFactory' is not designed for extension - needs to be abstract, final or empty. |
59
|
| Missing a Javadoc comment. |
59
|
| Method 'setGameFactory' is not designed for extension - needs to be abstract, final or empty. |
63
|
| Missing a Javadoc comment. |
63
|
| Parameter gameFactory should be final. |
63
|
| 'gameFactory' hides a field. |
63
|
net/sourceforge/simplegamenet/framework/transport/ClientDisconnectionTask.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
7
|
| Parameter clientModem should be final. |
7
|
| 'clientModem' hides a field. |
7
|
| Line is longer than 80 characters. |
12
|
| Line is longer than 80 characters. |
13
|
| Line is longer than 80 characters. |
16
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
21
|
net/sourceforge/simplegamenet/framework/transport/ClientLoginException.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
7
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
18
|
| Parameter type should be final. |
18
|
| 'type' hides a field. |
18
|
| Missing a Javadoc comment. |
22
|
| Parameter type should be final. |
22
|
| 'type' hides a field. |
22
|
| Parameter string should be final. |
22
|
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. |
27
|
| Missing a Javadoc comment. |
27
|
net/sourceforge/simplegamenet/framework/transport/ClientLoginHandler.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
13
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
17
|
| Line is longer than 80 characters. |
20
|
| Method 'connect' is not designed for extension - needs to be abstract, final or empty. |
20
|
| Missing a Javadoc comment. |
20
|
| Parameter hostInetAddress should be final. |
20
|
| Parameter port should be final. |
20
|
| Parameter nickname should be final. |
20
|
| Line is longer than 80 characters. |
36
|
| Line is longer than 80 characters. |
42
|
| Line is longer than 80 characters. |
44
|
| Line is longer than 80 characters. |
46
|
| Line is longer than 80 characters. |
48
|
| Line is longer than 80 characters. |
49
|
| Line is longer than 80 characters. |
52
|
| Line is longer than 80 characters. |
53
|
| Line is longer than 80 characters. |
57
|
| Line is longer than 80 characters. |
59
|
| Line is longer than 80 characters. |
60
|
| Line is longer than 80 characters. |
61
|
| Line is longer than 80 characters. |
63
|
| Line is longer than 80 characters. |
65
|
| Line is longer than 80 characters. |
68
|
| Line is longer than 80 characters. |
70
|
| Line is longer than 80 characters. |
74
|
| Line is longer than 80 characters. |
82
|
| Line is longer than 80 characters. |
89
|
| Line is longer than 80 characters. |
99
|
net/sourceforge/simplegamenet/framework/transport/ClientModem.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
16
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
20
|
| Parameter clientEngine should be final. |
20
|
| 'clientEngine' hides a field. |
20
|
| Parameter socket should be final. |
20
|
| Parameter objectInputStream should be final. |
21
|
| Parameter objectOutputStream should be final. |
22
|
| Method 'processPacketInEventThread' is not designed for extension - needs to be abstract, final or empty. |
31
|
| Missing a Javadoc comment. |
31
|
| Parameter packet should be final. |
31
|
| Method 'processPacket' is not designed for extension - needs to be abstract, final or empty. |
35
|
| Missing a Javadoc comment. |
35
|
| Parameter packet should be final. |
35
|
| Line is longer than 80 characters. |
66
|
| Line is longer than 80 characters. |
88
|
| Line is longer than 80 characters. |
96
|
| Line is longer than 80 characters. |
106
|
| Line is longer than 80 characters. |
116
|
| Line is longer than 80 characters. |
164
|
| Line is longer than 80 characters. |
168
|
| Method 'sendChatMessage' is not designed for extension - needs to be abstract, final or empty. |
187
|
| Missing a Javadoc comment. |
187
|
| Parameter chatMessage should be final. |
187
|
| Method 'changeGameSettings' is not designed for extension - needs to be abstract, final or empty. |
191
|
| Missing a Javadoc comment. |
191
|
| Parameter gameSettings should be final. |
191
|
| Line is longer than 80 characters. |
192
|
| Method 'changePlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
195
|
| Missing a Javadoc comment. |
195
|
| Parameter playerSettings should be final. |
195
|
| Line is longer than 80 characters. |
196
|
| Method 'startGame' is not designed for extension - needs to be abstract, final or empty. |
199
|
| Missing a Javadoc comment. |
199
|
| Method 'sendData' is not designed for extension - needs to be abstract, final or empty. |
203
|
| Missing a Javadoc comment. |
203
|
| Parameter data should be final. |
203
|
| Method 'abortGame' is not designed for extension - needs to be abstract, final or empty. |
207
|
| Missing a Javadoc comment. |
207
|
| Method 'leaveServer' is not designed for extension - needs to be abstract, final or empty. |
211
|
| Missing a Javadoc comment. |
211
|
| Method 'leaveProtocolViolatingServer' is not designed for extension - needs to be abstract, final or empty. |
216
|
| Missing a Javadoc comment. |
216
|
| Method 'processDisconnectionInEventThread' is not designed for extension - needs to be abstract, final or empty. |
221
|
| Missing a Javadoc comment. |
221
|
| Method 'processDisconnection' is not designed for extension - needs to be abstract, final or empty. |
225
|
| Missing a Javadoc comment. |
225
|
| Missing a Javadoc comment. |
229
|
| Parameter removePlayerType should be final. |
229
|
| Line is longer than 80 characters. |
230
|
net/sourceforge/simplegamenet/framework/transport/ClientPacketTask.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
7
|
| Parameter clientModem should be final. |
7
|
| 'clientModem' hides a field. |
7
|
| Parameter packet should be final. |
7
|
| Line is longer than 80 characters. |
13
|
| Line is longer than 80 characters. |
14
|
| Line is longer than 80 characters. |
17
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
22
|
net/sourceforge/simplegamenet/framework/transport/Connection.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
11
|
| Variable 'socket' must be private and have accessor methods. |
11
|
| Missing a Javadoc comment. |
12
|
| Variable 'objectInputStream' must be private and have accessor methods. |
12
|
| Missing a Javadoc comment. |
13
|
| Variable 'objectOutputStream' must be private and have accessor methods. |
13
|
| Missing a Javadoc comment. |
15
|
| Variable 'inputThread' must be private and have accessor methods. |
15
|
| Missing a Javadoc comment. |
16
|
| Variable 'active' must be private and have accessor methods. |
16
|
| Missing a Javadoc comment. |
18
|
| Parameter socket should be final. |
18
|
| 'socket' hides a field. |
18
|
| Parameter objectInputStream should be final. |
19
|
| 'objectInputStream' hides a field. |
19
|
| Parameter objectOutputStream should be final. |
20
|
| 'objectOutputStream' hides a field. |
20
|
| Line is longer than 80 characters. |
26
|
| Missing a Javadoc comment. |
29
|
| Missing a Javadoc comment. |
33
|
| Parameter packet should be final. |
33
|
| Missing a Javadoc comment. |
35
|
| Missing a Javadoc comment. |
46
|
net/sourceforge/simplegamenet/framework/transport/GameIdentification.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
6
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
12
|
| Parameter name should be final. |
12
|
| 'name' hides a field. |
12
|
| Parameter version should be final. |
12
|
| 'version' hides a field. |
12
|
| Parameter author should be final. |
12
|
| 'author' hides a field. |
12
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
18
|
| Missing a Javadoc comment. |
18
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
22
|
| Missing a Javadoc comment. |
22
|
| Parameter name should be final. |
22
|
| 'name' hides a field. |
22
|
| Method 'getVersion' is not designed for extension - needs to be abstract, final or empty. |
26
|
| Missing a Javadoc comment. |
26
|
| Method 'setVersion' is not designed for extension - needs to be abstract, final or empty. |
30
|
| Missing a Javadoc comment. |
30
|
| Parameter version should be final. |
30
|
| 'version' hides a field. |
30
|
| Method 'getAuthor' is not designed for extension - needs to be abstract, final or empty. |
34
|
| Missing a Javadoc comment. |
34
|
| Method 'setAuthor' is not designed for extension - needs to be abstract, final or empty. |
38
|
| Missing a Javadoc comment. |
38
|
| Parameter author should be final. |
38
|
| 'author' hides a field. |
38
|
net/sourceforge/simplegamenet/framework/transport/GamesObjectInputStream.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
12
|
| Parameter in should be final. |
12
|
| Parameter gamesClassLoader should be final. |
12
|
| 'gamesClassLoader' hides a field. |
12
|
| Method 'resolveClass' is not designed for extension - needs to be abstract, final or empty. |
18
|
| Missing a Javadoc comment. |
18
|
| Parameter desc should be final. |
18
|
net/sourceforge/simplegamenet/framework/transport/LoginData.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
7
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
16
|
| Parameter playerID should be final. |
16
|
| 'playerID' hides a field. |
16
|
| Parameter gameSettings should be final. |
16
|
| 'gameSettings' hides a field. |
16
|
| Parameter playerSettingsArray should be final. |
17
|
| 'playerSettingsArray' hides a field. |
17
|
| Parameter gameState should be final. |
17
|
| 'gameState' hides a field. |
17
|
| Method 'getPlayerID' is not designed for extension - needs to be abstract, final or empty. |
24
|
| Missing a Javadoc comment. |
24
|
| Method 'setPlayerID' is not designed for extension - needs to be abstract, final or empty. |
28
|
| Missing a Javadoc comment. |
28
|
| Parameter playerID should be final. |
28
|
| 'playerID' hides a field. |
28
|
| Method 'getGameSettings' is not designed for extension - needs to be abstract, final or empty. |
32
|
| Missing a Javadoc comment. |
32
|
| Method 'setGameSettings' is not designed for extension - needs to be abstract, final or empty. |
36
|
| Missing a Javadoc comment. |
36
|
| Parameter gameSettings should be final. |
36
|
| 'gameSettings' hides a field. |
36
|
| Method 'getPlayerSettingsArray' is not designed for extension - needs to be abstract, final or empty. |
40
|
| Missing a Javadoc comment. |
40
|
| Method 'setPlayerSettingsArray' is not designed for extension - needs to be abstract, final or empty. |
44
|
| Missing a Javadoc comment. |
44
|
| Parameter playerSettingsArray should be final. |
44
|
| 'playerSettingsArray' hides a field. |
44
|
| Method 'getGameState' is not designed for extension - needs to be abstract, final or empty. |
48
|
| Missing a Javadoc comment. |
48
|
| Method 'setGameState' is not designed for extension - needs to be abstract, final or empty. |
52
|
| Missing a Javadoc comment. |
52
|
| Parameter gameState should be final. |
52
|
| 'gameState' hides a field. |
52
|
net/sourceforge/simplegamenet/framework/transport/Modem.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
7
|
| Variable 'taskQueue' must be private and have accessor methods. |
7
|
| Missing a Javadoc comment. |
8
|
| Variable 'nextPingID' must be private and have accessor methods. |
8
|
| Missing a Javadoc comment. |
9
|
| Variable 'pingIDMap' must be private and have accessor methods. |
9
|
| '8' is a magic number. |
9
|
| Missing a Javadoc comment. |
11
|
net/sourceforge/simplegamenet/framework/transport/NewConnectionData.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
7
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
11
|
| Missing a Javadoc comment. |
12
|
| Missing a Javadoc comment. |
14
|
| Parameter socket should be final. |
14
|
| 'socket' hides a field. |
14
|
| Parameter objectInputStream should be final. |
14
|
| 'objectInputStream' hides a field. |
14
|
| Parameter objectOutputStream should be final. |
15
|
| 'objectOutputStream' hides a field. |
15
|
| Parameter nickname should be final. |
15
|
| 'nickname' hides a field. |
15
|
| Method 'getSocket' is not designed for extension - needs to be abstract, final or empty. |
22
|
| Missing a Javadoc comment. |
22
|
| Method 'setSocket' is not designed for extension - needs to be abstract, final or empty. |
26
|
| Missing a Javadoc comment. |
26
|
| Parameter socket should be final. |
26
|
| 'socket' hides a field. |
26
|
| Method 'getObjectInputStream' is not designed for extension - needs to be abstract, final or empty. |
30
|
| Missing a Javadoc comment. |
30
|
| Method 'setObjectInputStream' is not designed for extension - needs to be abstract, final or empty. |
34
|
| Missing a Javadoc comment. |
34
|
| Parameter objectInputStream should be final. |
34
|
| 'objectInputStream' hides a field. |
34
|
| Method 'getObjectOutputStream' is not designed for extension - needs to be abstract, final or empty. |
38
|
| Missing a Javadoc comment. |
38
|
| Method 'setObjectOutputStream' is not designed for extension - needs to be abstract, final or empty. |
42
|
| Missing a Javadoc comment. |
42
|
| Parameter objectOutputStream should be final. |
42
|
| 'objectOutputStream' hides a field. |
42
|
| Method 'getNickname' is not designed for extension - needs to be abstract, final or empty. |
46
|
| Missing a Javadoc comment. |
46
|
| Method 'setNickname' is not designed for extension - needs to be abstract, final or empty. |
50
|
| Missing a Javadoc comment. |
50
|
| Parameter nickname should be final. |
50
|
| 'nickname' hides a field. |
50
|
net/sourceforge/simplegamenet/framework/transport/NewConnectionTask.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Redundant import from the same package - net.sourceforge.simplegamenet.framework.transport.NewConnectionData. |
3
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
7
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
10
|
| Parameter serverModem should be final. |
10
|
| 'serverModem' hides a field. |
10
|
| Parameter newConnectionData should be final. |
11
|
| 'newConnectionData' hides a field. |
11
|
| Line is longer than 80 characters. |
17
|
| Line is longer than 80 characters. |
18
|
| Line is longer than 80 characters. |
21
|
net/sourceforge/simplegamenet/framework/transport/Packet.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
7
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
15
|
| Parameter packetCode should be final. |
15
|
| 'packetCode' hides a field. |
15
|
| Parameter data should be final. |
15
|
| 'data' hides a field. |
15
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
20
|
| Missing a Javadoc comment. |
20
|
| '16' is a magic number. |
21
|
| Avoid inline conditionals. |
22
|
| Method 'getPacketCode' is not designed for extension - needs to be abstract, final or empty. |
25
|
| Missing a Javadoc comment. |
25
|
| Method 'setPacketCode' is not designed for extension - needs to be abstract, final or empty. |
29
|
| Missing a Javadoc comment. |
29
|
| Parameter packetCode should be final. |
29
|
| 'packetCode' hides a field. |
29
|
| Method 'getData' is not designed for extension - needs to be abstract, final or empty. |
33
|
| Missing a Javadoc comment. |
33
|
| Method 'setData' is not designed for extension - needs to be abstract, final or empty. |
37
|
| Missing a Javadoc comment. |
37
|
| Parameter data should be final. |
37
|
| 'data' hides a field. |
37
|
net/sourceforge/simplegamenet/framework/transport/PacketCodes.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| interfaces should describe a type and hence have methods. |
3
|
| Missing a Javadoc comment. |
5
|
| Redundant 'public' modifier. |
5
|
| Missing a Javadoc comment. |
6
|
| Redundant 'public' modifier. |
6
|
| Missing a Javadoc comment. |
7
|
| Redundant 'public' modifier. |
7
|
| Missing a Javadoc comment. |
8
|
| Redundant 'public' modifier. |
8
|
| Missing a Javadoc comment. |
9
|
| Redundant 'public' modifier. |
9
|
| Missing a Javadoc comment. |
10
|
| Redundant 'public' modifier. |
10
|
| Missing a Javadoc comment. |
11
|
| Redundant 'public' modifier. |
11
|
| Missing a Javadoc comment. |
12
|
| Redundant 'public' modifier. |
12
|
| Missing a Javadoc comment. |
13
|
| Redundant 'public' modifier. |
13
|
| Missing a Javadoc comment. |
14
|
| Redundant 'public' modifier. |
14
|
| Missing a Javadoc comment. |
15
|
| Redundant 'public' modifier. |
15
|
| Missing a Javadoc comment. |
16
|
| Redundant 'public' modifier. |
16
|
| Missing a Javadoc comment. |
17
|
| Redundant 'public' modifier. |
17
|
| Missing a Javadoc comment. |
18
|
| Redundant 'public' modifier. |
18
|
| Missing a Javadoc comment. |
20
|
| Redundant 'public' modifier. |
20
|
| Missing a Javadoc comment. |
21
|
| Redundant 'public' modifier. |
21
|
| Missing a Javadoc comment. |
22
|
| Redundant 'public' modifier. |
22
|
| Missing a Javadoc comment. |
23
|
| Redundant 'public' modifier. |
23
|
| Missing a Javadoc comment. |
25
|
| Redundant 'public' modifier. |
25
|
| Missing a Javadoc comment. |
26
|
| Redundant 'public' modifier. |
26
|
| Missing a Javadoc comment. |
27
|
| Redundant 'public' modifier. |
27
|
| Missing a Javadoc comment. |
29
|
| Redundant 'public' modifier. |
29
|
| Line is longer than 80 characters. |
30
|
| Missing a Javadoc comment. |
30
|
| Redundant 'public' modifier. |
30
|
| Line is longer than 80 characters. |
31
|
| Missing a Javadoc comment. |
31
|
| Redundant 'public' modifier. |
31
|
| Missing a Javadoc comment. |
32
|
| Redundant 'public' modifier. |
32
|
| Missing a Javadoc comment. |
34
|
| Redundant 'public' modifier. |
34
|
| Missing a Javadoc comment. |
36
|
| Redundant 'public' modifier. |
36
|
| Line is longer than 80 characters. |
37
|
| Missing a Javadoc comment. |
37
|
| Redundant 'public' modifier. |
37
|
| Line is longer than 80 characters. |
38
|
| Missing a Javadoc comment. |
38
|
| Redundant 'public' modifier. |
38
|
| Missing a Javadoc comment. |
39
|
| Redundant 'public' modifier. |
39
|
| Missing a Javadoc comment. |
41
|
| Redundant 'public' modifier. |
41
|
| Missing a Javadoc comment. |
42
|
| Redundant 'public' modifier. |
42
|
| Missing a Javadoc comment. |
43
|
| Redundant 'public' modifier. |
43
|
| Missing a Javadoc comment. |
44
|
| Redundant 'public' modifier. |
44
|
| Missing a Javadoc comment. |
45
|
| Redundant 'public' modifier. |
45
|
| Missing a Javadoc comment. |
46
|
| Redundant 'public' modifier. |
46
|
| Missing a Javadoc comment. |
47
|
| Redundant 'public' modifier. |
47
|
| Missing a Javadoc comment. |
48
|
| Redundant 'public' modifier. |
48
|
| Missing a Javadoc comment. |
49
|
| Redundant 'public' modifier. |
49
|
| Missing a Javadoc comment. |
50
|
| Redundant 'public' modifier. |
50
|
| Missing a Javadoc comment. |
51
|
| Redundant 'public' modifier. |
51
|
| Missing a Javadoc comment. |
52
|
| Redundant 'public' modifier. |
52
|
| Missing a Javadoc comment. |
54
|
| Redundant 'public' modifier. |
54
|
| Missing a Javadoc comment. |
55
|
| Redundant 'public' modifier. |
55
|
| Missing a Javadoc comment. |
56
|
| Redundant 'public' modifier. |
56
|
| Missing a Javadoc comment. |
58
|
| Redundant 'public' modifier. |
58
|
| Missing a Javadoc comment. |
59
|
| Redundant 'public' modifier. |
59
|
| Missing a Javadoc comment. |
61
|
| Redundant 'public' modifier. |
61
|
| Missing a Javadoc comment. |
62
|
| Redundant 'public' modifier. |
62
|
| Missing a Javadoc comment. |
63
|
| Redundant 'public' modifier. |
63
|
| Missing a Javadoc comment. |
64
|
| Redundant 'public' modifier. |
64
|
| Missing a Javadoc comment. |
65
|
| Redundant 'public' modifier. |
65
|
| Missing a Javadoc comment. |
66
|
| Redundant 'public' modifier. |
66
|
| Missing a Javadoc comment. |
67
|
| Redundant 'public' modifier. |
67
|
net/sourceforge/simplegamenet/framework/transport/PacketTask.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Redundant import from the same package - net.sourceforge.simplegamenet.framework.transport.Packet. |
3
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
7
|
| Variable 'packet' must be private and have accessor methods. |
7
|
| Missing a Javadoc comment. |
9
|
| Parameter packet should be final. |
9
|
| 'packet' hides a field. |
9
|
net/sourceforge/simplegamenet/framework/transport/RemovePlayerType.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| interfaces should describe a type and hence have methods. |
3
|
| Missing a Javadoc comment. |
5
|
| Redundant 'public' modifier. |
5
|
| Missing a Javadoc comment. |
6
|
| Redundant 'public' modifier. |
6
|
| Missing a Javadoc comment. |
7
|
| Redundant 'public' modifier. |
7
|
| Missing a Javadoc comment. |
8
|
| Redundant 'public' modifier. |
8
|
| Missing a Javadoc comment. |
9
|
| Redundant 'public' modifier. |
9
|
| Missing a Javadoc comment. |
10
|
| Redundant 'public' modifier. |
10
|
| Missing a Javadoc comment. |
11
|
| Redundant 'public' modifier. |
11
|
net/sourceforge/simplegamenet/framework/transport/ServerConnection.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
10
|
| Variable 'serverModem' must be private and have accessor methods. |
10
|
| Missing a Javadoc comment. |
11
|
| Variable 'playerID' must be private and have accessor methods. |
11
|
| Missing a Javadoc comment. |
13
|
| Variable 'gameEndUnprocessed' must be private and have accessor methods. |
13
|
| Line is longer than 80 characters. |
15
|
| Missing a Javadoc comment. |
15
|
| Parameter serverModem should be final. |
15
|
| 'serverModem' hides a field. |
15
|
| Parameter playerID should be final. |
15
|
| 'playerID' hides a field. |
15
|
| Parameter socket should be final. |
15
|
| Parameter objectInputStream should be final. |
16
|
| Parameter objectOutputStream should be final. |
17
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
23
|
| Missing a Javadoc comment. |
23
|
| Method 'sendPacket' is not designed for extension - needs to be abstract, final or empty. |
43
|
| Missing a Javadoc comment. |
43
|
| Parameter packet should be final. |
43
|
| Method 'setGameEndUnprocessed' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Missing a Javadoc comment. |
54
|
| Parameter gameEndUnprocessed should be final. |
54
|
| 'gameEndUnprocessed' hides a field. |
54
|
| Method 'close' is not designed for extension - needs to be abstract, final or empty. |
58
|
| Missing a Javadoc comment. |
58
|
net/sourceforge/simplegamenet/framework/transport/ServerDisconnectionTask.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
3
|
| Missing a Javadoc comment. |
5
|
| Missing a Javadoc comment. |
6
|
| Missing a Javadoc comment. |
8
|
| Parameter serverModem should be final. |
8
|
| 'serverModem' hides a field. |
8
|
| Parameter playerID should be final. |
8
|
| 'playerID' hides a field. |
8
|
| Line is longer than 80 characters. |
14
|
| Line is longer than 80 characters. |
15
|
| Line is longer than 80 characters. |
18
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
23
|
net/sourceforge/simplegamenet/framework/transport/ServerListener.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
19
|
| Missing a Javadoc comment. |
21
|
| Missing a Javadoc comment. |
23
|
| Missing a Javadoc comment. |
24
|
| Missing a Javadoc comment. |
26
|
| '8' is a magic number. |
26
|
| Line is longer than 80 characters. |
28
|
| Missing a Javadoc comment. |
28
|
| Parameter serverModem should be final. |
28
|
| 'serverModem' hides a field. |
28
|
| Parameter port should be final. |
28
|
| Line is longer than 80 characters. |
32
|
| Method 'addBannedInetAddress' is not designed for extension - needs to be abstract, final or empty. |
36
|
| Missing a Javadoc comment. |
36
|
| Parameter inetAddress should be final. |
36
|
| Method 'start' is not designed for extension - needs to be abstract, final or empty. |
40
|
| Missing a Javadoc comment. |
40
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
44
|
| Missing a Javadoc comment. |
44
|
| Line is longer than 80 characters. |
56
|
| Line is longer than 80 characters. |
58
|
| Line is longer than 80 characters. |
75
|
| Line is longer than 80 characters. |
79
|
| Line is longer than 80 characters. |
85
|
| Line is longer than 80 characters. |
87
|
| Line is longer than 80 characters. |
91
|
| Line is longer than 80 characters. |
98
|
| Line is longer than 80 characters. |
104
|
| Line is longer than 80 characters. |
106
|
| Line is longer than 80 characters. |
113
|
| Method 'close' is not designed for extension - needs to be abstract, final or empty. |
137
|
| Missing a Javadoc comment. |
137
|
| Must have at least one statement. |
142
|
net/sourceforge/simplegamenet/framework/transport/ServerModem.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
15
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
21
|
| '8' is a magic number. |
21
|
| Missing a Javadoc comment. |
23
|
| Line is longer than 80 characters. |
25
|
| Missing a Javadoc comment. |
25
|
| Parameter serverEngine should be final. |
25
|
| Parameter port should be final. |
25
|
| Line is longer than 80 characters. |
28
|
| Method 'processPacketInServerThread' is not designed for extension - needs to be abstract, final or empty. |
34
|
| Missing a Javadoc comment. |
34
|
| Parameter playerID should be final. |
34
|
| Parameter packet should be final. |
34
|
| Method 'processPacket' is not designed for extension - needs to be abstract, final or empty. |
38
|
| Missing a Javadoc comment. |
38
|
| Parameter playerID should be final. |
38
|
| Parameter packet should be final. |
38
|
| Line is longer than 80 characters. |
39
|
| Line is longer than 80 characters. |
63
|
| Line is longer than 80 characters. |
79
|
| Line is longer than 80 characters. |
82
|
| Line is longer than 80 characters. |
91
|
| Line is longer than 80 characters. |
99
|
| Line is longer than 80 characters. |
102
|
| Line is longer than 80 characters. |
107
|
| Line is longer than 80 characters. |
142
|
| Line is longer than 80 characters. |
144
|
| Method 'sendChatMessage' is not designed for extension - needs to be abstract, final or empty. |
158
|
| Missing a Javadoc comment. |
158
|
| Parameter playerID should be final. |
158
|
| Parameter chatMessage should be final. |
158
|
| Method 'sendChatMessage' is not designed for extension - needs to be abstract, final or empty. |
167
|
| Missing a Javadoc comment. |
167
|
| Parameter chatMessage should be final. |
167
|
| Method 'updateGameSettings' is not designed for extension - needs to be abstract, final or empty. |
171
|
| Missing a Javadoc comment. |
171
|
| Parameter gameSettings should be final. |
171
|
| Line is longer than 80 characters. |
175
|
| Method 'addNewConnectionInEventThread' is not designed for extension - needs to be abstract, final or empty. |
175
|
| Missing a Javadoc comment. |
175
|
| Parameter newConnectionData should be final. |
175
|
| Method 'addNewConnection' is not designed for extension - needs to be abstract, final or empty. |
179
|
| Missing a Javadoc comment. |
179
|
| Parameter newConnectionData should be final. |
179
|
| Line is longer than 80 characters. |
186
|
| Line is longer than 80 characters. |
206
|
| Method 'updatePlayerSettings' is not designed for extension - needs to be abstract, final or empty. |
216
|
| Missing a Javadoc comment. |
216
|
| Parameter playerSettings should be final. |
216
|
| Method 'kickPlayer' is not designed for extension - needs to be abstract, final or empty. |
220
|
| Missing a Javadoc comment. |
220
|
| Parameter playerID should be final. |
220
|
| Line is longer than 80 characters. |
221
|
| Line is longer than 80 characters. |
222
|
| Method 'banPlayer' is not designed for extension - needs to be abstract, final or empty. |
226
|
| Missing a Javadoc comment. |
226
|
| Parameter playerID should be final. |
226
|
| Line is longer than 80 characters. |
227
|
| Line is longer than 80 characters. |
230
|
| Line is longer than 80 characters. |
234
|
| Method 'kickProtocolViolatingPlayer' is not designed for extension - needs to be abstract, final or empty. |
234
|
| Missing a Javadoc comment. |
234
|
| Parameter playerID should be final. |
234
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
234
|
| Line is longer than 80 characters. |
238
|
| Method 'processDisconnectionInEventThread' is not designed for extension - needs to be abstract, final or empty. |
246
|
| Missing a Javadoc comment. |
246
|
| Parameter playerID should be final. |
246
|
| Method 'processDisconnection' is not designed for extension - needs to be abstract, final or empty. |
250
|
| Missing a Javadoc comment. |
250
|
| Parameter playerID should be final. |
250
|
| Line is longer than 80 characters. |
251
|
| Line is longer than 80 characters. |
256
|
| Missing a Javadoc comment. |
261
|
| Parameter playerID should be final. |
261
|
| Parameter removePlayerType should be final. |
261
|
| Method 'gameStarted' is not designed for extension - needs to be abstract, final or empty. |
266
|
| Missing a Javadoc comment. |
266
|
| Line is longer than 80 characters. |
270
|
| Method 'sendData' is not designed for extension - needs to be abstract, final or empty. |
270
|
| Missing a Javadoc comment. |
270
|
| Parameter playerID should be final. |
270
|
| Parameter data should be final. |
270
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
270
|
| Method 'sendData' is not designed for extension - needs to be abstract, final or empty. |
279
|
| Missing a Javadoc comment. |
279
|
| Parameter data should be final. |
279
|
| Method 'gameStopping' is not designed for extension - needs to be abstract, final or empty. |
283
|
| Missing a Javadoc comment. |
283
|
| Method 'gameAborting' is not designed for extension - needs to be abstract, final or empty. |
287
|
| Missing a Javadoc comment. |
287
|
| Method 'gameEnded' is not designed for extension - needs to be abstract, final or empty. |
291
|
| Missing a Javadoc comment. |
291
|
| Parameter playerID should be final. |
291
|
| Redundant throws: 'ClassCastException' is unchecked exception. |
291
|
| Line is longer than 80 characters. |
293
|
| Method 'getServerEngineImpl' is not designed for extension - needs to be abstract, final or empty. |
302
|
| Missing a Javadoc comment. |
302
|
| Missing a Javadoc comment. |
306
|
| Parameter packet should be final. |
306
|
| Missing a Javadoc comment. |
314
|
| Parameter packet should be final. |
314
|
| Parameter playerID should be final. |
314
|
| Missing a Javadoc comment. |
324
|
| Parameter packet should be final. |
324
|
| Method 'closeServerInServerThread' is not designed for extension - needs to be abstract, final or empty. |
335
|
| Missing a Javadoc comment. |
335
|
| Method 'closeServer' is not designed for extension - needs to be abstract, final or empty. |
343
|
| Missing a Javadoc comment. |
343
|
net/sourceforge/simplegamenet/framework/transport/ServerPacketTask.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Redundant import from the same package - net.sourceforge.simplegamenet.framework.transport.Packet. |
3
|
| Redundant import from the same package - net.sourceforge.simplegamenet.framework.transport.PacketTask. |
4
|
| Redundant import from the same package - net.sourceforge.simplegamenet.framework.transport.ServerModem. |
5
|
| Missing a Javadoc comment. |
7
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
11
|
| Variable 'playerID' must be private and have accessor methods. |
11
|
| Line is longer than 80 characters. |
13
|
| Missing a Javadoc comment. |
13
|
| Parameter serverModem should be final. |
13
|
| 'serverModem' hides a field. |
13
|
| Parameter playerID should be final. |
13
|
| 'playerID' hides a field. |
13
|
| Parameter packet should be final. |
13
|
| Line is longer than 80 characters. |
20
|
| Line is longer than 80 characters. |
21
|
| Line is longer than 80 characters. |
24
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
29
|
net/sourceforge/simplegamenet/framework/transport/TaskQueue.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
5
|
| Missing a Javadoc comment. |
7
|
| Missing a Javadoc comment. |
9
|
| Missing a Javadoc comment. |
10
|
| Missing a Javadoc comment. |
11
|
| Line is longer than 80 characters. |
12
|
| Missing a Javadoc comment. |
14
|
| Missing a Javadoc comment. |
16
|
| Parameter dispatchToEventThread should be final. |
16
|
| 'dispatchToEventThread' hides a field. |
16
|
| Method 'start' is not designed for extension - needs to be abstract, final or empty. |
20
|
| Missing a Javadoc comment. |
20
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
24
|
| Missing a Javadoc comment. |
24
|
| Must have at least one statement. |
31
|
| Method 'addTask' is not designed for extension - needs to be abstract, final or empty. |
66
|
| Missing a Javadoc comment. |
66
|
| Parameter task should be final. |
66
|
| Method 'close' is not designed for extension - needs to be abstract, final or empty. |
73
|
| Missing a Javadoc comment. |
73
|
net/sourceforge/simplegamenet/framework/transport/package.html
Error | Line |
| Missing package documentation file. | 0 |